From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C289BC25B4E for ; Fri, 20 Jan 2023 11:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D34C96B0072; Fri, 20 Jan 2023 06:32:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE4B86B0073; Fri, 20 Jan 2023 06:32:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B85F56B0074; Fri, 20 Jan 2023 06:32:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5F096B0072 for ; Fri, 20 Jan 2023 06:32:11 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6139314013C for ; Fri, 20 Jan 2023 11:32:11 +0000 (UTC) X-FDA: 80374963662.26.62174C3 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 7708D20018 for ; Fri, 20 Jan 2023 11:32:09 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Nx4ATz1q; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674214329; a=rsa-sha256; cv=none; b=M0cLraJ/yVQD5lIVxJ6YDzhX+wCnTddFYgz2J4+EOnWWL2TPc8hIDfC+zGBWwXeTWPHFXH OcqhuBEXa4JwBj4rvg5+npZyWgMqk550KzsaAT42e39xxJDBoc1GOXpU3C/VzagoWFHd8s Am++eErOu2cK3LFeO6qccbBxIFxtFSA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Nx4ATz1q; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674214329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dENyxwGDrF37mbcKQOU5k/eY+nFRM44njiW8sEvho1E=; b=s85gGHieYDn4cEGvXTkug9Cy16UcZwP/tkTGs3ARkSRZp1sRZjgGH0dBiDwU+uKOaBNdtT Oxsn6oEoBRZ0LjE67DbShNO42ArkooHCI7dm3kFT4bgjdH9H7d2D3Gw/RBZvMz/sjbRF0I 1S70ejisOPKa1NEaqgrzRALH21G7oXs= Received: by mail-ej1-f46.google.com with SMTP id ss4so13113122ejb.11 for ; Fri, 20 Jan 2023 03:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=dENyxwGDrF37mbcKQOU5k/eY+nFRM44njiW8sEvho1E=; b=Nx4ATz1q6ETQJWTvXMoMygiJPbXYqAF42gZEdVuC0DtAL4QNgG4/F/zNTlc3Z4KTsP +wOOv06HnUWoWa0BnsqrSzy6TWG3JqRmhRR1RbDJNuvYMSMJg9dBhT6heo6RSqhmFdqi pH1cqqZI8rPm5PUFWj0eFq/D3BkuRp4jsqg8ZSB+WChSOYI/ARW4gtMauuZbf8qf93zd nhnn+1XrwWUFpAstSoCWaUKnb7o8uFUhSoELyHNkJNhTKGEYXm8Np6lJbVCTA4tiFJ5J aa2owYkPnIJ8CCwjXkzKdgCmKSbyxIqHAYJ0yQJg2K/X3kTHLA32jRbpDlPXL5C5xVtH mVAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dENyxwGDrF37mbcKQOU5k/eY+nFRM44njiW8sEvho1E=; b=GFl3XfVKhtpIeQkXUJYvHGCdS8WIe2xoUbcCPyjk02esdEoHi4y0b1v8KaFKlQQpzv PW2pjDJRxtACR46/IP33SmSIoHdU8MNZYHgpOvSE0Mbae/68yPWgR2M7aJrDe5ORU2IH cLR6eFXoad8hcBxAdTNafCnh5shRV7MfuMagAlThnS1maGQGuhEK/jpBQqrsIyCC+wwV 4wZwBgSmwp/IxyJ9ZxMS96n2V8hoaqLIh0Deu+VrvwjAyFuPN3mFIMgexLJiOvukb+Eo WSfZZSwlLGJ43FZTJtK8PvYe/HJLa6JR9l4qpDzWVsmS2P65dlwDCmL3JxbuU/vvtOp+ N1NA== X-Gm-Message-State: AFqh2kpmupp2VySP5APbtMN/MWm/f3nVKzjQB6Qn9DQ+v32+2TbhCCuR WzYJ82LeD4E8lXXoynThaB0= X-Google-Smtp-Source: AMrXdXsZ5CobVxc38Vuu0b6R97dCsx6nomoOPTA44wXpdXmzyXyVk8r5qopHt6EKehMdhpc3X9oDIQ== X-Received: by 2002:a17:906:3bd8:b0:7c0:b3a3:9b70 with SMTP id v24-20020a1709063bd800b007c0b3a39b70mr15481664ejf.62.1674214327853; Fri, 20 Jan 2023 03:32:07 -0800 (PST) Received: from pc636 (host-90-235-24-47.mobileonline.telia.com. [90.235.24.47]) by smtp.gmail.com with ESMTPSA id ui18-20020a170907c91200b00872c3e8d4e0sm5543112ejc.13.2023.01.20.03.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 03:32:07 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 20 Jan 2023 12:32:04 +0100 To: Christoph Hellwig Cc: Uladzislau Rezki , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 06/10] mm: move __remove_vm_area out of va_remove_mappings Message-ID: References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-7-hch@lst.de> <20230120074137.GA26815@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230120074137.GA26815@lst.de> X-Rspam-User: X-Rspamd-Queue-Id: 7708D20018 X-Rspamd-Server: rspam01 X-Stat-Signature: gics6roqkoaf7cy378dqzmcbj3ka5mtr X-HE-Tag: 1674214329-824919 X-HE-Meta: U2FsdGVkX19jY6c4NWFdJzg1rjLwHpITOJAzEm6iP8+8up7c+k3W4pRChMyMfcxFd9HGZFZsHd2YRmKxNFRtuTIE5HGgzCqx3nws426Dy0Didb2yiK93JTf4mU1cs1D1UbvbGIFxN3j+mejievvbWIuFZvEtJE8d0+PLXrKGQfc2bgeBru1ivV45aatCZjgiKB7k2jXsleW31TBV1lG7ZTwEjQpNbrLjS86E+huHNOVZX0T2DtvFPmmn2bjKzyK8S8KVNqtO8KRJS3l9ntStA23PnC+IAgk0mWKhb9ae/MIfuKbRD8jnSbeT/0EU9sdPs6NZ0Auy6VFYPos3rllGE5D8zjnfGC7WK4UgfZpktGWmqRhRqglg0X2nGh/2uh0pek8DsvT0bFjXUB7derPZziT1c34SDoQmpNp9Ks8ncl3R5YX3oZMwVt7UZFE1Pu4p7cSxOFaWRxa4FBS09GCJ6ptqsHCMPPGuszSrOr7tZ+r4iVB6GnlekdB/8gDlj4Q/xvpoGMRLcD0XI0yiSUCa4mPsN7bwM0IQQt8wYkMwcT4PM15qcTns7dEC1b9GrbOEyVCyAwxl+n3gArT23q6zKQb4E6SHGENMR7Fqjtc75WSLw8xu5I5jwDdqtXtSNGffIDR9anpnxWnRSInI26ZJh0yDS7Q16Pecr1GG7Yf9q1K9N+N5PnfZUWD0KIAM/lfRbbLaxDSkIEJQy2Ck99Lv4K1iqsSV9+iT008vBw1ji8SJpuye4mAOh1AIzZvkSSeG4JUsThFrfPw7hUvZ4H2vhF9ov6xvbYLCJycHKvbUN8dmsOChgAmx9uFDxzaVBgGaVJPFetiUx3mZF3lLa0XlyIKX3Wel7uKyh+7S5zPsWRDMdUy68CS8FtBtCvF3xGK6I747z+3g4Ek96Vyf4e4eHYMhe53E2T9OzhFuqMt/ISamK29RFK6nLLpW9UnROB+M4YRdP9sMKEUudc7wPE1 SYX/r74P stxgMQ3OpJBYuzFB5gBH5UncZQfmW2X1WBstgjCB9859/ECEJervlcErNFLfS/BwQuOReNyjvGO7vaWxXcpnpTFlt8kXvZki/5Y+Of8nq8PbiBX0A1uQ3/6qq8c/ytWSYfuqyTowTp2+KoAJhfAbDuPXQqJ88n7zE9I0MZnDx0tPv7mbOdqYZeccskRi1kiUy+rH+YJB9d9p2YDl6mAMnrzQ4FPEZA4JRD1Bhn2BJD9wn2N+CTQNlbGW6uxyYiCzSaFHe23dgtCxc6DGqvjsUjrgDkp0EmnSbCG1gWch4RxrGB8wukut8dNXS0yUR5fSRvgx1vvZCpwzVNCIdVCTbZnkoogCFO+9Hc9rpguK1mIw5se/29uBfaGA9BrUCq1YLxcOdCYEDxYtJ5fqniz5KeNyT5Ajpo73NkgTuCZSVcZoLI5Bv06A9clVphcnuZbJgy+YV2NVFG1t73QnjV1biWpZDNMpC9I745yDvM/IH+StpmXc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003214, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 20, 2023 at 08:41:37AM +0100, Christoph Hellwig wrote: > On Thu, Jan 19, 2023 at 07:48:48PM +0100, Uladzislau Rezki wrote: > > A small nit here. IMHO, a va_remove_mappings() should be > > renamed back to vm_remove_mappings() since after this patch > > it starts deal with "struct vm_struct". > > > > OK. After checking all patches this function will be renamed > > anyway to vm_reset_perms(). > > І could rename it. It's not that much more churn given that > the prototype is touched anyway. > A new vm_reset_perms() name matches the VM_FLUSH_RESET_PERMS flag what, i think, is totally fine. -- Uladzislau Rezki