From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA7AC38159 for ; Fri, 20 Jan 2023 06:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AFE06B0074; Fri, 20 Jan 2023 01:00:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85F436B0081; Fri, 20 Jan 2023 01:00:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 726E76B0082; Fri, 20 Jan 2023 01:00:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5FF2D6B0074 for ; Fri, 20 Jan 2023 01:00:17 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0C9D21A0E42 for ; Fri, 20 Jan 2023 06:00:17 +0000 (UTC) X-FDA: 80374127274.16.AB0F14E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 506E4140019 for ; Fri, 20 Jan 2023 06:00:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AiVphAZw; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674194415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=grTPQVs1o65Goog9D411dPyOgF0S6jRwshWihcoTPGM=; b=UnhYK4LX5JgkiPwZLIYHX02ZwUm0lx/n7SLcLTPiBxKsi6vfZokRz9QyHRdbYi9NoCEXPy R61ztDMsU2so54/BSuCetNTbe+yqDt6X4XQaTn8ZOrtuwb0sF8w+7S9k4EHZ0ipM1W4jmZ pDhGFvX+GWsTzp3AWgbhIow23F/ONbw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AiVphAZw; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674194415; a=rsa-sha256; cv=none; b=OHgJwg+ZUf0eMuAPWZrw3TIu7AwcVUKEJvEkZHfHsfRQe6b2w8zPbpkiMHt6RZtHqRQ8Sy d03vtaEX7wQn8T9ajRNDAoEtdbKi1BDvilNi77s8uKFCrR/SvZdtop2Lf3yoBQxuqY+P/e 6rYE4LjESWxhWDyTsalkTlu5dG0cY58= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=grTPQVs1o65Goog9D411dPyOgF0S6jRwshWihcoTPGM=; b=AiVphAZwRIN0bxGiIURZtJrD5W 6xPn51wT93XyajnEGvoZPto3pOPOSaau1L3dZgkJht5L0c3PPesyQXaWf0o4vjvaHhpQa7sqBe6DT gjHEK8ZdiaqAiYLRuc8yqbbUc39taM2LMi4JIkkjpVMW1AbGLcC08VWYnFMG5Sk2C+0929pUqsD0j JC+PZ7tWKcZdryy+XtZFxLsZWE9sxcbORKbbuVv9gEiQZ3VKZw8ig/AxHqlB79qTwe3+jQB3+l1wG iFRjY7KcgaqfRBz4ARwNFSmqKg01wGlEVlyCgO3lj54aoofEv4LiY4RuMpQbxOXovBlcaBcuC3rUP SjhrliFw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIkRZ-001iHW-G2; Fri, 20 Jan 2023 06:00:05 +0000 Date: Fri, 20 Jan 2023 06:00:05 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, jhubbard@nvidia.com Subject: Re: [PATCH 4/9] mm/rmap: change hugepage_add_new_anon_rmap to take in a folio Message-ID: References: <20230119211446.54165-1-sidhartha.kumar@oracle.com> <20230119211446.54165-5-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119211446.54165-5-sidhartha.kumar@oracle.com> X-Stat-Signature: 1ggy7yxe4ksri89dqo51ih7kzdtj4my9 X-Rspam-User: X-Rspamd-Queue-Id: 506E4140019 X-Rspamd-Server: rspam06 X-HE-Tag: 1674194415-746527 X-HE-Meta: U2FsdGVkX19b5RE/lnCy2YUgOnuBLOM4dEAHOpZEJn9phsb/0jbp3Ffpml3TihR/hOjDVUuI07Zp1CjFoCvHLQcr9JYKM+rEWxUspFFJhjGMMVRAgPoFGOXPpNUM/lf+cHwtfRrcSaJRpFYDD0bcz0LqAdyTLErXDyudIR7CSHngK79n5gaIlVx4jkcc08feL2bjXOok5pB55XgNpPk3I9yp5x9qwWlNcF0RHlBv+nbNg/g5FRXA3KKfkDhNKXvtMUpEdzLshVTTjId6OvZkqQ+WyRxpFUMfsRrsMCGmgGrpEKLtMz4ED1alqXZCSRbpPamkBdQY4HfSw3vb0hp7oKbG80mtfZlXnXruuTfGv6a2ATxuHU55crL1Rz0ijfuteEQxYuM7NSfyb7qLKwP1F3G5bhf6k72vyx03xo6yoekmwobj94bH0cCadlLEnsio4JjzU9VR8zobDyUs4wph+NPG1LLPofJRbUkJU++tqPnyyX3feL66jN5qREp0Tm2fW3qX+fZZwAxTgZFMBobWHhGCZvgn4e8pKU2VGNPXTW3AXpyc+x3YEhhtkru9TMd+93fPsAV4WmKi6FnIHviVJFajJCxCj8KoBJy/lzTMVu5vjGrtsc8X0IuCv49mr3tiNsUK/WuX9ELp7Zoi4AtNeh2/IrKWiC9thV2dA8Jvdif+jdD/o/24qpmwgaPFAzsYvYOztZOI0tbRZgx5YWcJs27rJ0lSasyj3BHBGp5O6CMxXboUcR7KUxEwHQj4/0YPOPybPjDbf603n5Q2pxkJP0WoRpWSB6vJWd4WWcBuIivbYY3ID6f/2/G/Kuw2BewcWpzFN8nTDmCZc5dh7b+S1T08X6BIW7Xq8beJyx8HxAJ6AzRFYP+qZOSnldJZgQaSH4n9P35fpxhyyaK0buBpOXEhwGsblSqPqBGdwZweDqAoBkzUrMTalp+V9CPPWHq9Oa0IPBm/2XEkLRcqIc6 k1PyXiMr sa7isoPp9a8iU77KmEyAiG4CwFANq2UuQC+Qv6otbymsQZnSwo/XaXJM7tnZxYBPln9VuTk26NLR/Avs+IFbM595DwfVlvv5+A+n2FGqBzAGx20Z6Sq2nPGWvMl5OaEbvCdc8DSWG+5HjLiP23xt9ZiCUynuN0HMlELn97QJ6bGR8d9OTEH2CW7/0Yh/AsZ4Nuj14YVdZzGR9SLo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 01:14:41PM -0800, Sidhartha Kumar wrote: > @@ -5599,9 +5603,9 @@ static vm_fault_t hugetlb_wp(struct mm_struct *mm, struct vm_area_struct *vma, > goto out_release_all; > } > > - copy_user_huge_page(new_page, old_page, address, vma, > + copy_user_huge_page(&new_folio->page, old_page, address, vma, > pages_per_huge_page(h)); We have a folio_copy(), but it feels to me like we need a folio_copy_user() so that we can use copy_user_page() on machines with virtual caches. > @@ -6176,6 +6186,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > spinlock_t *ptl; > int ret = -ENOMEM; > struct page *page; > + struct folio *folio = NULL; > int writable; > bool page_in_pagecache = false; > > @@ -6251,12 +6262,15 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm, > *pagep = NULL; > } > > + if (page) > + folio = page_folio(page); > + > /* > - * The memory barrier inside __SetPageUptodate makes sure that > + * The memory barrier inside __folio_mark_uptodate makes sure that > * preceding stores to the page contents become visible before > * the set_pte_at() write. > */ > - __SetPageUptodate(page); > + __folio_mark_uptodate(folio); I suggest that "page" can never be NULL or __SetPageUptodate() would have crashed.