From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DA1C46467 for ; Thu, 19 Jan 2023 20:53:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393806B0078; Thu, 19 Jan 2023 15:53:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 343746B007B; Thu, 19 Jan 2023 15:53:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E3D96B007D; Thu, 19 Jan 2023 15:53:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E35F6B0078 for ; Thu, 19 Jan 2023 15:53:15 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D3D641A0DE9 for ; Thu, 19 Jan 2023 20:53:14 +0000 (UTC) X-FDA: 80372748708.05.5C4E820 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id C096240016 for ; Thu, 19 Jan 2023 20:53:12 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YRrLh3ht; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674161592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kjxdWqV/Idea8P7wH81gWdM8bAD9a8dt6ZW4Hjmn574=; b=tCtvH0M2o7hk8Tg0C9PcLMOLkIq2LK5trFDoZF0d6q09i6v0QT0zCg9qlgTjt/yqirfVbt eqNPb6vBAxcWLlQmxOe/OvI7sd5IJ7BbhE8MKdMRR3PVUC2bgefbkI+vm3UfFXqycz9N1b x57ENcoFwWHv+tDuxKzAoV3d/17PDEE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YRrLh3ht; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674161592; a=rsa-sha256; cv=none; b=duaWpNdzul400br0bY6TLhqCZrzx8V0xGKrI3iisCjtC7UJuNsvLi3yZeAYSyTldOz+WCd ll88PEgv8P9UqEz8CZKjhEWxPV6CL1aLTGB+/Oy8jM0DFcnkZ5B4bkRnTMESu0IQrW1I7u ieAyPdKA3/sdt0Q6WWnvFJ+Pejg6PQM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674161592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kjxdWqV/Idea8P7wH81gWdM8bAD9a8dt6ZW4Hjmn574=; b=YRrLh3htFM9SeWUn78vvSHM4C4Z/uxCe7JFTUMp0kz5V4PlsHwaDvuNvtx7uazU+Y6QL4e T9f1bM2qXx8GNS2YOcDvVykovYv7WAArNs4nkR45+2FLLZ6YxIBLwZytPoXWiaE6ca3Ynf DIg1Jg5E4SBAkJWnOIzCmTbaO8ZpQyU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-655-P8cD7fpKPGyLDO2hEXNo9w-1; Thu, 19 Jan 2023 15:53:08 -0500 X-MC-Unique: P8cD7fpKPGyLDO2hEXNo9w-1 Received: by mail-qk1-f198.google.com with SMTP id ay34-20020a05620a17a200b00704bd9922c4so2065517qkb.12 for ; Thu, 19 Jan 2023 12:53:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kjxdWqV/Idea8P7wH81gWdM8bAD9a8dt6ZW4Hjmn574=; b=cfqx86FQ51TsTSEdzDKXdCNXvRkAfprTSWXaaVGpj7PpYvLdjRXknylSLx8u3gTX+0 1xQLfcJp3V+uoC6nANa3uZcfYocYb2vb+l6XGBDcS5QY/6BhGauEwfylBGJ/eABw4JOO NDHwQgj4r7ydDCuZMWCAGH51Rrjuczu9Tgb/dIoyq0D9q1HfXpqnrW5xSYHbv0viSEH7 GcY2gBd0v6sNIs9KlITZmS4hTAgt20QOi272x30+RxY3obomzsNVWL+D/wBmDOWDoA7a /esi6+L5aBoBy3OaAJYJzeIYCSzLWrMFSD2kxpBTAotIdpEMmkzJt1JMQYqxsBEHcFZK xGGg== X-Gm-Message-State: AFqh2kqz7RZzaM1bZJTXHuNV2jecBUkVOgzo9HaYhy84x1t40VpCPYWJ bI2AjIM5hfeXY2wuqAO5D/eFJmqquX8OnaA16DGCVXf2N71bqsLOgLZQ8LqrqnMYcKG0BpGfJC8 c+D/+0LYPpf4= X-Received: by 2002:a05:622a:5917:b0:3b6:2c11:ec76 with SMTP id ga23-20020a05622a591700b003b62c11ec76mr18226313qtb.52.1674161588192; Thu, 19 Jan 2023 12:53:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXuhND0Ov4HZvejCKXnwpfvcg2Vk+ZKPZ459Y2BvlHrv5I5mpCgtXHBMZ0hx0of0XCQS91rOzw== X-Received: by 2002:a05:622a:5917:b0:3b6:2c11:ec76 with SMTP id ga23-20020a05622a591700b003b62c11ec76mr18226280qtb.52.1674161587964; Thu, 19 Jan 2023 12:53:07 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id j20-20020a05620a289400b006fed58fc1a3sm24886955qkp.119.2023.01.19.12.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 12:53:07 -0800 (PST) Date: Thu, 19 Jan 2023 15:53:05 -0500 From: Peter Xu To: James Houghton Cc: Mike Kravetz , David Hildenbrand , Muchun Song , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 21/46] hugetlb: use struct hugetlb_pte for walk_hugetlb_range Message-ID: References: <06423461-c543-56fe-cc63-cabda6871104@redhat.com> <6548b3b3-30c9-8f64-7d28-8a434e0a0b80@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 79uk11fp6ety39xtngqq9816nzmu9dkq X-Rspamd-Queue-Id: C096240016 X-HE-Tag: 1674161592-585966 X-HE-Meta: U2FsdGVkX1+TREk0IoeNF9dLOhoXsmZ6TJUymYbr1pk4vzhcfwnVx4H4jaztkxx50eYcgGVs56eh0YeD0NNTHhRtLCP6fmmRZQn24OCy09hr7HNy9EZhG6uUBx++YN/XjmGzkRLCj389/kpR4+6OmcjbflQf/8wKrRYiZqwwinwDTOMQE7jReFyQgD8khVnOgoorlVJDylfD0DpB+hmNtsPbpF2IG8jNRXV8mIfDlHLCMsY+DZAOD4jEto7/ofAdnFFvmRfKALDHfL8IqbN+7vYIjKRKimIma/gdQ5Bigu7zeWusTFfE/ylg8/OdD+ltWPOSG7Lkif0kSaLQ1qGhsqYidZeFiOE953rgZwlgQk4Y6sPfvX28W252yDNV5PtsN31HjTNa8Q+XzLXT81mfDOre97CfneVXs/MtCl/wp/0vpxeArSBGqd1zOTgxlcZocDjgbfjHhyN9fbUczjsSXyJ7OfezumvoTgx8kSD8CVzUVXrbo4yHdolnvzREO+baIHlet5pCKsiJqS2zdH3dfdb02313rQRhdpXQ7gqwreTBK7NO9u+G7Cmb3AxquVXETlcFC/1xEivmSxeHSmWvDR68f+pV924IMs3heICGSa/fuuimakj0NWEaJDlC4vZfHoENCun603iiTfSyO8PWrytkjHEVjz5y3n3tp/PgYAI9zyYBIccHCA+B25AKLrS6cVxE8Lqt61XbEbnB29cntHmC8AV1Ctk/L3aKIfCuDqNwiUHEK62jjpRc9scgst0D8Adhr5Fk2HzyA2e2mKrkBK52Xp0DkgcPCING8Dks6wPnM/kRggk8lxxQTpHZfVV3ZnXvz2/qdoJk0CGaLmE9/V0R9ClUrj8boJ2X5I8sqD3hjVb7S5FTrf07um71bLjIgyh6GgO71asVzLvKeJ9UUpNwfe2StJBtw+O/TiAabBBCNTAh5V0XGZeopw6qRCAr8bqV3ottJqeW+hHGUa8 MlolZ5CN uZ9V368J6ItnEs2YrgGVHEOk9fOhRpdBpV7dNqVfZxbNQgPltW8qNcS6pn335qbVniyLwOmdwfo7+PbsGzf6wsor95sli6DHHXIYt5KxqonvpaNtN9gIFP8Rwa7qAaWXsWAiYXltOxkFxNZP0xVesHE4eiRug0IO/Z5sEJ9Qu8KbkuCy7g5KfvUhSA9eu15mDZxrPK6QaOzSjQXEIqIulQ3j39cF5qI5NSmClVUKH39WJfyOvpKImbnPhNRQ4DE1C++L86OiYeoztBi99oZLNa9hJPvcoqOyoklGxtZ0KOtTSW8VdW/y5GlUP1nhXAZ2F2wV40yQrQwH1IyI+bq5N7hszKiPcoTRYv6IHIWQpL9Eb0UPk0ZVEnLLqUg4MhenBdDdPp5qJdDNkTECbxs9BUWtBwQucE85t3ENvM09VzeExp9A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 11:42:26AM -0800, James Houghton wrote: > - We avoid problems related to compound PTEs (the problem being: two > threads racing to populate a contiguous and non-contiguous PTE that > take up the same space could lead to user-detectable incorrect > behavior. This isn't hard to fix; it will be when I send the arm64 > patches up.) Could you elaborate this one a bit more? > This might seem kind of contrived, but let's say you have a VM with 1T > of memory, and you find 100 memory errors all in different 1G pages > over the life of this VM (years, potentially). Having 10% of your > memory be 4K-mapped is definitely worse than having 10% be 2M-mapped > (lost performance and increased memory overhead). There might be other > cases in the future where being able to have intermediate mapping > sizes could be helpful. This is not the norm, or is it? How the possibility of bad pages can distribute over hosts over years? This can definitely affect how we should target the intermediate level mappings. Thanks, -- Peter Xu