From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01675C004D4 for ; Thu, 19 Jan 2023 18:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 971516B007D; Thu, 19 Jan 2023 13:49:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9207F6B0080; Thu, 19 Jan 2023 13:49:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E8F96B0081; Thu, 19 Jan 2023 13:49:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C2746B007D for ; Thu, 19 Jan 2023 13:49:53 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3027FC024D for ; Thu, 19 Jan 2023 18:49:53 +0000 (UTC) X-FDA: 80372437866.29.CD8ED2F Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf05.hostedemail.com (Postfix) with ESMTP id 58508100005 for ; Thu, 19 Jan 2023 18:49:51 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="P/xgQXJ9"; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674154191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CK7XM6jvFICTrQyRSkakyoHIdmPO+rwoHhCrSJWnmdk=; b=wvKhjmEekjvZYlHqf9+XYcyw7NEOuXVYhvP7yXgLzBQk9Go8qkDk95xZ5YNpwK418PCgg5 Q38Hv/B4dKFKOLLNxxLGOp4El4vj2UghcYkiz2RdKCPMkbYGg7zIuCLwhFI2OeyxNFEQh0 cRX/qKmrwwQw7klEXW1YiK/U2dtN9IA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="P/xgQXJ9"; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674154191; a=rsa-sha256; cv=none; b=yrXx1Z+qNwV7RlSk4uCjJ2nTOuYyW19ifOcgoc0hlmHBuZzaA+a/SxY+dFitPMAQjtG/lh pl7t8diCo0nzwrVaSu42lvvt6J+EI0FcojyQJGPKOfgT4Cf+sCyZ4hX/etuCX967oc10MM 6ujCFyXwoyeSUab3ELlURxTbslEsZT0= Received: by mail-ej1-f51.google.com with SMTP id mg12so8127324ejc.5 for ; Thu, 19 Jan 2023 10:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=CK7XM6jvFICTrQyRSkakyoHIdmPO+rwoHhCrSJWnmdk=; b=P/xgQXJ9vz/RM5dJBqKs4VRCaGnhkdS9AGbF5+ZuBsFkGsB3Hv6008PPdoZlKZEyWN XPBHlzYxA8xXIkE74TdbsdNMSPcer5/BMtb3irPlZvPkC4JKFbAjA3/SLHSzaP4I/an0 58dYVBBaBTtv0zZ+ts7Ny+bK8S+vaac45f8r4WU5g2uLF9UOvR6HwVt6i3jQv3hiaPHB 0zhc4k2DgAIc0gXGLLoujNurNiyx3DD9GLTwsjXw64Pfq8JuZFkILPiTbFLmFj6CWnHH 1meIj7T4WI6KUD8HoEVQawrpKOS58SLu+luncqagMKr+VZP4G5VUd4K1qHXoGCxEBkJG 3dpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CK7XM6jvFICTrQyRSkakyoHIdmPO+rwoHhCrSJWnmdk=; b=WlNZ9Ubb/eNP9eeCFjTwXzgCjuKatfTMdcXyOiPFF3ezFMyagOBO3lgtLJRKhUPI6P zQOPww+VfxKYv5PSNUh8NOQWHlZvA+1rrEwTrnbgjZQcZhuvU1OQ2rNeM4hkUkJKMbEU +//sjFmlFQGRqAFtwnlVpRUZeoeLzro/k4nTsmDVhQ8HvMo4Odwz3szHtiLIqdGmLUvV 7GweS6wYBNqGAsvQGZZyrS/eE19C1sE/Ke+uXeORFEvSKbe7voQNuu+KnOHEU0IpERpS TGXVVvaUgHooAcJ8s5CD3Zh0j3mcOehcmxKyJkRa5gsobzuI+h6Luz0mUWkUp3QS1jHQ wWqg== X-Gm-Message-State: AFqh2kpQ9fD5vQD1hlgrgCfYkImnpxRKnW+plGUUI2cXOv4jbCdL4kmK 6PPf5f5Bc99fp298GX3AojM= X-Google-Smtp-Source: AMrXdXtuXYzm48ZWs5aSPTUEmWg5G4oA/y3JLrx4DM/R+UoeBfeS/vkLhVE6quSMQCEPUilrKlRSPQ== X-Received: by 2002:a17:907:9885:b0:870:7340:b770 with SMTP id ja5-20020a170907988500b008707340b770mr12718596ejc.54.1674154190110; Thu, 19 Jan 2023 10:49:50 -0800 (PST) Received: from pc636 (host-90-235-24-47.mobileonline.telia.com. [90.235.24.47]) by smtp.gmail.com with ESMTPSA id b3-20020a17090630c300b007c0f90a9cc5sm16725103ejb.105.2023.01.19.10.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 10:49:49 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 19 Jan 2023 19:49:47 +0100 To: Christoph Hellwig Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area Message-ID: References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119100226.789506-9-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: r5zfw8psquwdtqq887z7xakndj8kwu3n X-Rspamd-Queue-Id: 58508100005 X-HE-Tag: 1674154191-223518 X-HE-Meta: U2FsdGVkX18SFeAx6YH4iBCsGTbK17tMOfdYmJfzhp2+RGEbG4H1jaq3XNMklNmLePo3yg1eNojHQ2fw3BNXm/pkl3jtsCRCj21FCoK7V6KIP842MmmDeoJYJ/vn34+92Z5NoDvnzkjExnOZrtN/A4E8kLlXfg2Lcghi0W2kufH6rnVc+7abph3UBq3OyUXiZh5s2mO03rNPC1qCM3F6TCIKOuz5RljBmKMa1MmevuZpzf8Of4CWvHbpcbYCjDfjsdFLtdK2hTdBd6NPHDrshZBYUAaa0xrsmeMF6KmwChpsVvUuRHQSH/AY7ptJ0ALij4yE4FFugvl6TBHYp46Mf6fYiBC5BrFCKXqcNUkzzML5m3fVflsxXqpEgNrtO0IEjPzgJ1tSsnTBO8ezsKCWhcE29p4NnqZqPNiFdwIBKvyP1/A/lcvyLQqdjjK5AUf/R4cWNq9Wx5MS+Zm0NM03nYbsgJf5Wo6/1XwT5Y2MxEdwG9j+D8jMApkWfa6QKJIoQX/h0A0NFkA/5649OCXt2e7AfVrIyqz6MYEvWeP27bckDu9yaWvQwlgTFscQXfXEw9EAbjdcV43wWphmfrvP1dGCGvrGbA7/2xmx6uh3TE9XI9xvqbqSKEsjm57+g6PdNkjxEMlAHKtxQhW95bb6uOBw1XJS3Re/aMb08Jhr6TMtlum2YTq2E76S0nMFLJc6CM7xcmcD2uOnPaak8wM45g3AnJw8uFhAvPJ3LqM33KsLMbfg25w2zXgZEV472DwztRYYPX/RGNKYYFlYJA/08f2T6XNTyy3SvoxKeNTSocDuHN5mUgv/8FO+ALDH4W25gUAXdwrQE1QowCGyec8E3WESGA0fGSACjqlcyjLIv45hilZKxgBPIzsCj76dGYTvzFhirB8sw/N6VUWF8EWtJrGgayjswWUpXr2GouGxo3InrEzTEwloJ+0XlgFnraMyxu5pNPGVOrYL/1A8Lur 4RSAc9pS hf/xGN4oYSWSVgGLzVK7NTY7ZzwUE5yZL+WaO/4dIUQzluYUlit5eIfJIKiecAeniKH1YgJ1PBDkeBnbQ23GxzaROpv53K3V2QSe0z3hQ8fla6iajz/hF/HNTvzbwBDhSTyopqsV9QuoshqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 11:02:24AM +0100, Christoph Hellwig wrote: > All these checks apply to the free_vm_area interface as well, so move > them to the common routine. > > Signed-off-by: Christoph Hellwig > --- > mm/vmalloc.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 096633ba89965a..4cb189bdd51499 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2588,11 +2588,20 @@ struct vm_struct *remove_vm_area(const void *addr) > > might_sleep(); > > + if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n", > + addr)) > + return NULL; > + > va = find_unlink_vmap_area((unsigned long)addr); > if (!va || !va->vm) > return NULL; > vm = va->vm; > + > + debug_check_no_locks_freed(vm->addr, get_vm_area_size(vm)); > + debug_check_no_obj_freed(vm->addr, get_vm_area_size(vm)); > kasan_free_module_shadow(vm); > + kasan_poison_vmalloc(vm->addr, get_vm_area_size(vm)); > + > free_unmap_vmap_area(va); > return vm; > } > @@ -2664,10 +2673,6 @@ static void __vunmap(const void *addr, int deallocate_pages) > if (!addr) > return; > > - if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n", > - addr)) > - return; > - > area = remove_vm_area(addr); > if (unlikely(!area)) { > WARN(1, KERN_ERR "Trying to vfree() nonexistent vm area (%p)\n", > @@ -2675,11 +2680,6 @@ static void __vunmap(const void *addr, int deallocate_pages) > return; > } > > - debug_check_no_locks_freed(area->addr, get_vm_area_size(area)); > - debug_check_no_obj_freed(area->addr, get_vm_area_size(area)); > - > - kasan_poison_vmalloc(area->addr, get_vm_area_size(area)); > - > va_remove_mappings(area, deallocate_pages); > > if (deallocate_pages) { > -- > 2.39.0 > Looks good. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki