From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E818EC46467 for ; Thu, 19 Jan 2023 18:48:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EBDB6B007D; Thu, 19 Jan 2023 13:48:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79BF86B007E; Thu, 19 Jan 2023 13:48:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 663C26B0080; Thu, 19 Jan 2023 13:48:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 54C8B6B007D for ; Thu, 19 Jan 2023 13:48:30 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 31BFE403F3 for ; Thu, 19 Jan 2023 18:48:30 +0000 (UTC) X-FDA: 80372434380.11.C79761A Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf19.hostedemail.com (Postfix) with ESMTP id 732921A0007 for ; Thu, 19 Jan 2023 18:48:28 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mRVxGRab; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674154108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RU7fEV5xKfw0jsdvtYbc/UHqSchzCY97egdarJ51nF8=; b=tqDbA/sIWJeWwC/LXsXrLV+nTdnWoqlXNaHAlLwfKytaeuYCc1nwobrMqpzQ/9nY74flzL 3r7nfdAZ84YkHMkEhyEODjUk5S5EnKxIrJvSE5QltVPc1ytVFyRJsVEu1xQ1X7pekvfllU bNYWXqQI+BoUChvYLgINGay4bn0f6GI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mRVxGRab; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674154108; a=rsa-sha256; cv=none; b=6vcmAlUufNw0Jv+ibJfD8nOF9G8yLHKUl7eP2TnjsEAOfp7TzSnQ1zyts8MKO1Z+IMmD8j SXsA5BPRHjaO1raxURrOQP8PtJVn/l36XK9NXwoF7e7XDBVVIor+rqNcxsnG+K/1KwkmPa eSZiBk1VbDIMGFiiZ35V1cz/OkThXqs= Received: by mail-ed1-f54.google.com with SMTP id v5so4059185edc.3 for ; Thu, 19 Jan 2023 10:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=RU7fEV5xKfw0jsdvtYbc/UHqSchzCY97egdarJ51nF8=; b=mRVxGRabmTxGKcyLzkMOqAXif6OCavGboSwD5uzhPUXfhPYMVLwC/8w8Ot7hSU1J23 qvKZ7G5XuWzbVM1s4qNeuLVeGvMdKGTiOzhBapaPGgzhdlvNf2Ni8e1NWYs+Gcjr4IAX +9uNKasrrG+BzuykTxOQgC5XVgDcQimvWSEOHWPkrJ/wwlWEqRR9vsO25O8Crx4P3ohe pVrzCnPQ0eTC3qwGkew97nnzd4dPP40paP/C1114z82YJr/RfddwBqXC7O8RhhWIGl2P XqIq+Pzp9bVlG7Vycoxw72iVrhuQZswaeBO8WB2JN/1KOgtOhQ1fHH9XqsYcIkh/MAXE c4tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RU7fEV5xKfw0jsdvtYbc/UHqSchzCY97egdarJ51nF8=; b=OaQqrPjKQeDCh8z5nL7Te4nYZtxdF/41DY71yMARco8cwc3bR4yJpyKGw2rR9zItzR CHBiqWpNV8S8Nc3EIfWRvl2L/yCSzgYc7S9cILNnzrjYu9cLq2QhLz8xGW5ySMxfpBqz V/1kHCJxLwqcBpVoX06gv+zYLnE6EmtI/W2d6Z8GJSEZUMOp7JEwfx+6fWhMddHR9Fhi BhN3riLWeHJiBEWlJLZ8oOCypBEPh/IIXoweSn3isc+c5z/n+gZ2WkTPJhidOz3GYz6q N9WvpM6OyfT83eMH6E5XDQVvZRO8BG3QdtbzWnX5YhhTN+0o2koVxFppfZZ7nrmvYWHA YRgQ== X-Gm-Message-State: AFqh2ko08MMPG7j7wHeTWJxf/WTQkiwCzaqO/T4jeN55VUFui8k6INEp udNs6meZ2b6W/6sgWvvtEm+AYwGOvPU= X-Google-Smtp-Source: AMrXdXtuPfTxALyUtNq1oq/7+3bHfgx/AeED5lIHKiTUMYyzjIo80vuclFjyWemqbGeV1vLLWhoWKg== X-Received: by 2002:a05:6402:1394:b0:49e:a107:268e with SMTP id b20-20020a056402139400b0049ea107268emr624485edv.3.1674154107181; Thu, 19 Jan 2023 10:48:27 -0800 (PST) Received: from pc636 (host-90-235-24-47.mobileonline.telia.com. [90.235.24.47]) by smtp.gmail.com with ESMTPSA id p3-20020a056402500300b00488abbbadb3sm16082662eda.63.2023.01.19.10.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 10:48:26 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 19 Jan 2023 19:48:24 +0100 To: Christoph Hellwig Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 05/10] mm: call vfree instead of __vunmap from delayed_vfree_work Message-ID: References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119100226.789506-6-hch@lst.de> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 732921A0007 X-Rspam-User: X-Stat-Signature: fomiw5a581nnxtogehc3b9dh5mewtoqx X-HE-Tag: 1674154108-926407 X-HE-Meta: U2FsdGVkX1+Gh0LDIfUpBaGqqtoN1kJkpPQsucymXYEAVImnSJoFcT8QGRXaEdD5e9fac93FUPCLMf+YOcd6tw7+LY8kNfyriG66IgmL13avRnqXuUXwYYMRm5MdAlhjzVl+UgIfTBYuAKoJZp64NwXuxQ+I4BUq0EwIGQSL+lkdXxxsfjpaBff71jzIPFfrjxC8p6Q0TH1lwVP+ZADl7ikqd+8rNr2isuyGB5R7FIHm/qP3d0dFBwZ1+263HCBOTjCiWh6Dnw+mAYqcS28nTwJJjW6ZkIipbmw+6X5L47EFWFx3GKkFdvDf+i6WQQ+P05DriweZyOjQLIJwBTDUBs5MC1U9Jb0XXnvaAnPG/tOLXKk5wbrlHxigjNvY23BEvkjzMizdnZKsOgWrZs/dljNTLt+APzaqlKgnzf5p2VuWtYYpCtrfjMOsyLgCsoHB3fw4kWiDjuiLiuokjrZZhr9Bej67qFsa2D9N1mYztv6QqYpwTTl2cG1IDI42ODRYxNwDkHnCX0nmPHcYCNHIGbrs7Hm++EtY7pXpLG2KUaTKKRIiTy1/l8v2Ha1FK3MF9qCKFRb+KX/5NELefVL9Wpvk9MC2l0TNMcVGjk+gvWEyKm5u47rFpcOkinK8G/vq/xHvXqLjapx+Ax/RTn9DRZayGWBXvCTtHgQbOISZvkgqRKVs8HmcvSRYwRWvAEjF/ftfesErB14qaifigelnfrNO5WvdzITIRce+Y3x/gtO41I5HWGB0Gc99Zzy3/DrKq0FCCL1+GWFzWg7UT8HZprZ+y7R7QZ6dhC9LwlH25XpDBTtRl6YKKTqjM6yIvLaa2OtlXZ92VsK89MCemD5NqTbuB8sdRBiedJfBRpbqwm1Q+Y+F3KM9vpApSCiL2fiMUeXYB8gJhRW5W72R8iwVdHvDrShMOiEiEGaQOsipS3xPm2ZoQAtBIAs0KJt9SMori/up619yH1hDa7G34TO L/gzTygV xS5WUZFUgmFrVl3RKcqBHuFtRSPwKF2NTYwCDmIhpEFcnvgeQjvuBvCRaTv3qFDpUWPoZAYZs5BKKX9zgNvJqHb2goWwTrOviv2qP1FYEZPQj4OzIc9i+8M2ULoCxYFaujkO1HH+/xUVtuDg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 11:02:21AM +0100, Christoph Hellwig wrote: > This adds an extra, never taken, in_interrupt() branch, but will allow > to cut down the maze of vfree helpers. > > Reviewed-by: Christoph Hellwig > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index daeb28b54663d5..3c07520b8b821b 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2722,7 +2722,7 @@ static void delayed_vfree_work(struct work_struct *w) > struct llist_node *t, *llnode; > > llist_for_each_safe(llnode, t, llist_del_all(&p->list)) > - __vunmap((void *)llnode, 1); > + vfree(llnode); > } > > /** > -- > 2.39.0 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki