From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B20FC46467 for ; Thu, 19 Jan 2023 18:48:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF1266B007D; Thu, 19 Jan 2023 13:48:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA1206B007E; Thu, 19 Jan 2023 13:48:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41F66B0080; Thu, 19 Jan 2023 13:48:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C14186B007D for ; Thu, 19 Jan 2023 13:48:06 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9D6321404C4 for ; Thu, 19 Jan 2023 18:48:06 +0000 (UTC) X-FDA: 80372433372.17.1B4A6C1 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf22.hostedemail.com (Postfix) with ESMTP id CD608C0017 for ; Thu, 19 Jan 2023 18:48:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ow0+j63o; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674154084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFxYhydt8sYGwKI6n4r82i6ur+JoxFHfftL3nvSFEHE=; b=riGUuxVkHOmqt9gf/T709/PfakhBK/LVsqVyoo1o9hbMFXOST60Nf0zQ8TwDcZ8g2hbSet EvgUToJu9eIvQ4dAmMETyFOd/gEetwEVKv90qmyrM6rhM8KKmKN+8FfaY59v63/p29juml UNpNsfqcWzcgZHg0BnwAoXGvD9C2xiY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ow0+j63o; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674154084; a=rsa-sha256; cv=none; b=Xb0OgJsXP3W0grXjBYT2uYwjCTi7cXBiKnqVSoq12VKJM/Hk+pfS9sFusd16tO/KxhyOS9 tylBj9I0Wh3GVTOnWE4uuZ/2sqjCPb5A6dTJevSClRxtj/FDx5d6MGorcmBPMVZ/unrEfw gBOb4HKOE59mHExeAIYBVmgTV5ebHG4= Received: by mail-ej1-f49.google.com with SMTP id u19so8070187ejm.8 for ; Thu, 19 Jan 2023 10:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=NFxYhydt8sYGwKI6n4r82i6ur+JoxFHfftL3nvSFEHE=; b=Ow0+j63orPqZ6KBs3IJxt0uULHbByrF3Qhl+sJDLYC8N5zs/W40kIZVuzwVexbj+EA F3kI/jS0MfzfcWERUX46E5ZnIShDzStQ1MA+1y0hpdrf4KITPqiqtovm/iMA8spFza3K naB+Ou+gR0P+STTMchodXkOMzG9oP9odt7aqjg8uDju33yEQqC5z7skHGa+iAB4QqB22 YTZhD9XfDLY4eCNFPVqk14FgFoINxQxCHRXx1a51H9fdHXs3X11+WfydZmKERbhr/91J 6BukcPTHMFBOp80C9QVFKpofl1lY/vJfTQj6RlfMl1Hqvlv0Myzgdr/idxt3DQ6FLEsT U2DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NFxYhydt8sYGwKI6n4r82i6ur+JoxFHfftL3nvSFEHE=; b=F6U9hg/JJ9d17nOU5WITPRo6NoDNx1KUJbCTPnwpprVB6dSqojJwE1mWHMFoDRQ0MZ sViEv91MZbyogh2FoKUna1e7xLeP3xN/ZyesTCqMAaKsgW181pB/XurfRhRjXQSbLJ3/ ZjBgIm7tTIjJ7GZNO03NdkXUSc4jqnDJ09//7R5ZQ38DCzUJGqDuiesShpoJPLLIEy3d V62QShFJMG3p7ejELBrZduGWSGi4gzibgDprNNQ5vtu9a6m4B7yilPvFLdkKVPBdNBKB 2W1tZIXBwCqhjXKXNScwafzTwME8/R7G6JkQtmr+hmvh3KSBupJ3p33WiAcypO49JTJi ghOg== X-Gm-Message-State: AFqh2krkvBmEjiNkWrT/j4Xf+rmR/7ouqjl/nXbTVPOI50ihy0OQeMFz /t7mcI+6kIpoA+9cXEk/CU0= X-Google-Smtp-Source: AMrXdXsz9Wpii8tr/ZxJrsT1kVaXdQt3kw+8mcD8bkAPi6zx1Nes61f9j7u96dYDoAcbovxJC8vqhA== X-Received: by 2002:a17:907:c243:b0:872:84dd:8903 with SMTP id tj3-20020a170907c24300b0087284dd8903mr9673415ejc.59.1674154083624; Thu, 19 Jan 2023 10:48:03 -0800 (PST) Received: from pc636 (host-90-235-24-47.mobileonline.telia.com. [90.235.24.47]) by smtp.gmail.com with ESMTPSA id ui18-20020a170907c91200b00872c3e8d4e0sm4439707ejc.13.2023.01.19.10.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 10:48:03 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 19 Jan 2023 19:48:01 +0100 To: Christoph Hellwig Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org Subject: Re: [PATCH 04/10] mm: move vmalloc_init and free_work down in vmalloc.c Message-ID: References: <20230119100226.789506-1-hch@lst.de> <20230119100226.789506-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119100226.789506-5-hch@lst.de> X-Stat-Signature: tkjgzwm3r13jppojckrsf8zn1ghginiu X-Rspam-User: X-Rspamd-Queue-Id: CD608C0017 X-Rspamd-Server: rspam06 X-HE-Tag: 1674154084-454150 X-HE-Meta: U2FsdGVkX19mnCcbJlOojbMzetK7WZkeLVzXx707Xq0GiUoE5XH5zAoi+SLV5uw++vyqK+6jIJdWPWclt3NQgZgIic2Y9xKyjAH5+pOYn+vQQIe1YgYBKyLke4CjjiHL6N4ppp3DGZ4go5nvz51Fy7ACcp2FDFIkJOooL4MVCE1khGA5sCNexftufRTI9hSrNx7MG2o0bCq3IJ9GtPZj8Rj4SxVv+NjJzqT5SDw1uvq5cRFP9imMwBWTHmMJW+eVfENusL4Wj/huk8ndQF4E7dK3XC6rae13ChBQasz4V527a3p/vbwx/JkMEYchS1YBmvA8AQ4IXs5pQx5xtYS6xfZLNspz+hZDKs9xKuX9Bvv/rHNBPRDPdj0cVdugrrVVWoHQus7yzrwMSpH8NdR26gs/n9/QENbRnHMUGyC1e7FA4I4Z0Fq71EsYbCb/ee33WYpOVsxYdQ3opXA+ZohDrYT6W3u4dG3a/O37C9u/N3OAFHLt/NVDNs5plR6LhVl/GXWqS763EwcqtBB50u5f7jQBBY/qrcWLbG8Bqdl2rMp9EFKlt57MYVdgzAilE6mMkrT+YcVnyw3k6LaJjC93DklV6K3KXwFDc+oBuSOXntV1X9VlcnEXagXlGy+hKOGfH8lYM4+BnNHiD+KNAVeTBDTbuETXtPa6jf8KrG+xeKDabfkQoczQUFpeKmL+0r5iYfzZ1rNr8TFEbyb07V1ObofYV2G4IOooezPDbOotREQALIUKBUtUjrxQk3wvrmxuZ1WpEUVOPpORqfYXhGA7KyMc5GoqPi9woYVZzyoxdDv1ntrilUJTNEKoG6WAoVGqjiIOzKMb2EgpuXhJdEArfVVn3lEuFUPTGgnuvv/oQqlf5rlt9Oxg51tMZySbB0IyinZUzVDCkdGuazt+nyPoH3i2FLCLl6CqBjGx6dfarfkYGBSNHlaoL4g15tYavE4WlWpo6tc5vbMU3jXKQw4 G9Iw3d6P 2P0Hq317/ULQS7f7yfd7gUOegsYYW9P6YE/NZH8Bvf4WYHjUrbNgodxw/jjL2HMkTILiwdaHiMZPv8wlYnlgf6OidDlheAFzrpJnVJkJqMFQKzng3lmD+soJciNDCJAxatWVaYeldX/WhIKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 11:02:20AM +0100, Christoph Hellwig wrote: > Move these two functions around a bit to avoid forward declarations. > > Signed-off-by: Christoph Hellwig > --- > mm/vmalloc.c | 105 +++++++++++++++++++++++++-------------------------- > 1 file changed, 52 insertions(+), 53 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index fafb6227f4428f..daeb28b54663d5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -89,17 +89,6 @@ struct vfree_deferred { > }; > static DEFINE_PER_CPU(struct vfree_deferred, vfree_deferred); > > -static void __vunmap(const void *, int); > - > -static void free_work(struct work_struct *w) > -{ > - struct vfree_deferred *p = container_of(w, struct vfree_deferred, wq); > - struct llist_node *t, *llnode; > - > - llist_for_each_safe(llnode, t, llist_del_all(&p->list)) > - __vunmap((void *)llnode, 1); > -} > - > /*** Page table manipulation functions ***/ > static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > phys_addr_t phys_addr, pgprot_t prot, > @@ -2449,48 +2438,6 @@ static void vmap_init_free_space(void) > } > } > > -void __init vmalloc_init(void) > -{ > - struct vmap_area *va; > - struct vm_struct *tmp; > - int i; > - > - /* > - * Create the cache for vmap_area objects. > - */ > - vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); > - > - for_each_possible_cpu(i) { > - struct vmap_block_queue *vbq; > - struct vfree_deferred *p; > - > - vbq = &per_cpu(vmap_block_queue, i); > - spin_lock_init(&vbq->lock); > - INIT_LIST_HEAD(&vbq->free); > - p = &per_cpu(vfree_deferred, i); > - init_llist_head(&p->list); > - INIT_WORK(&p->wq, free_work); > - } > - > - /* Import existing vmlist entries. */ > - for (tmp = vmlist; tmp; tmp = tmp->next) { > - va = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > - if (WARN_ON_ONCE(!va)) > - continue; > - > - va->va_start = (unsigned long)tmp->addr; > - va->va_end = va->va_start + tmp->size; > - va->vm = tmp; > - insert_vmap_area(va, &vmap_area_root, &vmap_area_list); > - } > - > - /* > - * Now we can initialize a free vmap space. > - */ > - vmap_init_free_space(); > - vmap_initialized = true; > -} > - > static inline void setup_vmalloc_vm_locked(struct vm_struct *vm, > struct vmap_area *va, unsigned long flags, const void *caller) > { > @@ -2769,6 +2716,15 @@ static void __vunmap(const void *addr, int deallocate_pages) > kfree(area); > } > > +static void delayed_vfree_work(struct work_struct *w) > +{ > + struct vfree_deferred *p = container_of(w, struct vfree_deferred, wq); > + struct llist_node *t, *llnode; > + > + llist_for_each_safe(llnode, t, llist_del_all(&p->list)) > + __vunmap((void *)llnode, 1); > +} > + > /** > * vfree_atomic - release memory allocated by vmalloc() > * @addr: memory base address > @@ -4315,3 +4271,46 @@ static int __init proc_vmalloc_init(void) > module_init(proc_vmalloc_init); > > #endif > + > +void __init vmalloc_init(void) > +{ > + struct vmap_area *va; > + struct vm_struct *tmp; > + int i; > + > + /* > + * Create the cache for vmap_area objects. > + */ > + vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); > + > + for_each_possible_cpu(i) { > + struct vmap_block_queue *vbq; > + struct vfree_deferred *p; > + > + vbq = &per_cpu(vmap_block_queue, i); > + spin_lock_init(&vbq->lock); > + INIT_LIST_HEAD(&vbq->free); > + p = &per_cpu(vfree_deferred, i); > + init_llist_head(&p->list); > + INIT_WORK(&p->wq, delayed_vfree_work); > + } > + > + /* Import existing vmlist entries. */ > + for (tmp = vmlist; tmp; tmp = tmp->next) { > + va = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > + if (WARN_ON_ONCE(!va)) > + continue; > + > + va->va_start = (unsigned long)tmp->addr; > + va->va_end = va->va_start + tmp->size; > + va->vm = tmp; > + insert_vmap_area(va, &vmap_area_root, &vmap_area_list); > + } > + > + /* > + * Now we can initialize a free vmap space. > + */ > + vmap_init_free_space(); > + vmap_initialized = true; > +} > + > -- > 2.39.0 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki