From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE17FC00A5A for ; Thu, 19 Jan 2023 09:31:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BBE86B0072; Thu, 19 Jan 2023 04:31:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16BCD6B0073; Thu, 19 Jan 2023 04:31:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 015BD6B0074; Thu, 19 Jan 2023 04:31:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E1DAF6B0072 for ; Thu, 19 Jan 2023 04:31:14 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AD377140301 for ; Thu, 19 Jan 2023 09:31:14 +0000 (UTC) X-FDA: 80371030068.11.868F6B3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id DA5DCC0005 for ; Thu, 19 Jan 2023 09:31:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tNshMnGx; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674120673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FBT6wzhK2UunnASnPSdx/iqihHXc3wFh1VVgMsb6VKA=; b=nIDOS3I+sAP05UjMtZJo0Gn3ZIEE5CS3apmvHJjE0cSSkKfvyW1SI6/IJ6rb+PGQBOr6ly krSJbW2PbFm4kHu7ARoT9Ci9haFeOE9zp1MpihJRfdleexA7QEdLs17f0vDnwbExyDlWf6 rRdbH54mpF352d7IfiCbVJHEE1iD4Cc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tNshMnGx; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674120673; a=rsa-sha256; cv=none; b=nxjyXwGfy0ooi/Q38haChZQ75TAxw275Hr0Ra4y8+HyNagMFhr2tFzImwqjhH13WN7zhlm eFmtJBZOn8fvcW3X8LbvaK3HCQMFtrQpH3r8d+ZiGQ0jcPZ6N5eSLwu91B1YP0YDgfgocn CFqv7waw/rCDpCwbdv174N8L/IEjtTM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 529F637BC3; Thu, 19 Jan 2023 09:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674120671; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FBT6wzhK2UunnASnPSdx/iqihHXc3wFh1VVgMsb6VKA=; b=tNshMnGxdSbA+I2e0XZ7irNDU1P9ofyO06zaZeOGrIRUrTbu32JIjVEkX2015Uqk8LTtr3 4taFAjtwB8ddwicGYKdsvkCHowFdQKOrHjraZNi/52dFMBTwO9hEtyBFtFxDlEnRjQ/zsL d5ne5VEjHi2FDliNndYnS/tZzKOO1N0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F421134F5; Thu, 19 Jan 2023 09:31:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5vcgB98NyWMVfQAAMHmgww (envelope-from ); Thu, 19 Jan 2023 09:31:11 +0000 Date: Thu, 19 Jan 2023 10:31:10 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 17/41] mm/mmap: move VMA locking before anon_vma_lock_write call Message-ID: References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-18-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DA5DCC0005 X-Stat-Signature: bkji79yt61sfmyu4rh8k3z7ig551n3et X-HE-Tag: 1674120672-894717 X-HE-Meta: U2FsdGVkX1/OkYuxEoFJyMO43V3Ou1UOgG08QI/Bqd1rXA1hphURCodUPK8LyiYiRCcQNyJLVo59oNpSrTAKuucViC9l6JUnqsWkuo9n0FXaxLr6ImwL/FiDw1Kv1E1lMvLeuVhRbTH16fLSSX1EnMy/OO+XMlVvSGkXEuCY4B+0xzJgfNDjwSe/VJY6I9YLOmqoGOOMfzpn2M8WI+5XxiyjJ1Stfzdl272DUaAWv9bVSU0RZdpYaRVSV1OUfvqh4f/7n4Q5ah6ixzLhY8jCqYD3I6PXyraaYA+LDfN38YmlOsk36/F7AvhrfKe8ofpJuJU5A9MrExhYNzBLHmtt/6j7EKA3qqFCt+/f1CyutfyTv4BursFhEY6UqzxzoJEjrcJucIERoCP4x9f0Y6AFFIGCB3uMKKFwgnn/rYW7s/iJwXLcrNn+B/MwfxnWZHB8s2lFJDT0IAWGbiqlIaCOZZcJiqKDBs+7FBrADvBvXMo+4NtM03b9ZQ4aXa2XUmX7u0jkyUsZ9Y3UakO5dmgv7JVq5NFOj+yziJUPQ3NX5DvmwIH6KNkush47qe90yY+I1NkxWeSVqFOXuyPnurdvWuJh8wt3NSdlxTi6C62Yc2zgmjBh0BckLGmIhSmDXtUKBaLzbFHFeYU2AX9qPfXYFqJ+vI6a4EcC6nKZVV6t/WfZd5klk/FvOiIjPZq8R4zJ8ZCoV3HXOXpL7qhX0j28gRO4fIqqZmrUGMJh2KngvtTns1czgN0kj+hhC1/lDX/b9f6LOwaupLTpLfHZQ4JAijbzSsawKCveF7oEgocYvUNdCRWCD66kiD+ESqBgKFzZixbzyHHn7NtKLxqjMz9iUUffi/a3NyTgLOqqIOZA3VJtwfYm3G3Ja24lsytME3zFJnQexKhDQ9Gl4FO/43s/BIdl0XomfTe/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 18-01-23 13:48:13, Suren Baghdasaryan wrote: > On Wed, Jan 18, 2023 at 1:33 PM Michal Hocko wrote: [...] > > So it will become: > > Move VMA flag modification (which now implies VMA locking) before > > vma_adjust_trans_huge() to ensure the modifications are done after VMA > > has been locked. Because vma_adjust_trans_huge() modifies the VMA and such > > modifications should be done under VMA write-lock protection. > > > > which is effectivelly saying > > vma_adjust_trans_huge() modifies the VMA and such modifications should > > be done under VMA write-lock protection so move VMA flag modifications > > before so all of them are covered by the same write protection. > > > > right? > > Yes, and the wording in the latter version is simpler to understand > IMO, so I would like to adopt it. Do you agree? of course. -- Michal Hocko SUSE Labs