From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D664C00A5A for ; Thu, 19 Jan 2023 08:43:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 933A56B0078; Thu, 19 Jan 2023 03:43:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E39D6B007D; Thu, 19 Jan 2023 03:43:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DD3D6B0078; Thu, 19 Jan 2023 03:43:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6FBB76B0078 for ; Thu, 19 Jan 2023 03:43:03 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 390DD1C648C for ; Thu, 19 Jan 2023 08:43:03 +0000 (UTC) X-FDA: 80370908646.06.5D13260 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id 79B874000B for ; Thu, 19 Jan 2023 08:43:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VOuixRcR; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674117781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mgXQx195ZtCDVgT0NrBudH1jFKlFaWeKo5gcJhg3Taw=; b=Ccq93TVONdWNdwOZtzNg+4PQzhoJRTfxC/i6ReRi2eauD3QRvTH2qBbjmsA+iwI7lR3iwP 0bFpvT7o2/TJCmzX4olGX2RddGXxKHmmy510OdZKj6R53+CZVEfE5I7BNXzAVovWmmiunH JE71VekyIa8knMySV33iJ6mgYVCXaZ0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VOuixRcR; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674117781; a=rsa-sha256; cv=none; b=8mz6c9tn2hRumGwA+2FyFayjjbhikREQhOclImwm9OGCeLS9CAp89P1hy07LMp1qzv5PLA curY8a+T16EELLOXcLK8ynBwzxo0j/CERjz6aRzOp0syJX5Xf/FSeoNeYmpiSm7sfj6dEq uJs49R9nFuedYGD/k3zt0wkYFT/8240= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D49B4B82139; Thu, 19 Jan 2023 08:42:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16584C433EF; Thu, 19 Jan 2023 08:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674117778; bh=LI6M/IodIDraG4vo0tg2WqsUpGHdn0SKKJzyG9vr+tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VOuixRcRgj/7x446d+Ap8L7MWaHxeIl0r71eppXqqUevWV8MuS9Rw0+bF0RX5+Qlx h57Wfn5V3LeXtpdhrJCWJCDYWjJJgghC7Rr5MKg60Lx/2mQRi0bpkBhuPkReUDOunw 2ve8jGS6OjKFanEUZ+yPzmdeVzKStoF6J4AVrn0y3nVzQvNpeG0p9wSxZTjneczSMa 6I4IByf3wUv0DPoo+GtGHMLSDq+xR1yhlTmmLxRnLv4Xp8595wcxneK+w7S7OuUeKs fZQpZrVs2tqaw8o2KVougEhYtEWmTDD2Z/AWKdSTN1tMYec0cZdt9eEH+tA/WEYdef MSVlshASIw6ew== Date: Thu, 19 Jan 2023 10:42:45 +0200 From: Mike Rapoport To: Pasha Tatashin Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, david@redhat.com, quic_charante@quicinc.com, lizhe.67@bytedance.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm/page_ext: init page_ext early if there are no deferred struct pages Message-ID: References: <20230118155251.2522985-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118155251.2522985-1-pasha.tatashin@soleen.com> X-Stat-Signature: kw39uz8ps9qgisyf6j1bmjanwj1yk11w X-Rspam-User: X-Rspamd-Queue-Id: 79B874000B X-Rspamd-Server: rspam06 X-HE-Tag: 1674117781-361872 X-HE-Meta: U2FsdGVkX19XNofncwM2ixa9IXcG38wWs/FCegkVcgDhSfx134bfOUgMrYCG2FiOwHaIlf+dFl9uez64A03R8b7MU9Wiee8mD1zIHCeIqkPzhNJ32xcfh21DM8INcs9B839zpvDWQ177vbBj8MI6hdUK9eWyGusSeCmcPqSMz09QLTAZqUoe0zeCYvU6O5CRRbEBBUvy+Vw4xi7P/JS/8/WUMMt59YHLefir3UWOyJf4rI6bD3jrA14MQAJPXR82bDnQaVM4E7CGCRodIEuCZLIH6VWXySyGRjrovdFGQKnfq3YwAU4M1l/nJR8crd2t52aIuYU+NS0EF+LqAiH7mPLVJt7repj7oeIKyO9PMECzCUq2dHUT8lQM2vCaaPHoj+BeQvrz79VGvvTqbEDaRrnhF8WfKjbbhsVjB1tWau7z93Ye8dl/IoGGalkdzLAMVi/lGkDbj7B17Zba2Vfo4mt1AbR3B7JL1XncS6YrC4aeJhXQ7eGdPAX614CyarJSw/KqEdBIYIcjDdXxkbNHRWTGEJ8/DDOAS98BYsfFEOmjZ43AHE4N/DbzSBczJTb9GXYeVsWhb4wvotuuUKj3e+e1iLs0KGKvpoyzMVSLwZgpeA8C5WFekfOCExTYyf/qbNAFUIE7Pgm55GBBAvMLNhJ70Pa/t58wNJCqLDkZFAIBxrfMQl8jNUI93JEGV7WOku/mn+ZsLYJKvP/Vl+SQgHY41VThYuWviR3Bxz55H5Z8uD5LCEoLcwxWAIX02VC97NOBHEXXvHjMI8n3TjiYJxVjDrKGzovLb1e7oQpCs4PBXoGPGwl2iDtWh/kvsM73qDVzShzm2rSwXJHJU/qCL1qEkyC1sH5Jt2i9ubUfFIZrqIRB0PSfCQzKvmgCDIswjLS7Oc4Dp434BTM9BwbQ6lzfHllHJS+53fVkyR3GOjECHZNweOeCk916jL3knZywgms5Jd5fplBWDdY/oBB QtvylIo+ MhA1GuRg6F/VOL2/3U10wPenN9JmzrQOsBqUml0za9s+78p7Yzb/zi5T0sfHnbMMcTi/baXSg2nc6gZY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 03:52:51PM +0000, Pasha Tatashin wrote: > page_ext must be initialized after all struct pages are initialized. > Therefore, page_ext is initialized after page_alloc_init_late(), and > can optionally be initialized earlier via early_page_ext kernel > parameter which as a side effect also disables deferred struct pages. > > Allow to automatically init page_ext early when there are no deferred > struct pages in order to be able to use page_ext during kernel boot > and track for example page allocations early. > > Signed-off-by: Pasha Tatashin Acked-by: Mike Rapoport (IBM) > --- > include/linux/page_ext.h | 2 ++ > init/main.c | 6 +++--- > mm/page_alloc.c | 6 +++++- > mm/page_ext.c | 2 +- > 4 files changed, 11 insertions(+), 5 deletions(-) > > Changelog: > v2: Fixed build issue with CONFIG_PAGE_EXTENSION=n > > diff --git a/include/linux/page_ext.h b/include/linux/page_ext.h > index 67314f648aeb..bc2e39090a1f 100644 > --- a/include/linux/page_ext.h > +++ b/include/linux/page_ext.h > @@ -29,6 +29,8 @@ struct page_ext_operations { > bool need_shared_flags; > }; > > +extern bool deferred_struct_pages; > + > #ifdef CONFIG_PAGE_EXTENSION > > /* > diff --git a/init/main.c b/init/main.c > index e1c3911d7c70..64cd2ff051c4 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -855,8 +855,8 @@ static void __init mm_init(void) > pgtable_init(); > debug_objects_mem_init(); > vmalloc_init(); > - /* Should be run after vmap initialization */ > - if (early_page_ext_enabled()) > + /* If no deferred init page_ext now, as vmap is fully initialized */ > + if (!deferred_struct_pages) > page_ext_init(); > /* Should be run before the first non-init thread is created */ > init_espfix_bsp(); > @@ -1628,7 +1628,7 @@ static noinline void __init kernel_init_freeable(void) > padata_init(); > page_alloc_init_late(); > /* Initialize page ext after all struct pages are initialized. */ > - if (!early_page_ext_enabled()) > + if (deferred_struct_pages) > page_ext_init(); > > do_basic_setup(); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 99ebb08dc3f2..717f12e83b85 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -430,6 +430,8 @@ EXPORT_SYMBOL(nr_online_nodes); > > int page_group_by_mobility_disabled __read_mostly; > > +bool deferred_struct_pages __meminitdata; > + > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* > * During boot we initialize deferred pages on-demand, as needed, but once > @@ -6803,8 +6805,10 @@ void __meminit memmap_init_range(unsigned long size, int nid, unsigned long zone > if (context == MEMINIT_EARLY) { > if (overlap_memmap_init(zone, &pfn)) > continue; > - if (defer_init(nid, pfn, zone_end_pfn)) > + if (defer_init(nid, pfn, zone_end_pfn)) { > + deferred_struct_pages = true; > break; > + } > } > > page = pfn_to_page(pfn); > diff --git a/mm/page_ext.c b/mm/page_ext.c > index e2c22ffdbb81..dc1626be458b 100644 > --- a/mm/page_ext.c > +++ b/mm/page_ext.c > @@ -92,7 +92,7 @@ unsigned long page_ext_size; > static unsigned long total_usage; > static struct page_ext *lookup_page_ext(const struct page *page); > > -bool early_page_ext; > +bool early_page_ext __meminitdata; > static int __init setup_early_page_ext(char *str) > { > early_page_ext = true; > -- > 2.39.0.314.g84b9a713c41-goog > -- Sincerely yours, Mike.