From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF0EC38147 for ; Wed, 18 Jan 2023 17:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E8E36B0071; Wed, 18 Jan 2023 12:27:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2997A6B007B; Wed, 18 Jan 2023 12:27:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1878C6B007D; Wed, 18 Jan 2023 12:27:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 08C436B0071 for ; Wed, 18 Jan 2023 12:27:06 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C9AA180BFE for ; Wed, 18 Jan 2023 17:27:05 +0000 (UTC) X-FDA: 80368600410.05.094FC9F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id 1FF0320010 for ; Wed, 18 Jan 2023 17:27:03 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VOl8M1j3; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674062824; a=rsa-sha256; cv=none; b=YGxmVvPs8mfsanneUXOZH9icX0yEEfMzRmCGrIkT/g3VCq7N3tropJt5khHO8rO6sqbku/ N8QTw1KA05y1JxiFp/buk+v1yJAasR/PE5ra+UMADjAshIMQd1TM1Ywd0zkCnEwe+Mjham DW/Nhcjx/KGZuBeDStYAyK2Goefqre0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VOl8M1j3; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674062824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rme+J37+1wmMiSJN3/9qvxJPCETZuXLtzu0rIV+DCE8=; b=AckaO/oJJa3t6f4ufkOhJrtb82b0bRYUFmsEHXAHjvTfKjHciuqtWzdsiE0/+E0OTIAEoc uTEi8YOihIOx3AizXDPvn9AWppiN+LyglQSiEfwYDclYr6WnAIrvpD/H7PfLToxFypX9r0 NOKXI2kx4wqAYftdRPZnouz+A36R8no= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A1F075C1A3; Wed, 18 Jan 2023 17:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674062822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rme+J37+1wmMiSJN3/9qvxJPCETZuXLtzu0rIV+DCE8=; b=VOl8M1j32fEoQROZKP5BX8QEun+ys6lASiBkTNut3VHnQ5gytED+kNqLXQ8AXr80REuxuE sr6rKatScGFv0ZxEpATvIo3ZdlnRVbhEKkNiHTpkva1q4U1TQZpUqSyrHgFoZAsMhCUF1F Kg9T70eKwktop3KAf+Z8ED/w9V0qBLo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8914F139D2; Wed, 18 Jan 2023 17:27:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b/WJHuYryGOdSAAAMHmgww (envelope-from ); Wed, 18 Jan 2023 17:27:02 +0000 Date: Wed, 18 Jan 2023 18:27:02 +0100 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , Suren Baghdasaryan , Matthew Wilcox , linux-mm , LKML , SeongJae Park Subject: Re: [PATCH 3/3] mm: add vmstat statistics for madvise_[cold|pageout] Message-ID: References: <20230117231632.2734737-1-minchan@kernel.org> <20230117231632.2734737-3-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1FF0320010 X-Rspamd-Server: rspam01 X-Stat-Signature: uta7nef9x5q8bkmhr8nitjbuiwqh9wdc X-HE-Tag: 1674062823-185319 X-HE-Meta: U2FsdGVkX1/ZOLULtvrmT0WWFtrbC5dNdOTEF3b1CkfBtScBLxswW1yl5zmMzwtYHa/e80qu7RsfC2jjP3cpmhjifElH0AEKjW9/vWZwIjNYSqdsbdmiu9FAzrCnAAnO91Z0MO2iJOZe8gUjJOkm1oEmHLDbaY6hgfQKafYHebP+xD4zCckUHoT+ZlcvfjcXTD9KlsNk6GXOukS49qVhxxVSM0ZtIfgrxKY9gCXfTnE9SAVM5j+fPK3yYp8BKY6XSMze720lzS6hx3yr4v2PLUxxVuikrvFjCVkbudowPl52ccehdNObj7MgOEaI+YiULBjuFu3nay0cUCnIPP5nzIPtmwGWxdZhXa+Yiz6dLfwMNAyFuJvF416TLHeMlUnsj7JYLu/jrgLwqRJcBnMX/J03MouOwaplV+lFLLMQgR3CcVmIz4sl/tSkRiQQMIKueRHpvjY1pukJC3ocz9LqrDTJ5EQ2zC3cQGnEETCdKOMfQWqFXgHBA+dV+d0zU6NJH+T55EM8J9ZZMziNyOartG7xAFwPrV/63mqeKfFitQ1fmv9m1D/OIMlPTdmmCulSF6k44jcKZkzoF7qqnOkXCae4v2JUhoXCysuxGTTlh/Sf5YuPjbFvsDiFM7gubRRsMNm5Kw5fIAFFqf2tsKeVrRNf9suGvne4tvCuDCxaCN3YyhB97ZQcybY2oZlPGEoPSy9VDVILBVM/fxDkEQ5UkFHCey5ThLGBSZuJQ5YjbBXCZkPNdEO5mLwwbxLOto5+c+za3r/9QHEw+2XCYJzcKuyw+K7UJF15DJl0SYeNDRImo6Owf0eFy5xxuaCk4WUwF407VwCPn1U27814/LJgN4fsxGq4ftwj0e6gHdHK93GR4S7HG7AhlLYaFufZaQcxVzCNxNE3GcJcKtMt8ZFaK/ky2/XUv+FB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 18-01-23 09:15:34, Minchan Kim wrote: > On Wed, Jan 18, 2023 at 10:11:46AM +0100, Michal Hocko wrote: > > On Tue 17-01-23 15:16:32, Minchan Kim wrote: > > > madvise LRU manipulation APIs need to scan address ranges to find > > > present pages at page table and provides advice hints for them. > > > > > > Likewise pg[scan/steal] count on vmstat, madvise_pg[scanned/hinted] > > > shows the proactive reclaim efficiency so this patch addes those > > > two statistics in vmstat. > > > > Please describe the usecase for those new counters. > > I wanted to know the proactive reclaim efficieny using MADV_COLD/MDDV_PAGEOUT. > Userspace has several policy which when/which vmas need to be hinted by the call > and they are evolving. I needed to know how effectively their policy works since > the vma ranges are huge(i.e., nr_hinted/nr_scanned). I can see how that can be an interesting information but is there anything actionable about that beyond debugging purposes? In other words isn't this something that could be done by tracing instead? Also how are you going to identify specific madvise calls when they can interleave arbitrarily? -- Michal Hocko SUSE Labs