From: Michal Hocko <mhocko@suse.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Matthew Wilcox <willy@infradead.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH 3/3] mm: add vmstat statistics for madvise_[cold|pageout]
Date: Wed, 18 Jan 2023 18:27:02 +0100 [thread overview]
Message-ID: <Y8gr5haAMtQJJSR6@dhcp22.suse.cz> (raw)
In-Reply-To: <Y8gpNgkwMqVPN7dm@google.com>
On Wed 18-01-23 09:15:34, Minchan Kim wrote:
> On Wed, Jan 18, 2023 at 10:11:46AM +0100, Michal Hocko wrote:
> > On Tue 17-01-23 15:16:32, Minchan Kim wrote:
> > > madvise LRU manipulation APIs need to scan address ranges to find
> > > present pages at page table and provides advice hints for them.
> > >
> > > Likewise pg[scan/steal] count on vmstat, madvise_pg[scanned/hinted]
> > > shows the proactive reclaim efficiency so this patch addes those
> > > two statistics in vmstat.
> >
> > Please describe the usecase for those new counters.
>
> I wanted to know the proactive reclaim efficieny using MADV_COLD/MDDV_PAGEOUT.
> Userspace has several policy which when/which vmas need to be hinted by the call
> and they are evolving. I needed to know how effectively their policy works since
> the vma ranges are huge(i.e., nr_hinted/nr_scanned).
I can see how that can be an interesting information but is there
anything actionable about that beyond debugging purposes? In other words
isn't this something that could be done by tracing instead?
Also how are you going to identify specific madvise calls when they can
interleave arbitrarily?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-01-18 17:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 23:16 [PATCH 1/3] mm: return the number of pages successfully paged out Minchan Kim
2023-01-17 23:16 ` [PATCH 2/3] mm: return boolean for deactivate_page Minchan Kim
2023-01-17 23:16 ` [PATCH 3/3] mm: add vmstat statistics for madvise_[cold|pageout] Minchan Kim
2023-01-18 9:11 ` Michal Hocko
2023-01-18 17:15 ` Minchan Kim
2023-01-18 17:27 ` Michal Hocko [this message]
2023-01-18 17:55 ` Minchan Kim
2023-01-18 21:13 ` Michal Hocko
2023-01-18 21:47 ` Minchan Kim
2023-01-17 23:53 ` [PATCH 1/3] mm: return the number of pages successfully paged out Andrew Morton
2023-01-18 0:35 ` Minchan Kim
2023-01-18 0:58 ` Matthew Wilcox
2023-01-18 1:49 ` Minchan Kim
2023-01-18 9:10 ` Michal Hocko
2023-01-18 17:09 ` Minchan Kim
2023-01-18 17:35 ` Michal Hocko
2023-01-18 18:07 ` Minchan Kim
2023-01-18 21:23 ` Michal Hocko
2023-01-18 22:27 ` Minchan Kim
2023-01-19 9:07 ` Michal Hocko
2023-01-19 21:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gr5haAMtQJJSR6@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox