From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB976C38147 for ; Wed, 18 Jan 2023 17:09:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DC746B0072; Wed, 18 Jan 2023 12:09:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B3436B0075; Wed, 18 Jan 2023 12:09:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B826B0078; Wed, 18 Jan 2023 12:09:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3681E6B0072 for ; Wed, 18 Jan 2023 12:09:42 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 074951403E2 for ; Wed, 18 Jan 2023 17:09:42 +0000 (UTC) X-FDA: 80368556604.27.833E6B7 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf29.hostedemail.com (Postfix) with ESMTP id 2A6FA120015 for ; Wed, 18 Jan 2023 17:09:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="mK6kGMN/"; spf=pass (imf29.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674061780; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1WGfWh/zHmol+2Tw3XXG4jVv6PUDBSBBQZSscxBuklU=; b=Z1nsMNs0BoI/vauIiW3QbGtu+FJmcr3vmYz/m0gOKhcI6KQewfRt2fnP+iQEWSBEKk0Y0q uvTSNu4FoW7OyJ00s3yF3NdfPfycXQufh9V5xwvJx/+R25mS0knHJVAF119Oc+O9oUvpfu 9mjoK9Fbxd5uMaDWlfkKYL/VSDXhr4A= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="mK6kGMN/"; spf=pass (imf29.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674061780; a=rsa-sha256; cv=none; b=REIDAY9Qx6f+q49tKP9CJoQgY7WZ7MUdOlN/TfoKGbgKJQGkbLqzd6iD5jna5dxgmfTm2h +yDRqdgayoc3g28cONwKrkq2ntOxVVuJeljDfAM7it/l4NvIfKyGN7ddhqVO6TNmFjJ9zp 58RxYHg9K9NLWFMZ23NogTgDxFVSYSc= Received: by mail-pl1-f170.google.com with SMTP id jl3so2460340plb.8 for ; Wed, 18 Jan 2023 09:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=1WGfWh/zHmol+2Tw3XXG4jVv6PUDBSBBQZSscxBuklU=; b=mK6kGMN/rEiKZDELQxhZim27kifJzxaqluXyKU+4ExEOuZ40hTiclMDYcWW5SMzcnd z/B626AVqbpaIScKxqXmmeO6/A42ZcYj3fwOdRK2Q/HuXaltTF/hSwC7aVqKCZI5X203 NjwdBAab4rV13ti/tjDwe906nKzz72rWoJBik50lusX0rDs3noH7ZehEvggmuIHHeqWk dwyulZ2TwCGjOoMxtn4njf6AJeYX7php6fvqp2PbSmEQSQdfGyaJCRxVid+qqPacTaSD 4g6Ry4Qqij026xFUvHbsMrwHzQLbjUAhk64362DLL4IvTmhIBBrR5mqWkgPYmIgoFIZa 6esA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1WGfWh/zHmol+2Tw3XXG4jVv6PUDBSBBQZSscxBuklU=; b=HLvm2l7aEEYFAby0p7n81f+BtB3MQoWpVk5VbvP8O8LBMNqFdyhqWc0q7nLllv03PK Peq9A1qG26Hybg9LS4T7hL+C7F9BLfiPuSMsrzAjXaQXLlPWAj5bRyfwjxbrrZvRqeDk 3dckZzUmK1HPswht8zbol7XxvCQWf5mmIW27YtJHqmrXh64cmFeArJjDbUiGgiBVE+24 Ec7R0lZ4O+Vs943M0/nDyM2j43Agmb8Rn3WdiuIlOE0b3Nx6ISHm+nXWnZQJ7kqKqmVZ +4MGwfFXnpcFa2xQBxVWez/EDZBhp/VR8fdGiVa4dKhcNJdyxzBlIIw2yk7N77xNWaNv gONw== X-Gm-Message-State: AFqh2ko/9/2j1Fxap5htm4ihV7uNDdQtJtgC/8pPvUTKKhuMoD5Q7Xn8 ey+RAiFkhGJ2nNOHu/J2How= X-Google-Smtp-Source: AMrXdXvr0eQnszyMROWr11Gg6xDwKAU+pPtxVu/K5xZECg96vcWBYEH9NSp4CfBFov/AYkfX1RBoUg== X-Received: by 2002:a17:90b:1197:b0:229:46f0:6f6d with SMTP id gk23-20020a17090b119700b0022946f06f6dmr8475165pjb.42.1674061778863; Wed, 18 Jan 2023 09:09:38 -0800 (PST) Received: from google.com ([2620:15c:211:201:68ba:bd93:858:15d5]) by smtp.gmail.com with ESMTPSA id r89-20020a17090a43e200b0022941908b80sm1560900pjg.47.2023.01.18.09.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 09:09:38 -0800 (PST) Date: Wed, 18 Jan 2023 09:09:36 -0800 From: Minchan Kim To: Michal Hocko Cc: Andrew Morton , Suren Baghdasaryan , Matthew Wilcox , linux-mm , LKML , SeongJae Park Subject: Re: [PATCH 1/3] mm: return the number of pages successfully paged out Message-ID: References: <20230117231632.2734737-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: kim64to6c7sk6eieee4au3npjon33wp7 X-Rspam-User: X-Rspamd-Queue-Id: 2A6FA120015 X-Rspamd-Server: rspam06 X-HE-Tag: 1674061779-183270 X-HE-Meta: U2FsdGVkX1+4uwQADOQSDqoLv64e1gSTX2nZ8dfQpPCPLaBCjcne4rLQWb2YwjAxQJSiCSecl7WZj/fLJ8TMgUKYQQ0D3MxsmfJbPXl3DEMLXfZY4BpQRrZqGbpCzZSOppKTesTNlzZr/Eyy8mHLNUsu3YVu5dmfhv/Hrf6HlVGKMk5nVqt1ZZqkDf221H9IfWMvdxwfxORtUyPwn/+luQxLT2BRHRTRTT5dyW5g8tlL2Iw6yQ0mnBxSd951nYREg/9pS6y+Gt2t+khi3kFZxBL4MkpbiMofk8PqneHkJqH4tpnwp3ik6MLUSZOgn5nZt+IUooBNTZR4cllaufqY+NwjUIyb4lZobmkuvj0blgqM9C4mKo7Hrs1kPnFjxFXIwNYE286VOXOQJ9CO7dWSKEj/duF8wICfVAm4I436011nWdmW4FyPXnYE5wDNpziTQssOoBzVBO2FAtCAhxeQsbRW0hNQLevqVjw2VWC8uHWPiOeKtBNCGtUOnhld3F3gdC8PsfkUSlKlr+r0t1xYEgKD+Lj+5Nx/2pZGtjLKDfQyicn/Hgd8z/2HjXLgkF3PIXx5b3kW4+HWh52tja1D7HM8nsjJUBV9a6/iudm52NQ0+eeU4kVX6yAsR0BQo7CLDqqy5d2eIilg6/nEir7+jq6zdO75w08XKwYWxPoXZPMStEC9gl56BDo5WimuFgL/BXgH44HolD+WGPZ4vnlESP1yKMtgiIQ5+a6LYH2f3oP4KURcTndBSdkkjwKbAXKOICllMy9J+Ja1l7+9fhEuHHHG3RNC7MTZYmMJHO6hyyv5ugTMaJt8Tq8aNynHUfh2GV2DEFdau6GgaWZ8vLGUda5IVxOKre4sipQSxbo7FusETM751tn/I5kCOQ8B9aXfSXDlJOu4wweFmaWYA8ZAXtlRMfRSNKDUZgTEueLA57T3dBrzrKFtcu0lFgMNLtNYGNnrUMLS6NwQtA0gF0J +EIkkdy7 jWgUxE+v/tJmRzj4rjGew3fcueybsWd/SCj7PgbqglXgwkf12DqS3xj4Bfwe7wxErtmM2mlUUTJMXvY7IL4C7px3O7f+60/RUzaqrbs7lwY4fVzWS2Xmb5GMlUkIU400XaMYEH6OFck7MqqiyALerrN86tFQ6501Mv6Qlf3EQjosVN8WCZ+CbgcRjEyk4SwxFDOrwzRTP4ummgykOjZZP+XEg3zhirV0IODWJgxrL/oUWF+pOLUL235ph43tvCG+WZto4ht8uCsoretDHb0wd9J4/L3DxZMmpylBCJ6fkxg/lFeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 10:10:44AM +0100, Michal Hocko wrote: > On Tue 17-01-23 15:16:30, Minchan Kim wrote: > > The reclaim_pages MADV_PAGEOUT uses needs to return the number of > > pages paged-out successfully, not only the number of reclaimed pages > > in the operation because those pages paged-out successfully will be > > reclaimed easily at the memory pressure due to asynchronous writeback > > rotation(i.e., PG_reclaim with folio_rotate_reclaimable). > > > > This patch renames the reclaim_pages with paging_out(with hope that > > it's clear from operation point of view) and then adds a additional > > stat in reclaim_stat to represent the number of paged-out but kept > > in the memory for rotation on writeback completion. > > > > With that stat, madvise_pageout can know how many pages were paged-out > > successfully as well as reclaimed. The return value will be used for > > statistics in next patch. > > I really fail to see the reson for the rename and paging_out doesn't > even make much sense as a name TBH. Currently, what we are doing to reclaim memory is reclaim_folio_list shrink_folio_list if (folio_mapped(folio)) try_to_unmap(folio) if (folio_test_dirty(folio)) pageout Based on the structure, pageout is just one of way to reclaim memory. With MADV_PAGEOUT, what user want to know how many pages were paged out as they requested(from userspace PoV, how many times pages fault happens in future accesses), not the number of reclaimed pages shrink_folio_list returns currently. In the sense, I wanted to distinguish between reclaim and pageout.