From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD24C32793 for ; Wed, 18 Jan 2023 16:49:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8CEA6B0075; Wed, 18 Jan 2023 11:49:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D3DDE6B0078; Wed, 18 Jan 2023 11:49:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C041D6B007B; Wed, 18 Jan 2023 11:49:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B402F6B0075 for ; Wed, 18 Jan 2023 11:49:32 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 17FAEC0B99 for ; Wed, 18 Jan 2023 16:49:32 +0000 (UTC) X-FDA: 80368505784.13.8D07E28 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id B33524001A for ; Wed, 18 Jan 2023 16:49:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lgw49xda; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674060570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lgwAP3iZLubX4jJpj4ZhHlVnjkE2V1abu7VwSCjHn5c=; b=Ga44Zy5EfH55cuxKbZiD6uEqcTWuDsbxOnvqD9KOX7JyjZ+jthnckU1lxSBVwGGP/zcSaV mTI4iUS0FcZyDBR0PdsvSoN+bqvLIVyfIvWoJj4XGFb94S17hgZaybKczch6uKJPZxWb+g s1QvZL8weJCgKNlmN0WngPwNswQY8ZQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lgw49xda; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674060570; a=rsa-sha256; cv=none; b=5BxWyRtR/qaefULfUTqN45A5oTI2Qaz1Uk73wnIcnMg6uNJeSbh845StF/hhlRlnII7a2H BR8qANYsdITAHta8cFIHuFMdoylXcXaZic4oss3O0rPtOmiXNiImW4fjpLg0I6RLXAeO2+ PM6DQ5eB1zrkeM0YcIuIkw9wxBOlly8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674060569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lgwAP3iZLubX4jJpj4ZhHlVnjkE2V1abu7VwSCjHn5c=; b=Lgw49xda+DyR5l4fncoFhNNFzTokT0FtESkC4Zr+7fVNBBiZ57rNftjD7ZWYzM5mnqfE0L wfcso1Za6jNnBXE/+74unnTW1YbA0W+ovhQbgaKN7NAUxS5OJZWTKOWG0jhgESu6k7ShcR dWrkH3PAi6IwYbWkROw80apjU7RXilk= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-92-F4H4c3USNE-zuEdU3RGtZw-1; Wed, 18 Jan 2023 11:49:25 -0500 X-MC-Unique: F4H4c3USNE-zuEdU3RGtZw-1 Received: by mail-vs1-f69.google.com with SMTP id a62-20020a671a41000000b003c08f2a8d7bso9143584vsa.14 for ; Wed, 18 Jan 2023 08:49:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lgwAP3iZLubX4jJpj4ZhHlVnjkE2V1abu7VwSCjHn5c=; b=ZwABJZsUZsQyfkQ+iAnFB9JzTV647dK7FoOtJ0iChKBe8aOPwFRo8tdMd+j0CrRL0k 4PczaVdNUCbNgu9qUo3Us6gc+tXwcswNkaKJa0eji2dVUz0E77H4gwY5cP0iWdLh9Lrm wHTD5qJZzxdMiZmcBNqFvRekNfTTCFdE9HAEnuE6I+YRf4SzJtobIarwsm9hKaug+XNB fkaCodCt76fUw6eirhQP5wPHihksSezEdmyOewK0wNf7MoIM/+zHk0ICs5SsvV3WNQfC ZB0pFEWYuTAKfJN179MOZ4d/KgX4NJ8zOsS/EV1VTbdTUnduNwCUFm3Bkuq/4maCBeqd v9KQ== X-Gm-Message-State: AFqh2kpriqOJoSlduiPXbEbKnecCeE9VXEoNEZp/fQT97vrOIbJ6HUaD ruPJcHmI/YipCXVvQYzVEMJMl8LLpinUsXwSHO4FZHQnUwa/Btnn3pBNEaI3pbwFhXyBBO12Bg8 jOG7Zlm1TW7c= X-Received: by 2002:a05:6122:c54:b0:3d5:5366:dc6c with SMTP id i20-20020a0561220c5400b003d55366dc6cmr4414367vkr.4.1674060565085; Wed, 18 Jan 2023 08:49:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXvRoSYdOHAFhWX6SkAWaiD3PJ9bgCoG4JU7ThLaby5WFm6CrHkvSID8k/76bqXjrAWdFrKBiQ== X-Received: by 2002:a05:6122:c54:b0:3d5:5366:dc6c with SMTP id i20-20020a0561220c5400b003d55366dc6cmr4414340vkr.4.1674060564852; Wed, 18 Jan 2023 08:49:24 -0800 (PST) Received: from bfoster (c-24-61-119-116.hsd1.ma.comcast.net. [24.61.119.116]) by smtp.gmail.com with ESMTPSA id dt26-20020a05620a479a00b00705c8cce5dcsm11812650qkb.111.2023.01.18.08.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 08:49:24 -0800 (PST) Date: Wed, 18 Jan 2023 11:50:26 -0500 From: Brian Foster To: Christoph Hellwig Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 4/9] shmem: remove shmem_get_partial_folio Message-ID: References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-5-hch@lst.de> <20230118164358.GD7584@lst.de> MIME-Version: 1.0 In-Reply-To: <20230118164358.GD7584@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: B33524001A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 6azmjyg1g5s1udf9ko5sh9d4dc88ocgu X-HE-Tag: 1674060569-333573 X-HE-Meta: U2FsdGVkX1+qVQCDMCXG4dGFXvBDOiti+1IFV0jYNSFR5cqmO11BcQJYAC79FOfzkfj6EFy4MBierypcRzbc/gKpzsMVBnzS0N7Fly89mhnYFOgcFvbaLDGZKEKX4u6rDqqhvP/UrJX24nFH0bfUct5JJgsShfQc8efp4CWZwX2JunKjHeFaqzQuDqtoM9j9ULTPsl46hR+yVReREy700iP98GYV5ZD+oMr5SAJtq8YYFVeFqaCGVgYEnQfBiMp1S2WN62tQvQXHt8vfaCHi5XW8ruZWOHAdS+fUirwlHxUpkTxM8W35Fm8fZIeWE1yEvW3WjkUy3Ty+K9DSNgmsW0HuJeNrrEgnG815Nb3EQDr3pRt2kK1eswmlXNpvMVx5Vbzn3sA3RgRrH/98HvglX9rW0ZiEiCHFEqmV0w2lfqN1A46CsKqlC2C4FKUKtxWy/MoyNlpVm8oOSMSCwSAVPDNhsQgvw4Bl3JzZTleUkTnyk/eN5fBDYRZUJuaLj+7TOe+rQcaZPQmX3aeSWlyy9iDYywDMYcGhWLWEHigfKL0+xflaAuGvjMe+F5DrjuNzAIXEDGy0+kFhAXgtL3S8scjFrIX8hrlIOR641jE2PrWYWhdcNsHktAgzvCX4Dn8Ypx5Au8vJ+gK9xU1YGynKETCblW8I1rMXYtil/YNG/5M1hYLY/U5UQGojzsB6LW4Yll7lNdxuVy3JdITxp7rxiHIvtHV+A23Qa+d08wo4LiGgYhcD/GPVuj5dNp8mb4puzowBMCVfiy6uD1bSiNGHD8qLGK1bLe6P2YRmzXGeJ8GGchXVDNLGnkjZKXJm4rBbD5KlE6ffWWzl3hAZpqUkVSK/ZbGN6te1v8h/RFvqQ+B68CNoQeUchhoizGfpl47xR8Hc1z7eT1qn+8hsOSiiQTjkkgkormoNsTHw7S+XpqLGx3yS87EX3vGi/3cx++cbzSCHm84AkHOV/wT6PBk XrTpCO8e umxzvqorfeY3BJMi7pgi1XRGi+M3rWiTPO4G8AXypSBedju5OmdNKpdmpiqkINGv4u4JnduUz+HG5WilIclJrRGN0ip96tICONaDtLs9uuXA+fGkViUCUcTQQBjCKncy1gn8IEPJAGhu9bP7QIpVIVS4g5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 05:43:58PM +0100, Christoph Hellwig wrote: > On Wed, Jan 18, 2023 at 08:57:05AM -0500, Brian Foster wrote: > > This all seems reasonable to me at a glance, FWIW, but I am a little > > curious why this wouldn't split up into two changes. I.e., switch this > > over to filemap_get_entry() to minimally remove the FGP_ENTRY dependency > > without a behavior change, then (perhaps after the next patch) introduce > > SGP_FIND in a separate patch. That makes it easier to review and > > potentially undo if it happens to pose a problem in the future. Hm? > > The minimal change to filemap_get_entry would require to add the > lock, check mapping and retry loop and thus add a fair amount of > code. So I looked for ways to avoid that and came up with this > version. But if there is a strong preference to first open code > the logic and then later consolidate it I could do that. > Ok. Not a strong preference from me. I don't think it's worth complicating that much just to split up. Brian