From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F086FC32793 for ; Wed, 18 Jan 2023 16:09:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8042F6B0074; Wed, 18 Jan 2023 11:09:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3FE6B0075; Wed, 18 Jan 2023 11:09:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A2A86B0078; Wed, 18 Jan 2023 11:09:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5A26E6B0074 for ; Wed, 18 Jan 2023 11:09:09 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2E26E160C64 for ; Wed, 18 Jan 2023 16:09:09 +0000 (UTC) X-FDA: 80368404018.06.CB5F0FE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 981371C0022 for ; Wed, 18 Jan 2023 16:09:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="jk2OX/GH"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674058147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JEUOAZ78kJr603e3fslTqPJIm0KVjgSmMPI95SNsLdQ=; b=nguTfVi/k1mdsJ08CXtLRe9yVLEWL8QU5TQLm8Tar/nCjI1dLqBwsDpio+OzGMGuoYLUde tJJWbantzC/JB/+uEiq5dvYn20XsOUOVpcn1sEcxEBmuKO+a+uAXWONk6TjCE6sVdYJIAT fkOhN3j+vgRRIZ65xrNTYbkOlB4Niy8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="jk2OX/GH"; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674058147; a=rsa-sha256; cv=none; b=RR56VKL4wnyuts3tzsMe9aMCfY1f1Tib70lmOl7wtaCrdZoByUjASxF8mCqtFG7I0rnn3N VK4jpdv08BlTl+/y7D20fMk0uv5zixRXZ3Zh/hAYhUEAwrYw/3B/CBnpCyzzAh+7nH7x08 GMYGloxs8fyAxTRYnXQRi+6yRzLmTQA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JEUOAZ78kJr603e3fslTqPJIm0KVjgSmMPI95SNsLdQ=; b=jk2OX/GHKt+KDBvU+2AWIJn5ry QSvBl+h/HCaJiHuccrL+v6bRIufcwCTd0eMLPw1XCRpUNlJt2/bfbsfInmdxoeLrYYKHi7OGjLgOO wuAzMNrhOaicl2w+hFj8r+3l6ge4M+Y7Tf9d/yyASO6QxFfm7hHBD4IMTbGeulZC5l3g/Vb+9it3D 94gz2e1P9UT/wh+6QM64zP7CvRhYB7E/w6Ny0qhYYjx+6RUCXFzz5UR2L+8sEsUYqeHN6WfD88L64 9qubXFGDeITGtJyWPF50S62gtex3EBM7lI7TX9PRim5NbcZlyBfkHtyPAoWpa/UQ6WykrPInUoJ3z QYRfXUVg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIAzh-0007zm-8H; Wed, 18 Jan 2023 16:08:57 +0000 Date: Wed, 18 Jan 2023 16:08:57 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io Message-ID: References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118094329.9553-9-hch@lst.de> X-Rspamd-Queue-Id: 981371C0022 X-Stat-Signature: nztq9j7yiz67hnaqbr1ojgfw43uahi7b X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674058146-796148 X-HE-Meta: U2FsdGVkX1/QZ5STbwajoYXiqXMbQozHLLDHSfsvDXnCYYfmXsbQK5Cz1f0lyWP+mlKmN/lCzs6dlwrtxoo47e5g1llfxz37MHln4NyTBw5LR8mlIoigmEGsVHLoTGr8Mn5dj921f17a7qjg9JLq67ckySBggN+tktLqnbykEHzR1ZO3hD+hyTgeAF1Wh+8E3kLcV1uh/j+EYbSw7VzC2JJ4s0k1r8qjNIBkbw2eafPZlIJPSlKn57X5Hyqo1KhBoUJ9BJkg/7B5k8FeilLGilvd47PdvvWwqMpfNQgmglRcNvSx5qEjr3FoGDVJtm+Qf7jfjMH9b3PLy164QMFb+GE+qEG/z9F2pLIVuq9GcX0roIYEH85oiX+SJxGgPKOWKXb3MpUNNZ4e44j4uzCSUL9aqSG0QOi9XhYWhI8UPeSIqtRkJmFvemN3TYkMYyGKuysWozRR4fG9+gd1oAdUOFTu+/V3ZsdL0GomFA/UaNi4F2S+cZuN0ssFsOX4AJPUBhNe5F9ORuHFo2BXZiSoPkJmH9FCAlaZbzuPyhNr8dNFmyftKoXPflw3zOmXCeQfF4B/UB2mas71cFjiW6CObMhyDwSepqeviB3/qZmCZEGOshqop51RE653PT1N492/aWNdsynMOC6SJxbQCrRx7j+6aJPHFe8twIySkkMOU38VVCbxxK8UFM2TH3iw9afvsizGLQzLwtM8OddZgWAqIxMt0uPN2C3TDJ2Y0UIhNCftaBCF/qfmZAtoyS5bD1TcNioGYVAlRnFisNhUcT7xeNhgynlnzDyYUXH/f3DJ2bIsC9ObYMVP3lGt9MIvmu84Bi+ziZWBse29tILXzFYSbgOAxXtdBmSSl56SPXErcQRZGEedoZRAtsr1sghNmIskUZKYtqXVqO0cnBZ3b4F9Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 10:43:28AM +0100, Christoph Hellwig wrote: > filemap_get_folio can return NULL, skip those cases. Hmm, I'm not sure that's true. We have one place that calls extent_range_redirty_for_io(), and it previously calls extent_range_clear_dirty_for_io() which has an explicit BUG_ON(!page); /* Pages should be in the extent_io_tree */ so I'm going to say this one can't happen either. I haven't delved far enough into btrfs to figure out why it can't happen. > Signed-off-by: Christoph Hellwig > --- > fs/btrfs/extent_io.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index d55e4531ffd212..a54d2cf74ba020 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -230,6 +230,8 @@ void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end) > > while (index <= end_index) { > folio = filemap_get_folio(mapping, index); > + if (!folio) > + continue; > filemap_dirty_folio(mapping, folio); > folio_account_redirty(folio); > index += folio_nr_pages(folio); > -- > 2.39.0 >