From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10484C32793 for ; Wed, 18 Jan 2023 09:10:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D7AE6B0071; Wed, 18 Jan 2023 04:10:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2384B6B0072; Wed, 18 Jan 2023 04:10:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B3AC6B0074; Wed, 18 Jan 2023 04:10:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB9B36B0071 for ; Wed, 18 Jan 2023 04:10:54 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AEF161A0116 for ; Wed, 18 Jan 2023 09:10:54 +0000 (UTC) X-FDA: 80367350028.24.8CF91AA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 0D8EEC0009 for ; Wed, 18 Jan 2023 09:10:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PsvvPvI2; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674033053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lE/uylM1agVn8TJzDINFCtcx7ZSVF4oMaIC06riBkFU=; b=QZp+H5ie4nAgx/IAJgktjPrpGi9p1zgJbw9Jr27yENyCVNkepwGfPVr9BenZnT3PL11Ifb dd8hK6wO9xEGdS24hYiPm5bLuRAqGz9O+LJIxIGZUZ+WhEb4j8+k87Uxn/iyoGnSozDoEk b4sORQH57pbempPG6OhS0dfE570WJFI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PsvvPvI2; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674033053; a=rsa-sha256; cv=none; b=Gclrc3NK82hZyYQ0w8v0CvtMrpbQXr+ceWfuOGqN6/jgqbPvYgTkNMoqeF6j9CSDylQQF7 fcawS/P0OguGgjHhqzZrSU2sJDOBZu14ML0ljledQAaGoc66SR43kFXZiexukcwSjllJKl PnOFxWjR9zPG2C9XHT7SqsVZZvQwF5Q= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4558D3F4CF; Wed, 18 Jan 2023 09:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1674033051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lE/uylM1agVn8TJzDINFCtcx7ZSVF4oMaIC06riBkFU=; b=PsvvPvI26SXGIQdfpayaw7XFIlKAXaKqXCfu0FT8yzlS1qDb8bf12b4ZWhDteXHoWPwvvw Tx5Z5AcennMK6OjUQC7GK4lWKgOi34BOmvkXaXIZ9/KJHbtL7mvZoFUd4acf5B5MqozsFP F+BCVDAEA6eSAjgENztvPURhydGeh1M= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12310139D2; Wed, 18 Jan 2023 09:10:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id J6ZFFZm3x2O9LgAAMHmgww (envelope-from ); Wed, 18 Jan 2023 09:10:49 +0000 Date: Wed, 18 Jan 2023 10:10:44 +0100 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , Suren Baghdasaryan , Matthew Wilcox , linux-mm , LKML , SeongJae Park Subject: Re: [PATCH 1/3] mm: return the number of pages successfully paged out Message-ID: References: <20230117231632.2734737-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230117231632.2734737-1-minchan@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0D8EEC0009 X-Rspam-User: X-Stat-Signature: dthjxjyjdapyswbj3ujxoqz4xbugeqba X-HE-Tag: 1674033052-398996 X-HE-Meta: U2FsdGVkX1+KslohW2qpFwxY+J4uuZXAUsp8OHZWy1eMUPRaYGWokzhUptuQ+9whK3k8Yxdhs4A3IbtWhRCMYtJHNIPTa7H51zBq/Ahy28ueSpx0Y2pDEZhjKCKb5haaq8V2jfksgVPHTvYh1+G0qrTuIDwgyD8xNyy2vpjtgBXa1qEPMXDEAfqr+KoZg2/IXB7Go455vUk/78riWHHMMuri/5rhe2QFhlS1CjBkjCI/Q9LCZAfzF9sfpyjxN/3VIUXxkSIOwqpDTKutvnHA+pS+m/r5f7vr6o0MQtDJ911pd4rqsetHyU6N4Y0RqJOa/QedYossCOLlekSah8n65GyRupc+zmC/6hNbqPVj4GQkC1v6PD+E7QAUabtAVdJQLrQTLXlnyTLvMdVfshDsQCPlljiviCvI867XnrnjbLibIxC2LvVKYIme8fVyPF9iZheYUFNMEQkUfmfEWdeYV6C8UVUN9jOXRQdFY//pzIXFUxOsO6xEkQ/jjLjhGvIDVqB3fjtTKB77ZAqLtKdk8j7lV9ic+yC4ae5V3R7O9RzogzQKl5MFs/fOXOxeAjGFrZvCql3oTyNp6Aim521ib5FVMFqI2+w+GTs8ZaoRsNMmBBYWpe9/qeOaB9hFqp1UrqcQTeq8t3x5WTRm0PWEVebk1FCxc++YTgfNwPIcJM+cIx16adxe60/GoBmFZuhgZFnna5RCnRZf4TT4rL4YxKnyWPXQI3lVaUP8IjvxXM3GDvcBWEMOyD5f3fNbL5Rq5HYFVgrl/tUAjgVwesc36ihwxRh4VOquhb3SKBeCcWCSyqc5+v5fa0DWAYNTxEwjJvDEJurJfw+FDBUi9utbgGx9c1sM7vgSQcHdZu3LuC8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 17-01-23 15:16:30, Minchan Kim wrote: > The reclaim_pages MADV_PAGEOUT uses needs to return the number of > pages paged-out successfully, not only the number of reclaimed pages > in the operation because those pages paged-out successfully will be > reclaimed easily at the memory pressure due to asynchronous writeback > rotation(i.e., PG_reclaim with folio_rotate_reclaimable). > > This patch renames the reclaim_pages with paging_out(with hope that > it's clear from operation point of view) and then adds a additional > stat in reclaim_stat to represent the number of paged-out but kept > in the memory for rotation on writeback completion. > > With that stat, madvise_pageout can know how many pages were paged-out > successfully as well as reclaimed. The return value will be used for > statistics in next patch. I really fail to see the reson for the rename and paging_out doesn't even make much sense as a name TBH. -- Michal Hocko SUSE Labs