From: Michal Hocko <mhocko@suse.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Suren Baghdasaryan <surenb@google.com>,
Matthew Wilcox <willy@infradead.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH 1/3] mm: return the number of pages successfully paged out
Date: Wed, 18 Jan 2023 10:10:44 +0100 [thread overview]
Message-ID: <Y8e3lHsYoWjFWbRU@dhcp22.suse.cz> (raw)
In-Reply-To: <20230117231632.2734737-1-minchan@kernel.org>
On Tue 17-01-23 15:16:30, Minchan Kim wrote:
> The reclaim_pages MADV_PAGEOUT uses needs to return the number of
> pages paged-out successfully, not only the number of reclaimed pages
> in the operation because those pages paged-out successfully will be
> reclaimed easily at the memory pressure due to asynchronous writeback
> rotation(i.e., PG_reclaim with folio_rotate_reclaimable).
>
> This patch renames the reclaim_pages with paging_out(with hope that
> it's clear from operation point of view) and then adds a additional
> stat in reclaim_stat to represent the number of paged-out but kept
> in the memory for rotation on writeback completion.
>
> With that stat, madvise_pageout can know how many pages were paged-out
> successfully as well as reclaimed. The return value will be used for
> statistics in next patch.
I really fail to see the reson for the rename and paging_out doesn't
even make much sense as a name TBH.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-01-18 9:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 23:16 Minchan Kim
2023-01-17 23:16 ` [PATCH 2/3] mm: return boolean for deactivate_page Minchan Kim
2023-01-17 23:16 ` [PATCH 3/3] mm: add vmstat statistics for madvise_[cold|pageout] Minchan Kim
2023-01-18 9:11 ` Michal Hocko
2023-01-18 17:15 ` Minchan Kim
2023-01-18 17:27 ` Michal Hocko
2023-01-18 17:55 ` Minchan Kim
2023-01-18 21:13 ` Michal Hocko
2023-01-18 21:47 ` Minchan Kim
2023-01-17 23:53 ` [PATCH 1/3] mm: return the number of pages successfully paged out Andrew Morton
2023-01-18 0:35 ` Minchan Kim
2023-01-18 0:58 ` Matthew Wilcox
2023-01-18 1:49 ` Minchan Kim
2023-01-18 9:10 ` Michal Hocko [this message]
2023-01-18 17:09 ` Minchan Kim
2023-01-18 17:35 ` Michal Hocko
2023-01-18 18:07 ` Minchan Kim
2023-01-18 21:23 ` Michal Hocko
2023-01-18 22:27 ` Minchan Kim
2023-01-19 9:07 ` Michal Hocko
2023-01-19 21:15 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8e3lHsYoWjFWbRU@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox