From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9452FC54E76 for ; Tue, 17 Jan 2023 18:45:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAEC16B0072; Tue, 17 Jan 2023 13:45:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E5DA86B0073; Tue, 17 Jan 2023 13:45:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C766B0074; Tue, 17 Jan 2023 13:45:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C7F0D6B0072 for ; Tue, 17 Jan 2023 13:45:31 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6E4DA140118 for ; Tue, 17 Jan 2023 18:45:31 +0000 (UTC) X-FDA: 80365169262.28.405FBCF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 84C3E40013 for ; Tue, 17 Jan 2023 18:45:29 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hRqEKrks; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673981130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1dK4kC0gV7LIDY0KS3EQf7ODamXY8Y+Fsqo3hP5lPlI=; b=WCIZU7GmAFL90ZOzhh8BDlyXvOZqyORW3W9kHMFaMMz0jIQpCV21TVAc0f5KeBJcrfYE6G QN9F7jqxaJnQN1daQTSdhD3EIL9CHKjwtAs0r61GvEJY7JfL80WEA4bJdpEarizPmXIBNB 5tmHS3gzuPOS4KYGzKrPYQ7z3bl7QeA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hRqEKrks; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673981130; a=rsa-sha256; cv=none; b=kfRiqoz95YffbYbClzxzZ2JOWRUqU/ms40HOqDKJIYkPfdganTopCdqbau6C7mlcRnkcc5 Ry45700sWFilqWlIlg6funUoO7zfJlqo1t07NfIlfu1biDyEjNyrZebT4SqxncKOlHuIS+ 4QCbZtbY/1ikevTXSuqR3Vc5iTBfgss= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1dK4kC0gV7LIDY0KS3EQf7ODamXY8Y+Fsqo3hP5lPlI=; b=hRqEKrksojpyAih+9T7IxhDdsc aWA1lbNLg9bemkFWL15nNj0FMpqNAqHRezGxtsgoQtZvLeopVktrI1luSvWJjnpkTBReROPJcF9pE v1VW5rAuowOibpJ9KBmXXSr2Q/PLqZPCHucSIFBDLe4/iWXmmIV15qRgRNTATDHHLaGE8p8+xfqro SUfJAJ2JwRmWQjHTyI3lToHhgxYmOnXialf1eqA2stdzrS+RyQ8FlsKIDeGRbLY9OPVZeYuHE1yo5 g1ULJJ6Vu0exZCliMFAH1hGEcYXfxA6yTCEuLZ08kl+ounBFIstzr3EAE3t5gJHWWC+L/msVqL52g ZVvuXb1A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHqxh-009vBL-KS; Tue, 17 Jan 2023 18:45:33 +0000 Date: Tue, 17 Jan 2023 18:45:33 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, naoya.horiguchi@nec.com Subject: Re: [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios Message-ID: References: <20230117182917.73729-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230117182917.73729-1-sidhartha.kumar@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 84C3E40013 X-Stat-Signature: jgk19he1655ii3w3chpenfxu6mg5zrx8 X-HE-Tag: 1673981129-239938 X-HE-Meta: U2FsdGVkX1/BEslJCT5tj9zpAzF1RZpG9bxEhkzR1s7l6nDUG8Xu/vxF8qyZCiJ4Yr4BG6NW2jDFZ9vcEalQRsKXhE8Q80HtUJFVWuZVJHpR83tJjnxwS+TWc70pAZvOfKe7OZStljYf/tNPjx3Q6gvSq7qTGiumgzai5wbG4/CnSRyE+0hCQH0NRQpqXTWngB0WXPGz8AtlvNDJ8P/yUaT+TbBv5jwDdC2waEGe8ybttdFAZY1QV2HiIOubz7mCVQcla6q58RF2t3fkKUZm+RsraAdQjFB7qLDwZ6rDXDQXbSxcEEET53daklOEMrI3jfdYfWmCmY8YSzRfQlH60jSnSwIjJFB3FV9n5iwGcTHwAWg1c5xbRzEa0Xm6ddw64jEwUymPHcqmjScwWLZZQNG0hIYUnwKQJyGI3pdmMSnAmvkohQM0555DDCjwlGy/eozDiplNXpXe6dqUUTyA+rdQ7MK7Ohx6dDp/4d/+ZvljqPxPQjIJmiwjD9/Fml5Z4Dbm0vLWEmzluFETGARsjayzEzQmaKMq67478kQFCSxyFZbkdRNEPzCyotvMQoD4ZzLpu43xhJfe7FtuwB4fgRbZPSOucQEU8cniMFJduUJ8Imyogsn//y6Y0HQOU4x5a6IE766sYktcvGOlM0QZ3Djl1Nfg4Yv5iJORJwqrAeRf2Ni42Q3BAysRRBoPd1p4dC9Td0Z7Hw0tkE8EPWmvFc14efLpJ9rxkGxHsNQMf61zLJ8bi00uPmk/IOPN9hZIrFMdsUUfDN2uB4Z0YkeXo0uExBNcAd6Ptq9rPTryhTnsL9Bm/PS+L1BRy/W7FU8vTtta3XhOdkCKiT8bar6tG2NikzcOaHDErFhFeQXce2S39pRC8bJksMJupKf1ysFKgCLLVsVJpOF5jw54I0Qftw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 10:29:17AM -0800, Sidhartha Kumar wrote: > - if (get_page_unless_zero(head)) { > - if (head == compound_head(page)) > + if (folio_try_get(folio)) { > + if (&folio->page == compound_head(page)) I'd rather express this as: if (folio == page_folio(page)) as we do in mm/gup.c