From: Matthew Wilcox <willy@infradead.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, songmuchun@bytedance.com,
mike.kravetz@oracle.com, naoya.horiguchi@nec.com
Subject: Re: [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios
Date: Tue, 17 Jan 2023 18:45:33 +0000 [thread overview]
Message-ID: <Y8bszRk2eG8s0uk5@casper.infradead.org> (raw)
In-Reply-To: <20230117182917.73729-1-sidhartha.kumar@oracle.com>
On Tue, Jan 17, 2023 at 10:29:17AM -0800, Sidhartha Kumar wrote:
> - if (get_page_unless_zero(head)) {
> - if (head == compound_head(page))
> + if (folio_try_get(folio)) {
> + if (&folio->page == compound_head(page))
I'd rather express this as:
if (folio == page_folio(page))
as we do in mm/gup.c
next prev parent reply other threads:[~2023-01-17 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 18:29 Sidhartha Kumar
2023-01-17 18:45 ` Matthew Wilcox [this message]
2023-01-18 5:57 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8bszRk2eG8s0uk5@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox