From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E4DC3DA78 for ; Tue, 17 Jan 2023 11:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B0D6B0071; Tue, 17 Jan 2023 06:04:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BA126B0073; Tue, 17 Jan 2023 06:04:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 582106B0078; Tue, 17 Jan 2023 06:04:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 497076B0071 for ; Tue, 17 Jan 2023 06:04:01 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0A3A516089E for ; Tue, 17 Jan 2023 11:04:01 +0000 (UTC) X-FDA: 80364006282.28.D8584F4 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 62CE2A0014 for ; Tue, 17 Jan 2023 11:03:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S4q2S0Jr; spf=pass (imf25.hostedemail.com: domain of error27@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673953439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=GPdOjGFm83f4kYQnlHAm6zeu3q7s4L0PtjR6GkWnuaw=; b=Riu2cR2MkreLtdVntzcs5f/s+LSWsLuyyjCg06/bqUPg9lyO+0KwGkktXHREeMi6yRINY0 lkGA8omlqTou/LiBOQWgdpWe78d4ykwBJmvZrFZH4cF/kSOgQBFPuvOj+D/+BQPE3SIwr1 9vDHvO18DdC8d469DYn4Z9q8bjw4u1k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S4q2S0Jr; spf=pass (imf25.hostedemail.com: domain of error27@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673953439; a=rsa-sha256; cv=none; b=ESbk3w+/peHSs1TDYzKbWrrKNnnRoHnzlOpqfIrOJ48q8ES6FAHMLX/DZubEcJh0XcrWYC HY3p7f4plsPpNO2EFrvxae3EuyEXCRDwXPN6R0pWqtJ+a936VR5g3iYTdA42ibDpuVp7uz JfMHgmwfr/NKam51Uq/3gz/X1dwxzfU= Received: by mail-wr1-f49.google.com with SMTP id d2so10047252wrp.8 for ; Tue, 17 Jan 2023 03:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=GPdOjGFm83f4kYQnlHAm6zeu3q7s4L0PtjR6GkWnuaw=; b=S4q2S0Jr6ESSKetFhdW+0K8dWlGHweLjdK0HSqRZIsmoTvv/5dKpC/Lrr3h66I49sW sHqyvkSyF5oHhZziGpW7/WmHnYZzJ2L+RhifndR9sEWi16hZ8jGCdxHI5cgB9DlBAtU3 Qqqom7Srx93syaSoXxckqITl0lKQhhmSqGapRRaCIFxG4TZ5s/eQ63icPu2T7hq2ayVH pl40wSaqL8Fbw3vmw3vi3VDCyigfVEIxHnHrldsRpGYX1tgZgIQ++OaNbFlINOkxZleJ R5nbAJ1Ihh0Omnt5Mztd+8bLZ4loNYPGiw48eR+ydfzhGSzpCsrdeudO9etv/XB7CZGt gzlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GPdOjGFm83f4kYQnlHAm6zeu3q7s4L0PtjR6GkWnuaw=; b=upEFUtQf4GJvGabFALySLloh3tteRgiFfaRsC4rhsXR8eZOS3vwbqyyQtsn8bgo9ZL ukr/tryjCD4TVHPZEvrvTGjOoZ3FNbAXod4dHu6xRJW3r4M+WrIU/59e5ypITY7xi5cG ko91NaYRkur5ylNb4pWqxPE2hclioYJy91Z/53WvrfncgNvD1eQx8Y75b2yd/rO4n517 sZUmmiM2PSq9bQuDiIifDPwVTPFk2cwxiZ0dzvDhRr2br6I5mJyekssilU9fjunljFCU qRPB7jUY18Az5Uki5dtIQ5UV6J2KJSnPwV41WQx/FNUwO6+iCbxx7FAaVpUEnJVdpaWx /UaQ== X-Gm-Message-State: AFqh2krJqajmutIllQs+JmpS+WVEme5yxZRT2MDlNxvvaDi8jh1zgj4I 2Sn3ZJSzQ+J2Is1AsgqX1GM= X-Google-Smtp-Source: AMrXdXuvKvCx6NaiWHDsBaxq8c5M3Siq/38XNVz0jz6ciNPVYLMEsIJCo59/5B23rCW1RL0ceVTnSQ== X-Received: by 2002:a5d:5b0e:0:b0:28e:f7a:9ff2 with SMTP id bx14-20020a5d5b0e000000b0028e0f7a9ff2mr2654149wrb.69.1673953437481; Tue, 17 Jan 2023 03:03:57 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id u14-20020adfdd4e000000b002366e3f1497sm28875021wrm.6.2023.01.17.03.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 03:03:57 -0800 (PST) Date: Tue, 17 Jan 2023 14:03:54 +0300 From: Dan Carpenter To: bhe@redhat.com Cc: linux-mm@kvack.org Subject: [bug report] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 62CE2A0014 X-Stat-Signature: efwy64zxtiig7auewt7m63zijek1jt57 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673953439-374522 X-HE-Meta: U2FsdGVkX1+xuu4/iKA9qIiQEue2MbouRJEZ4xDjHPeRUNoEsbUR0GIcSH2X8i7rwk53XDEh+jEKTluA6d8XJqOyP5VKEFWY7fsxbyR6PXQPi/BaJLpsTjksUgRZUdgmOtZMOtti1ewFuzLz+FmDuYDzSd+NOBUS48nwr0sBNLChHTci4f1v2kDj28cWX8q0s+sRneDicfWQu2rWLNLUwFcLJWpcAqKBqjhjTSnSMXfRt0/ekpTlflr+FtQ5C3IlnrM0BJ1jsqVLbIcUR/V8JBScUOHUL4gAI+ueWwXHK87qd7PpNeoamrvP2GkvrTxuW6LercUOWjAKf7CIfT6Kc7zAiNNXNwMWPAF2+kQYxpcHzIkMWaqTsJH2/hNoYizEWYTXGFw1CU9AcXdLOkWHD92Fc8HX+dW7NjkoKS7PZ58yOes4QOHg98ZPP8sLZaJwdEgVJkX/AUu0LrP4w0evqS6JO9DZwentBzU1HGzd9ii4hwRVcgkalqfwf0pqddul+cf+Y/xH9TBemFhf79iAEpETo5C4TndMn7KciJ++SsbYXxV4ow3KonzP0gvs3gexm1j33si+X/w+g5N2KsMaEjX8yyqxKfqTaU58Xj/ib80bY/oiehYEFu5A52MOsNfQ43/HEvXVNAH+1FnKeaS3zuLo6gkKxMvRIFcIEeyLuOg/QKIiA9K/ajuDgKurYoWODD6V4j6uTeHDRTmoRFeHe0p4y+dvG+mmpi8tLj8EI5OY2dIRNI+SrXz9Y+IeQ1U/330hFq3m1YwGAR3x5KVR9Nh2+/IJSD9cTdMXPds0/W/ylxAvdKmR/UeaRKJwTQxc26r2V42qT7o+66eD/+G7NL1SUEq9bXJQ8r3+VO2hPWp0ds38vDINKRJcSPp9J+Uid4ERCkXEAXa7yZekciGbPcBXjSW8nSwzPlrTfjqHrddCOfUSLKaE9TW9ddLjT40TOVmUvJgRbUU/6h/gDJu nCjEZuQW 1CsAZeUkA6MNe6vHlMQUqCegUE9DOWUrfS9vKVxva61NwJzrn6TQ9HMwDl83dD0vxbWqphgRWJpOYBHSbOJfjlne26SNhAC0e3gECFgE9zfia//2SV0OlXtGlV8Vlf969NyZG X-Bogosity: Ham, tests=bogofilter, spamicity=0.001221, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Baoquan He, This static checker warning is related to yesterdays, but more straight forward to analyze. The patch ae5dfc510155: "mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo" from Jan 13, 2023, leads to the following Smatch static checker warning: mm/vmalloc.c:4244 s_show() error: we previously assumed 'v' could be null (see line 4241) mm/vmalloc.c 4226 static int s_show(struct seq_file *m, void *p) 4227 { 4228 struct vmap_area *va; 4229 struct vm_struct *v; 4230 4231 va = list_entry(p, struct vmap_area, list); 4232 4233 if (!va->vm && (va->flags & VMAP_RAM)) { ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ Assume va->vm is NULL but the VMAP_RAM flag is not set. 4234 seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n", 4235 (void *)va->va_start, (void *)va->va_end, 4236 va->va_end - va->va_start); 4237 4238 goto final; 4239 } 4240 4241 v = va->vm; ^^^^^^^^^^ Assignment 4242 4243 seq_printf(m, "0x%pK-0x%pK %7ld", --> 4244 v->addr, v->addr + v->size, v->size); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Dead. 4245 4246 if (v->caller) 4247 seq_printf(m, " %pS", v->caller); 4248 regards, dan carpenter