From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650A0C3DA78 for ; Tue, 17 Jan 2023 15:25:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE9066B0078; Tue, 17 Jan 2023 10:25:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B98CC6B007B; Tue, 17 Jan 2023 10:25:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A887B6B007D; Tue, 17 Jan 2023 10:25:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9188B6B0078 for ; Tue, 17 Jan 2023 10:25:51 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 68E131A040A for ; Tue, 17 Jan 2023 15:25:51 +0000 (UTC) X-FDA: 80364666102.11.8B257F0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id B977220019 for ; Tue, 17 Jan 2023 15:25:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="aE/49OXp"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673969149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4A2lQI6oPlYBll6FagjI+6K6oYf8bDJMQjbWKre5gTs=; b=KJtYgxKzcDGfdF1/hi+2wetW8is6m3UWVqN3hffRo4e6Rg3dGL5DRJoO8/cBeLbIGeFt7x FMWFOXmHMcvor+LE/jzfSJ56wiMYwaeixaXbL3DtwJzkgts0bJ0eh3zJwayW6ktcMvLV7g GQZpMuxsl5PUvxCy5U/TVKsUN+7VQ1Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="aE/49OXp"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673969150; a=rsa-sha256; cv=none; b=XycqWyl2DOBj7Gl2QhIOkz80RbEO9Nrj99pD8DgjMJ3zlCDSnmSrHb0xzYsUS0OV27ksP8 qTKIa+s40kykSkFa9elKbgSDPJL63mvRMtoeo/gCjX/BpAoKBYtY49aPs9ht9UgK6F46jj 2aacxdsuve2iisvWWB5Hmfw5MoC/4cI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5542B68958; Tue, 17 Jan 2023 15:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673969148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4A2lQI6oPlYBll6FagjI+6K6oYf8bDJMQjbWKre5gTs=; b=aE/49OXp41VQnDrTt6SKcz5FlXnNqrOPUHyWOX1H3m/FJBp55zLq74suwTWgIwxhBKHxAG KyFsmq6H+sy7YptkgzmYBAWOTsBTYf9Ws1usg6QIQiMdr0Qqs2H0yBiw6g+RMPDVjGGh9j IXQlzjpu2YyY8kbttGAm+gcJNvI0dsQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2BCD51390C; Tue, 17 Jan 2023 15:25:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /zdYCvy9xmNkSwAAMHmgww (envelope-from ); Tue, 17 Jan 2023 15:25:48 +0000 Date: Tue, 17 Jan 2023 16:25:47 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 18/41] mm/khugepaged: write-lock VMA while collapsing a huge page Message-ID: References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-19-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109205336.3665937-19-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B977220019 X-Stat-Signature: q1a61adarm9cbfxm9fgt1mpzbs8pzo4r X-HE-Tag: 1673969149-446479 X-HE-Meta: U2FsdGVkX19woSHMGJoWk7AO5M82A58E+YUoUYW0hOdHffA0OIr2SlEy7TXZspNvpzpBtagJdAy9t2AQXS21MQ5zidbWzyCUNN+MCYXC5M0WABwNVecXcGPSPrfwVyF4sUTNoktpbSBdA2VsmVPC99v2TwoXacklan3We+iBC5zsMCbln18G1th5hpqrRPjQPNKUeXKAo3t/Wj9CE5CytdnAbzqqY747Dty4xB2phezr3UrVQTckceMvx/K54VlthIUseDfxtqHcKPAYWfgkgPZJp7gcHcMaRDhjCjgQ8ZHfavMZKohhU95CNjWXDDG37utGTS/ezx3EvWCquw+hs5UV82j+KLzfONbbQTgbKHZrtlGJBQqRbUAm6CnsrRIBIlKIyhVushJVpu5sOwZ6FB20dLNI5tF9q73uYOTUco/7az+GAlABXCURuXqoSsc0NNj+6jq0E36NSnu8UlkBWjQwIotW2+JuRs1KpPLl9w6/hz8saSMf5ezDtTRgxGkMhsxRp7/uWK4ZUP9Fb/l0sE36LFp5gh3fD6jlk4/0mb1EkE35mZEVlZMLInZtXSX8F6eTvazxjXy2f71xAo1eU/cqIJXj020oKdtFGSfMScST51OpEBGDGVUhegLEoCVUsdTtfrjDZShO96cYmCWjUWAzh1Ob6XAlGfrt2WhrUkKAGJQJg8oxSSaI8e4p/sDhBeaL6EMYuFQ3hKt68K3H7A8PTLFlRHRFTGLwdCj9PZ0ht9yG58kBQvaZbfk0/Ej7xSJb3m1wYcZL02q+pFQvLIKhb2eQxt34Lj8GdcSRh4W40oS1k3ovCOGzfgBsWBoDGYDP7wETeGvJJJnQ0X2IC4vPYI82S57TRT742glWB87gUqcUggz/UQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002357, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 09-01-23 12:53:13, Suren Baghdasaryan wrote: > Protect VMA from concurrent page fault handler while collapsing a huge > page. Page fault handler needs a stable PMD to use PTL and relies on > per-VMA lock to prevent concurrent PMD changes. pmdp_collapse_flush(), > set_huge_pmd() and collapse_and_free_pmd() can modify a PMD, which will > not be detected by a page fault handler without proper locking. I am struggling with this changelog. Maybe because my recollection of the THP collapsing subtleties is weak. But aren't you just trying to say that the current #PF handling and THP collapsing need to be mutually exclusive currently so in order to keep that assumption you have mark the vma write locked? Also it is not really clear to me how that handles other vmas which can share the same thp? -- Michal Hocko SUSE Labs