From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D85BC3DA78 for ; Tue, 17 Jan 2023 15:07:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 012C76B007B; Tue, 17 Jan 2023 10:07:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F03A86B007D; Tue, 17 Jan 2023 10:07:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCBF36B007E; Tue, 17 Jan 2023 10:07:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CEFC96B007B for ; Tue, 17 Jan 2023 10:07:05 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 88CD28035B for ; Tue, 17 Jan 2023 15:07:05 +0000 (UTC) X-FDA: 80364618810.04.8A8C66D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf19.hostedemail.com (Postfix) with ESMTP id C44FB1A0009 for ; Tue, 17 Jan 2023 15:07:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cu4sHORQ; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673968024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6V2VZScsK1ZinrFEkqeTShIOGmI+xaJW7bwy0e3iVQY=; b=7nR1RBPQGxT+ZYUr68ZBRNIyV7s4XJLzyoEw2V+zaahriNVfSq/yinK8dd84mweenY4zlE szYCKJuHYFL3emfCG95h7/CZk0edhjMOUB+vdksDbVb2ugdlbhs15Xyl84/4J9pwPRa2S7 uRvGKAYWreXbynzcoRsHz8vZ4wrOUmE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=cu4sHORQ; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673968024; a=rsa-sha256; cv=none; b=VfNZCnDUqEEhdSSMpajJV2O4NclYFjWkkqsWvbq/fL/CDqqqvn5pxliMXODT/8pHj4Z3li hS7eQLxuBTHjTCPqsB6NmjagQmdUucFu/SDUsU+9ZaihSGhRQHc+pZ5tbqjbDfgayczK1L N195tdCHBDQXvwGCzoUO/YJNePSmXpQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 471FF387B0; Tue, 17 Jan 2023 15:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673968022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6V2VZScsK1ZinrFEkqeTShIOGmI+xaJW7bwy0e3iVQY=; b=cu4sHORQXjae9Ocu+lNNPo3B8A8fwUGA+VendakuJSRO/eyKhJlFGYg7kizcQyieCvMQKz 38OljQbTlXpq9rWbtxC5hv0r+dOHwobThPzg7YhhnfcZpM/ZKBHfejYRDWJkMH48o3cKue jQuECbg6F9zy5e35mX4Zd4yCM0dwbvQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1396B1390C; Tue, 17 Jan 2023 15:07:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id V/U+BJa5xmNuQAAAMHmgww (envelope-from ); Tue, 17 Jan 2023 15:07:02 +0000 Date: Tue, 17 Jan 2023 16:07:01 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 12/41] mm: add per-VMA lock and helper functions to control it Message-ID: References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-13-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109205336.3665937-13-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C44FB1A0009 X-Stat-Signature: qa85mrieeh7n1kbaghtbxdsdeoionszj X-HE-Tag: 1673968023-379048 X-HE-Meta: U2FsdGVkX1+Mymg29vEWZ6ySPllA13Ncjr9qPd6gXhmFgm+dTBUpDsa/q/ecIEj3af6+gvmvqU4JrKb2syvY6TWUMKPNurkN75CgdH2OJB1DkjM/Y2fXcnE0PLZiwcqWKwa4fljFlSGTBnKtKSkB0oZcKngmxut0GxyDKZBIC1/Di5v0wukYpqGsYDamElGr3TzScG/p6zJCeLhwnu3yWUma2BAvh0nhfZjZWHZdt6pRtR2wlCPzpjPyR285TDShShVEbMksHW0B6oKBjHpXjiE6MNOf8VEgD5a2JU4NmXvTCUtxr+VSxfkL98OBmyg6Z+qhQZKnnb+PWI9dGlsXYlgUWOCAZlDUa0EamS/bg8L9rhn76Pvw+MhQwwIl+wYr230ZunU2fgGkHKS0jvFY9yKi1fOZadO70+QfjHPAV141+FX28oOhOiZj44/GaJp7AcyIpjjwxRupCRDMYGUDhYoieyutSTQu50JU7aqBbEKK7WNq8dNN9kPCB4yeAqO/UnWdnEIOC27YS5Mzq+sOn7ZFDIMSc0G2qeJXJSX9RwPe+c7NQgojBV6wATGsmCoUHzAQxStEDokQFc4xrUfJfw6hGESgTJH0L2C4WNFDKn5wO2rxIjiP3LsLOFcMsQIwg487whzVEyIkGw48JofheDvJD8D19vcHnaNxdAiE54aqVXcSEE30fjE8H4XWB/fY6zrwfUWzJIQvqL1N7oNQpVoCqZjtJMC8Jrf+dsuRvB+Xg0nyWjLqV6McUuzKYow/8BfbZxd+rwPEOHQeu/ERtwQNwvUOn0DfoGcEELdHw5hcNER9bHj12hkMWyoSqryDLhJxylA53j90QD9fMvcJS4IvgrzzQv67Se5VTIdxY15VSE43Ow1Ssg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 09-01-23 12:53:07, Suren Baghdasaryan wrote: > diff --git a/kernel/fork.c b/kernel/fork.c > index 5986817f393c..c026d75108b3 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -474,6 +474,7 @@ struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) > */ > *new = data_race(*orig); > INIT_LIST_HEAD(&new->anon_vma_chain); > + vma_init_lock(new); > dup_anon_vma_name(orig, new); > } > return new; > @@ -1145,6 +1146,9 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p, > seqcount_init(&mm->write_protect_seq); > mmap_init_lock(mm); > INIT_LIST_HEAD(&mm->mmlist); > +#ifdef CONFIG_PER_VMA_LOCK > + WRITE_ONCE(mm->mm_lock_seq, 0); > +#endif The mm shouldn't be visible so why WRITE_ONCE? -- Michal Hocko SUSE Labs