From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70176C3DA78 for ; Tue, 17 Jan 2023 08:02:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0175B6B0071; Tue, 17 Jan 2023 03:02:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE2756B0073; Tue, 17 Jan 2023 03:02:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D835F6B0074; Tue, 17 Jan 2023 03:02:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C48DA6B0071 for ; Tue, 17 Jan 2023 03:02:09 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5AEF61607CC for ; Tue, 17 Jan 2023 08:02:09 +0000 (UTC) X-FDA: 80363547978.18.F164838 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id E0DFA4001E for ; Tue, 17 Jan 2023 08:02:07 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KLeqLLx0; spf=none (imf01.hostedemail.com: domain of BATV+f2d96d9b1cff2e22bd40+7086+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f2d96d9b1cff2e22bd40+7086+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673942527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cmVV6xRQmaK0l4HRL/lhH4XySz+BO5RzfEmX6d+cJZM=; b=sWdApjWwlBswgYg9te0qFMYJc3dV+00GzQ6g22xvcPh3WovdmbKEfbNaNWNf4HGtUBWCyG b+8FPKtM+0GNB/iEouC6wDBsID5dYzFtfF6kspoeeeKio8JLCyBnU49B26MiuKkBr+v6Vb x98Gaz07jnOL+76jXQBYcKJYiS2j5O8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KLeqLLx0; spf=none (imf01.hostedemail.com: domain of BATV+f2d96d9b1cff2e22bd40+7086+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f2d96d9b1cff2e22bd40+7086+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673942528; a=rsa-sha256; cv=none; b=JQxffUZSctWlxmsA+AtmMNH3wUbdQm2/kJHM7SQeXCASLdzFOCgEIk+m27JDBbNXe4FDfO 4vHyEYMeVp0XtMBFxwyTMcuKBtAfKunknnTp+ithLUpEqge4IvUo/YBoMJKfM5A6BCHfUz rBL2ErC0SeVU95x0CByhkHY+TTwK7V0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cmVV6xRQmaK0l4HRL/lhH4XySz+BO5RzfEmX6d+cJZM=; b=KLeqLLx0NC+cXLbPhHSUJXvm/7 R/nl/8FixpSCZgHfNJHIPElbnFHiIR85J0mANjkPduyvsnh1TOci2q3m71cXS3BTbn0rB7Cz89ZKR QJAkNO6pNAybiWH/mXlGOEdMFq76IoX3V3FwiGVTg4NHWsFd/mnXxJ25MuAMbuJ7LQ+p227fBxOR3 Un7EcKwFO+MI7nMp+e4NwGZ0ykdgaaqkKmYEVm7lp8JJsaj7uZsVdxh3ZYbuzZKlGAOlGi3wAv6H9 sZsf0ybxabL89GqyzG8JI9EW8On10C7w0tMsJWtBI0gBakel51gCmn+QjxRoDvc2+FTWOhTth9ZBN b7LOBerA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHgut-00DGYh-Be; Tue, 17 Jan 2023 08:01:59 +0000 Date: Tue, 17 Jan 2023 00:01:59 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 07/34] iov_iter: Add a function to extract a page list from an iterator Message-ID: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391053207.2311931.16398133457201442907.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167391053207.2311931.16398133457201442907.stgit@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E0DFA4001E X-Stat-Signature: gde6b4yy6zqt9p9zduimoeuaaadxnfzp X-HE-Tag: 1673942527-318360 X-HE-Meta: U2FsdGVkX1/0BwBC+HOPXYSXcGlcA+7JKXTo87mctdeOu2KbZ7xgP87IOVFa7DSZu9+DgE42FEyk4pmvaCMfR7M5/9ii8OZ7q/7j+A92eXI8dUvAPYowU0fQQzQaT2IbIUrNxjlIKS4E2cx4DJRAhregJ+4Var4Vj7STHFGfWWqH5Xks1WE3Zf7G01eACVF4pLH14TScNJGsFFAiUwnyk7hWxO89lt2QQ9H6W7aatxpLCkZ/iPvzZYr5SXvoLO5efdSJGT9J4/tiRbMu2JLvEWxD0PHc0UuqchSOSQ0lPIBlPWSIYlBO6kh47nIDJUePMcTK6wzxHvrqrQHP3DvHI6/qZXG58vIocaLGKoJfi3amN+S6bRpevQbNRhHdpsHwRGxFth2ocg8MENv3n8ohtdaKUaTAf0HD6kRXU0xS4SQfuQyq/sw6sHOYCTzSWhPqBZl7ufFOdRveJyPmla64SbDHjw7n+lAdG6T1XQcvaiMykiS2fe8jHoJJEIvwDHHaloXEmt6HJ+8iGXqx1NW7E8rAHOZm/a3DbsOkoga02C7ueJLsTPAFc1E6VCvTtoZmHH49Qw59JwFDSPCqvh3Z66fPgrAPFUmO5z/GS3mDJ2yv66rzHZj7f3FsHBj7cpbITl/Gs4lcZiS7nf8U8h9/Yi7nkXZBg+r1U8/B3EOkly+SC2zRXbP9F1n+ycJP+bCVHe1X7sezSyIicIzU6P6sjkVbXTGU6wnvU7clkuvRktR18bYiAC10E69AHleP9NGQI6BnNfEqq7l3zBGyrG9yCSs1avoy1ESqwUJ9mwNjkL0wOmA9IGgGHSgxkjGenZ6iIkcXim9JdpDde9GAs2mVGBELkzf+m1uwSdlyPZOfqpoBb4Ue22QfPdPy0ubHuLnf46+mGqNwcdEtJPqzcxLaq5CTnehPIB+6wfLCeYWbEsVnId1TRaLDjUem/42Q8cNuuZTtzUNtfAXmW5eHdnX UuKIYqY/ 04pHax3YnGshx484u+M8a0F6j3hHML0po9xAZgwHC3IlAhLQLcxzK3WUcCKhjz2+a9a3Wgoo9W4LrqkFEZ+gtHxjPcKsNIrj3K1fWHcehB4Nawh+Qtan3Xd4X0Ef7Oi0rd7COeMdhyliVx2mkkIeAXSYzA3Ls+lGn2YhR6rWNp2TkKZg63b8pyEHA/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Changes: > ======== > ver #6) > - Add back the function to indicate the cleanup mode. > - Drop the cleanup_mode return arg to iov_iter_extract_pages(). > - Pass FOLL_SOURCE/DEST_BUF in gup_flags. Check this against the iter > data_source. FYI, the changelog goes after the --- so that it doesn't get added to the git history. > Link: https://lore.kernel.org/r/166732025748.3186319.8314014902727092626.stgit@warthog.procyon.org.uk/ # rfc > Link: https://lore.kernel.org/r/166869689451.3723671.18242195992447653092.stgit@warthog.procyon.org.uk/ # rfc > Link: https://lore.kernel.org/r/166920903885.1461876.692029808682876184.stgit@warthog.procyon.org.uk/ # v2 > Link: https://lore.kernel.org/r/166997421646.9475.14837976344157464997.stgit@warthog.procyon.org.uk/ # v3 > Link: https://lore.kernel.org/r/167305163883.1521586.10777155475378874823.stgit@warthog.procyon.org.uk/ # v4 > Link: https://lore.kernel.org/r/167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk/ # v5 And all these links aren't exactly useful. This fairly trivial commit is going to look like a hot mess in git. > +ssize_t iov_iter_extract_pages(struct iov_iter *i, struct page ***pages, > + size_t maxsize, unsigned int maxpages, > + unsigned int gup_flags, size_t *offset0); This function isn't actually added in the current patch. > +#define iov_iter_extract_mode(iter, gup_flags) \ > + (user_backed_iter(iter) ? \ > + (gup_flags & FOLL_BUF_MASK) == FOLL_SOURCE_BUF ? \ > + FOLL_GET : FOLL_PIN : 0) And inline function would be nice here. I guess that would require moving the FULL flags into mm_types.h, though.