From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934CDC67871 for ; Mon, 16 Jan 2023 15:21:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E2AC6B0071; Mon, 16 Jan 2023 10:21:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 093E96B0072; Mon, 16 Jan 2023 10:21:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC4466B0073; Mon, 16 Jan 2023 10:21:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF74B6B0071 for ; Mon, 16 Jan 2023 10:21:44 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B0DCE120598 for ; Mon, 16 Jan 2023 15:21:44 +0000 (UTC) X-FDA: 80361026928.22.A3A0DD9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id A9CA4140018 for ; Mon, 16 Jan 2023 15:21:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Gi32vGR1; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673882502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=exGsL8noNQoZg92JSR3cmEJBbPzlcRdapH/BV8PgOLY=; b=3QK4ThUxzWZvC6PbPX19eep5umi1JqpuekzXb2TQ0Idhi68ZQqjebiooargrz3M3/dpq66 3XdFJWkxaRyTdgIAhbYND5Hu8YkfUzUHh1SSld/TjymPmIjpDT0fqYG44Gh7UbovBSl0lF NhR52AwjBbU6PFEsfbuNudPL8Iw4LRM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Gi32vGR1; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673882502; a=rsa-sha256; cv=none; b=5lOJlP6v/I8Cwu8OFi9WntSrDgCr8wZc4TYED/fZGVxDYVqMo5IiIpaX4YvUDCcEbiThRT q0cJON6slQyFAxO3PWdQFAbgymeCdvDjHjQaT/VpqojG2A3Wtvt1zj2w8DUNC/X2gIbrPC m3lUqVwEu6CVnfxDpfAQCQHCWnNCR24= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=exGsL8noNQoZg92JSR3cmEJBbPzlcRdapH/BV8PgOLY=; b=Gi32vGR1v3HMHKVuZ/8Vsm52db u5ZGCNmR+/gY61U5R+iQgIVnwWeU0AeqLWEhRX7gxH399ps+kAA1NJb6v89/yeDGcSsSWjG/21DHk Rh0GcFuuCCMv3Re3DtwmHb+ioA2Tvi/yZrvupH0YNbIDLqifnO/EUYHxPfykHf4fVFEuSFfuMriMu IRbSxkO18HiA1mNrYWYUE17CIuA7u0/FoaQYxAdNx+Px8hfGK6U2/Dgka+M+dVOgD3GYojhstgx67 7htBvc9FMXx5JDlBIDww/MEjHCLk0W7sMHeLgTYSEMLQBjUvp29koYFnwNRvFahlyCIvGh+9gxf/u NFfCMctg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHRIq-008qSL-UP; Mon, 16 Jan 2023 15:21:40 +0000 Date: Mon, 16 Jan 2023 15:21:40 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: =?utf-8?B?0JXQutCw0YLQtdGA0LjQvdCwINCV0YHQuNC90LA=?= , Mike Kravetz , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH mm] mm: hugetlb: Add checks for NULL for vma returned from find_vma. find_vma may return NULL, that's why its return value is usually checked for NULL. Message-ID: References: <20230116100520.71277-1-eesina@astralinux.ru> <6f5ac7ee-0af3-a466-cf7f-b17270bc1391@redhat.com> <182575210.374192581.1673881818398.JavaMail.zimbra@astralinux.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A9CA4140018 X-Rspam-User: X-Stat-Signature: ahw33ha39kcjp8zhtmq5fb8nks9smawg X-HE-Tag: 1673882501-414183 X-HE-Meta: U2FsdGVkX1/TYHxj/57hOotfEraJyzK03CFvXvTbAkgS/wjq30N6XB/k1jV4meT0MSPPMy2RGLhs5jL9Qr9GIk/MUf4/4pXdC/PcTpVVOG2jzU3LlHQdQ+08XpodAKnoYc849L/OwlEyyh+BoMIck3+wCQBBh5g57xD4YaFED+KQeiBJOUm5xWqSSACpsv5l6NFnvtkR4MDAN/f+ckg38QoHPkXvAr/yjZP+MA4i/8pY0oUo+AXiM8sCXRIt6DTvefcL0jjK6lH9BF4mGTk0UADsHWb9mktjH7B+ErQyqBWdJCLAT7O99jUaQ72fK5X8TSpV/HPf613cKfpkGsSLKxE/uzYjtzPQUipKs1axcA78joj2p/L56Wf+JUzyq+xLLM16RxxakZwBx37mjiT879xuMgApbG1f8hmwp46vu0jhsf3CZilt9pY4r6stnaukGu5Ga88iZhutatmUcelh/wOvrj28AB+qlLHbp0lyoeXoumlaaL6G0BeVjiPGr3R/pH2pO69rghJgSSUzoOM1ehtztCi2cdcVcRPufVJ61aCfR0mDqmDforclq61cCg/cv0DTA7Z7WeEQT3a92Jp8ep+MIRUmOn76ZcPF5+AHBMNztFYBZU7J44Zhx7akzva4Bax2m9p9okE5DR8NadNxs3JWxp6G4VYjcXg5cR75sTzGUUkx2b3gitrIeT0zHLW619MfbQTVPTyG5mfe+RznF4wnkdHu4anW1rDjRDfspXYamPJX1WsfCxSiyX9xSmhS6VZn0GxA2+opR9PyyJNu404PdMemu/qqbgvRlhuEcQs4JApOBzOg9zBCsXFz8t8KVtAun3YYyOEbtDc5nEN70Frpyi6ER1CNKdoRlt+zKHZvd3NXHb5QBDHCN6+bd95cKyOAg0mNTQhv5kAex+D+kQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 16, 2023 at 04:12:48PM +0100, David Hildenbrand wrote: > On 16.01.23 16:10, Екатерина Есина wrote: > > Sorry, I've noticed that I'd sent the patch without description and sent > > version 2. > > Function find_vma may return NULL, that's why its return value is > > usually checked for NULL. In this case vma and its fields also should be > > checked before dereferencing to avoid NULL pointer dereference > > Thanks, but again > > What are the symptoms? How exactly does this BUG manifest? > > For example, does the kernel crash, and if so, how can it be triggered? SVACE is a static analyser. It's not very good, but the people who run it are extremely persistent about submitting patches based solely on the output of the tool and doing no human checks of their own. Probably best to just ignore them, or NACK them.