From: Matthew Wilcox <willy@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: "Екатерина Есина" <eesina@astralinux.ru>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH mm] mm: hugetlb: Add checks for NULL for vma returned from find_vma. find_vma may return NULL, that's why its return value is usually checked for NULL.
Date: Mon, 16 Jan 2023 15:21:40 +0000 [thread overview]
Message-ID: <Y8VrhNe/g6OGMEUg@casper.infradead.org> (raw)
In-Reply-To: <a402b90d-372e-2774-d2c4-ceae64c6eed2@redhat.com>
On Mon, Jan 16, 2023 at 04:12:48PM +0100, David Hildenbrand wrote:
> On 16.01.23 16:10, Екатерина Есина wrote:
> > Sorry, I've noticed that I'd sent the patch without description and sent
> > version 2.
> > Function find_vma may return NULL, that's why its return value is
> > usually checked for NULL. In this case vma and its fields also should be
> > checked before dereferencing to avoid NULL pointer dereference
>
> Thanks, but again
>
> What are the symptoms? How exactly does this BUG manifest?
>
> For example, does the kernel crash, and if so, how can it be triggered?
SVACE is a static analyser. It's not very good, but the people who run
it are extremely persistent about submitting patches based solely on the
output of the tool and doing no human checks of their own. Probably best
to just ignore them, or NACK them.
prev parent reply other threads:[~2023-01-16 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230116100520.71277-1-eesina@astralinux.ru>
2023-01-16 13:24 ` David Hildenbrand
2023-01-16 15:05 ` Екатерина Есина
2023-01-16 15:10 ` Екатерина Есина
2023-01-16 15:12 ` David Hildenbrand
2023-01-16 15:21 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8VrhNe/g6OGMEUg@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=eesina@astralinux.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lvc-project@linuxtesting.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox