From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A0CEC46467 for ; Mon, 16 Jan 2023 12:25:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6076B0073; Mon, 16 Jan 2023 07:25:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B77916B0074; Mon, 16 Jan 2023 07:25:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3E6B6B0075; Mon, 16 Jan 2023 07:25:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 92D106B0073 for ; Mon, 16 Jan 2023 07:25:39 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 69CEFAABB3 for ; Mon, 16 Jan 2023 12:25:39 +0000 (UTC) X-FDA: 80360583198.12.33CB20D Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf21.hostedemail.com (Postfix) with ESMTP id B1EBC1C0006 for ; Mon, 16 Jan 2023 12:25:37 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IqYM1jiT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673871937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=78CL3LWL83HHKF6wLYJClbi8NT0HkDMD/Ek4ymXzJIg=; b=7J5TGyHhAZME/ELuUtOI2mrSWzkgqLa2B8LsGQzPwScRanlm47DoBDE2vy7jcp8eXCeiCx wFZ2dfhh/VhTwZpMEcx1DdDauUm0jeyoDLOZ5uWGSJUn4Qs7h8KmJC9rvkeSPI5p3VkRky bxDbRJ55xssM6eitk5VMQ5VvvOaqTlg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IqYM1jiT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673871937; a=rsa-sha256; cv=none; b=3FddZpv2BmZS8Zee9Nn57P7URHgG6cH8d9VB5F3iJSJMvvMWUSN2Xdg120mDrnGfE1foYc EZkGhJNu4Xs8QfegCdLv5AehH2MlvGLLJ+UWZYE2xjAuM+1VecTqOw8K9VoLn22EBTfa/Z pjqiS3MUUOv+Uv0l4w3AJAsb9pFs/o4= Received: by mail-wm1-f43.google.com with SMTP id q8so8070575wmo.5 for ; Mon, 16 Jan 2023 04:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=78CL3LWL83HHKF6wLYJClbi8NT0HkDMD/Ek4ymXzJIg=; b=IqYM1jiTUL5AnFVQlIpoojz22xgayX9CtUsl0KVhhouiydPda1UwSROGQeC98oVqmN xp96SXIRxjDYDBm29PvpwJv4YL6ngjmUQw9A1gAgadI4kj5B5iJoSseqm9dR7i5eoN7z jgqyvW6QuUGrBNCx/HfyoAXT6cQpOWjHT8nwXfqbcJugnCFJlBwkL6niR3RG9lYPTw4n J39teE7Gb2MMZFGv23sDVuw5MguHj212cKdnILd7XoeibLcDOb3SoBU2HnlFO1DOvWg0 Ixx3cBn7YCdTt9mZ1UN5/HB1Rm4KcX1shkKLO0UywAfzVZ7ZiBTj4gbvzQlpazcSUONK ty/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=78CL3LWL83HHKF6wLYJClbi8NT0HkDMD/Ek4ymXzJIg=; b=r4Q7hqTAsqRbNslNjCzcf69ipeU7iKzkQ8EwZKULaljhUt1RBPqcT0HCfqLNOCFoeP NU/05BgHieYrjH4rxJtmCeBzERyWYRBMutH9NinC13d9oJtWpk0xagiIuoKsyiipZMO+ TJ2w9Ko+/l0npeowgtXkK8kA0CXVip1d//1Vm6v4j0mJWbe/4HiC5mxO7jnZBAjXbV9u 7UetUdOZQX/VTNggKoXV8BP01pi9qbc6pLtZoyIKeKD3lINjeIP7Le8t6g5AIet4li0N 88J1JG3hP7c2NkHD/3df4wpoRp45ceOaK1RHDGwtSvQDAEZcb+PhxeReDECW5SCQEisg kH3A== X-Gm-Message-State: AFqh2krQTceIVcauAd8b527DCgzyXEkLaUWp6+gLw+jkcf1A7xW2JZ3W LY2iYYAxQ0v/3QsDhQqHuqA= X-Google-Smtp-Source: AMrXdXuhQCHMybxA7IaNtXAkTkJClREo5tX/oNRXgoytBfYOC+1mCZy2Sug8ZKxjud/VDk1YQYPKHg== X-Received: by 2002:a05:600c:3d0e:b0:3d3:4aa6:4fd0 with SMTP id bh14-20020a05600c3d0e00b003d34aa64fd0mr67703880wmb.6.1673871936407; Mon, 16 Jan 2023 04:25:36 -0800 (PST) Received: from localhost (host86-164-169-89.range86-164.btcentralplus.com. [86.164.169.89]) by smtp.gmail.com with ESMTPSA id g12-20020a05600c310c00b003c70191f267sm41602277wmo.39.2023.01.16.04.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 04:25:35 -0800 (PST) Date: Mon, 16 Jan 2023 12:25:35 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 7/7] sh: mm: set VM_IOREMAP flag to the vmalloc area Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-8-bhe@redhat.com> X-Rspamd-Queue-Id: B1EBC1C0006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: bzkcajjt5ntqzhkmafqizgbraxq5qbwh X-HE-Tag: 1673871937-786142 X-HE-Meta: U2FsdGVkX1/UrtcK785fHij0VxwhNL6QB/Bv5MULaYL1tAoWeIcdoDt1cy3cfM6HXGFw9S3snlzrW2gRuOA9HxNz7nq7Vo3TtXpelv1IfoWMQKi0nFRqz8a8NzIipUBCG85O+yrZqAhIAC6PCYj7+PAZbAQAXHitVgtNy/ERCqUT/un7pcH/IRzXQ+Ocb9eQeqVeL/iRdkJOHFXupt2f7Mw8kGzBS6crBGLkkPKl7ogf0JbJ+Es55dGtZYfOEf+vkxBg9aUE9YqjuLXRd26imNXpJmF3iWRPsAoTh+Yq1Lk462GThod2ksPG/4lca2ckQZOGC7mR85qRxcHuuff7GzzIr5iCqMMnFW52FXcmSB3zej8YibzBgO5iQpDEd2OsIuwkgzQNMELVz0xfN1+crlRFiSnK+u5x6cytLro+DVF4vk4Y2RtcN+ba4EKbjeTOXWObo7IYsH/jo8uzOOBt76zPtSWWwpVWbZnPaR9R4lRmUr/6N8XgTrecOchlm+muq9/pSEncLG2TkjD3lO6U9fzfRa1nXe0EbIslQrkybAAbxxXaXcYYM4EYDbR1JqhIQ76PfGfg/1GlX46KaS8jMwHICjYzgUqnKGOxybq/Oavv/jXYzbXR0D8Alp60JCTAoeJaYjVE1S2wOte1rrmIUZ8sZcm90QaqJSyW4Xg/yYXEUGA9Qri+2ppmMDZ72CUlP+3c2ffD/lEd/wFT8fGxjgqXy0yuxrz3QdF/IP5qCIoqXovwTlUID2n4k+17sTUk7l0wGoYQDeqkKy69FxSh+UalbY9tE9AOjTRfLz3mnkrQ0AZTc1ykqdFtz7BFkOtg6oy0B16m6ZSxYLCYK7DMGjOlqFc42ZKcMvdML1/ONdOp7vwvsu6c5r+DvOQ4GEbHpeBeeZlTl8MAQUlKtFEuO8U2WNDfAAht+1LXnBhDsWSn25aRM1ISpGGxLmQmikkSc7C7gA33diH6OlXslqm /6D2bj+B K0HMZKxI2kcFVkkD9J8U+KkYFNNQ4akRMSA9DwRN7SAPRNtgNZ4hJFUne5qAi5r+av+uPZ7i13lwmlbCwEWpcTL3WHDfzo+LloquYKwPTrjxNEUy7C+nghOFSTS85WVF68trpWCfL+UO0cdA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:21AM +0800, Baoquan He wrote: > Currently, for vmalloc areas with flag VM_IOREMAP set, except of the > specific alignment clamping in __get_vm_area_node(), they will be > 1) Shown as ioremap in /proc/vmallocinfo; > 2) Ignored by /proc/kcore reading via vread() > > So for the ioremap in __sq_remap() of sh, we should set VM_IOREMAP > in flag to make it handled correctly as above. > > Signed-off-by: Baoquan He > --- > arch/sh/kernel/cpu/sh4/sq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c > index a76b94e41e91..27f2e3da5aa2 100644 > --- a/arch/sh/kernel/cpu/sh4/sq.c > +++ b/arch/sh/kernel/cpu/sh4/sq.c > @@ -103,7 +103,7 @@ static int __sq_remap(struct sq_mapping *map, pgprot_t prot) > #if defined(CONFIG_MMU) > struct vm_struct *vma; > > - vma = __get_vm_area_caller(map->size, VM_ALLOC, map->sq_addr, > + vma = __get_vm_area_caller(map->size, VM_IOREMAP, map->sq_addr, > SQ_ADDRMAX, __builtin_return_address(0)); > if (!vma) > return -ENOMEM; > -- > 2.34.1 > Reviewed-by: Lorenzo Stoakes