From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A02C46467 for ; Mon, 16 Jan 2023 12:22:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 895D66B0071; Mon, 16 Jan 2023 07:22:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 844836B0072; Mon, 16 Jan 2023 07:22:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7342B6B0073; Mon, 16 Jan 2023 07:22:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 62DEC6B0071 for ; Mon, 16 Jan 2023 07:22:15 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2C6711606DF for ; Mon, 16 Jan 2023 12:22:15 +0000 (UTC) X-FDA: 80360574630.30.79ECD1C Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf01.hostedemail.com (Postfix) with ESMTP id EEA334001A for ; Mon, 16 Jan 2023 12:22:11 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gbgrzGoa; spf=pass (imf01.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673871732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X4y5LfL78WILrtujXRb1FwmCXWCEQAtyVf2y66yO4ls=; b=r2th+PG5SaKGRwxv7CsxlC49YAapTl468F5y+W6bCu6dukguDzjklKVa90pczNrF3VjKlz Sh5q2Kp3WPzOrvZXcrKupStnlkVL3MIHuxyC6Rg+NxwxMlKxbK3dfYwUAaAbt62FTVvjSz rL9hkThIe9hnMGwOIQI4CdEQAg8jsT4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gbgrzGoa; spf=pass (imf01.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673871732; a=rsa-sha256; cv=none; b=DUqLurpRQRMfSv2GM7I0slHJ/HoA2wZBMb9yD7+23GkAkDSq5MT2BESnmPUq7O0hIu/5HU 2g2HSUid8sz51IEDbaLF2kLwMksTfIbFX/IGNAwhvUAbRkfraTfrHeJ/uJi30fOSYVoouD VkLduaLaN8nptgfirT+VFKEK/iHEzxc= Received: by mail-wr1-f52.google.com with SMTP id t5so22896836wrq.1 for ; Mon, 16 Jan 2023 04:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X4y5LfL78WILrtujXRb1FwmCXWCEQAtyVf2y66yO4ls=; b=gbgrzGoal61+t6N/z+/W7mH3d1FOqHh0KMupT9ZRsOL0zoa1zMYG7139GlDQVp3B20 2atwALu+o/Cm/xhCcaCJnPT0fkcRvp5weAFVcxSXjA29FRONI5hNGTlN0ji4pKR0pf7k BszUrDMuLtEngamytgUisdQCEBhOAYHXANfbwhcPOVvCiFtyQvQJwTw/IKo6yjn8bU8o x97Ip0swXjSvmqFFpmAfpf5C7BnyjOClzO1f65ZCjA1QV91/vIvNyroJoKk13fnoILT0 0G3zVb2x+cXZ0/scLBQNutZa4aneEc5aO79DzQeLP/a/O9Sv6oEb8KwCWOQQ5hL+LcKH XnRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X4y5LfL78WILrtujXRb1FwmCXWCEQAtyVf2y66yO4ls=; b=M68dVk4W/tHmXc47CfczQpJDrpeEpCpoQ7ccHVL7+HG4eBjB/OHVWHTBLHfcXpiMAD uxFKFnK9afG0HsNP/Qy+61QBAkSMrQbx7XjlDy9IyIRQq8AgOvccG75SITOYWJ4bjix3 i/Q8D61chOd02Lge2Nv7UDvPRKRXAkrXzrkGlTTe9tpVWQheSVyzgtXMyD0yp3FmLMD0 WrXbDJl4aQ+RDqM9l7X77WneNdaGwmsdJdzaYmiK35NY1EucfeMOA5fwmFMMLifddNpw C7vEbgf5BgOEyRfB2wCRc+VOQqXeIvM8GP2EJfAEunQcypvzVyGKwzsBcZZOLkaIb/4N BI3w== X-Gm-Message-State: AFqh2koO9quD1zBzh+zeXPCo9dzo9GVUsXdidjQz9jGZQ9ujTB4jfP3W +1r4pyvz+pMI9KTDTVh3s9I= X-Google-Smtp-Source: AMrXdXvocpZ1IQEaKW/83o0w0+L/+PqKFkAqKgsz4HoyqGIk216czdoHevJBevuSKf6ss998NdFhPA== X-Received: by 2002:a5d:4ace:0:b0:2bb:dca3:b29 with SMTP id y14-20020a5d4ace000000b002bbdca30b29mr21887657wrs.36.1673871730173; Mon, 16 Jan 2023 04:22:10 -0800 (PST) Received: from localhost (host86-164-169-89.range86-164.btcentralplus.com. [86.164.169.89]) by smtp.gmail.com with ESMTPSA id g2-20020a5d4882000000b00286ad197346sm26207750wrq.70.2023.01.16.04.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 04:22:09 -0800 (PST) Date: Mon, 16 Jan 2023 12:22:08 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 1/7] mm/vmalloc.c: add used_map into vmap_block to track space of vmap_block Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-2-bhe@redhat.com> X-Stat-Signature: 1n3y76expsp6uahfidbw1tq19znhhhux X-Rspam-User: X-Rspamd-Queue-Id: EEA334001A X-Rspamd-Server: rspam06 X-HE-Tag: 1673871731-741796 X-HE-Meta: U2FsdGVkX1820Q6mM5c1QE6JZPVt9vVvlXSHvJ947hTStcsb3CWq6aOLg6xIWBYGIlflx4iGEtAgmrBwFkPNq1jNx2tvb4KjUWt/8r69upC6dZjsHC1ovpgt/Pd6XIIMXCsDBPoSYISqo3zmjEfdib5iRLoEUOXXgkk00zy0FfyNhbUOy54O97lmM5vzowjahOPuv3PbUpRqOQokH4E1d/TMK4nNXHmN18IBTveBPpcocXduW5qALvG/yxM5tFbv0anWQZSENzPfWwjAhhmRdH/04IUS3122XAhpgfLvbB+i9UB7is78VBkZEhXVvixTz5qMuCaFZV3zzkjKObYt7Opo5EkvBnl3tFh1Fzjx7q0m68oCvAutAyDYZJ8w+qtPwYYJ7kftTcwvapfmcj/SwcL6pZNqbvePANTqvGIRfgCLOS1M/PkAYrTQU+gjoEQt0Wz01hqndUUF9nvbxZrT9zRe7vTpRyUwZJiAinq0omBjvDFviXTMc0zs410JecM6LX0mApFV0JcWqcjPpt19sCS5Ds5kEJzUkX5BX23W/we76F9Akt9bwhalAWL2RSfVdNKpIV+J/v/cAULOoLWVGr1bkXCIn195scjEx0eZ8otA4sS+DUEeo20QLUe5kGShJqW+LLRtjIZtnZOyuFg2vcJFcieNdCdx6eYUt7xJamA0YXraxGwqkmesEGo/8+iTBur3Pb5b/RUk3SoIVwdq+2XN5pX7sxgA/i8YR31op3fpiVXSp8ak7NwbGhP+mALhqqLy1Hu7RSnquIdPBnTEJaDuS/8KanCNr3ugQZrEognWEuM6kpZCkpG7sUiBF0idb1p2PCFX5TPJAPKAQUPapqUy+3l8j+TTyvxRh1ObbGM3/zqQZsLMGvOH0QLClK5MJ+4GTYZ0mKLpx7qOwAbAEklm0XSXd3anwwu+y5cyyn1k51Rv3q5uB2ircbult3zgmfckZju1SbPWUoFfIHt V7XqXsaF 3iEU/Y58CtoXJ7cc/3Aa6KidLh+Db0VYNlYomA/4TtFa9GdSWuIalprEacoOgUNMWQpUQDJJkFV4ULuFkpYiLb3JJvci8cJWoDY+YhcwLlhJUePK7jbhZHHs3wWsoDB226PiA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:15AM +0800, Baoquan He wrote: > In one vmap_block area, there could be three types of regions: region > being used which is allocated through vb_alloc(), dirty region which > is freed via vb_free() and free region. Among them, only used region > has available data. While there's no way to track those used regions > currently. > > Here, add bitmap field used_map into vmap_block, and set/clear it during > allocation or freeing regions of vmap_block area. > > This is a preparatoin for later use. > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 428e0bee5c9c..d6ff058ef4d0 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1922,6 +1922,7 @@ struct vmap_block { > spinlock_t lock; > struct vmap_area *va; > unsigned long free, dirty; > + DECLARE_BITMAP(used_map, VMAP_BBMAP_BITS); > unsigned long dirty_min, dirty_max; /*< dirty range */ > struct list_head free_list; > struct rcu_head rcu_head; > @@ -1998,10 +1999,12 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > vb->va = va; > /* At least something should be left free */ > BUG_ON(VMAP_BBMAP_BITS <= (1UL << order)); > + bitmap_zero(vb->used_map, VMAP_BBMAP_BITS); > vb->free = VMAP_BBMAP_BITS - (1UL << order); > vb->dirty = 0; > vb->dirty_min = VMAP_BBMAP_BITS; > vb->dirty_max = 0; > + bitmap_set(vb->used_map, 0, (1UL << order)); > INIT_LIST_HEAD(&vb->free_list); > > vb_idx = addr_to_vb_idx(va->va_start); > @@ -2111,6 +2114,7 @@ static void *vb_alloc(unsigned long size, gfp_t gfp_mask) > pages_off = VMAP_BBMAP_BITS - vb->free; > vaddr = vmap_block_vaddr(vb->va->va_start, pages_off); > vb->free -= 1UL << order; > + bitmap_set(vb->used_map, pages_off, (1UL << order)); > if (vb->free == 0) { > spin_lock(&vbq->lock); > list_del_rcu(&vb->free_list); > @@ -2144,6 +2148,9 @@ static void vb_free(unsigned long addr, unsigned long size) > order = get_order(size); > offset = (addr & (VMAP_BLOCK_SIZE - 1)) >> PAGE_SHIFT; > vb = xa_load(&vmap_blocks, addr_to_vb_idx(addr)); > + spin_lock(&vb->lock); > + bitmap_clear(vb->used_map, offset, (1UL << order)); > + spin_unlock(&vb->lock); > > vunmap_range_noflush(addr, addr + size); > > -- > 2.34.1 > Reviewed-by: Lorenzo Stoakes