From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F89C54EBE for ; Mon, 16 Jan 2023 11:46:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 294256B0072; Mon, 16 Jan 2023 06:46:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2442A6B0073; Mon, 16 Jan 2023 06:46:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133826B0074; Mon, 16 Jan 2023 06:46:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 071336B0072 for ; Mon, 16 Jan 2023 06:46:58 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 969C21406F6 for ; Mon, 16 Jan 2023 11:46:57 +0000 (UTC) X-FDA: 80360485674.28.8E08945 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf11.hostedemail.com (Postfix) with ESMTP id BE1F84000D for ; Mon, 16 Jan 2023 11:46:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MsgjWYfp; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673869615; a=rsa-sha256; cv=none; b=PecG4UAc6JFtn6E4yLcxvF1UdHiGt+k4V49dBoa4jqh4azYd2Y0V/ldnNjuBo9maP21jsZ 0fXrVSt5Yl4eJTguD9S16rFuIocE0LsGmuvKvUlcreNg4fZ9xRkwk+6fJi3+9a2xyKcjAq QWdw8RQLO3yIqv+1wBNtipx1K9xaHNY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MsgjWYfp; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673869615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LeQntdTA5Ugurin8mDm/P6vcnLBcFASvg8588uk6TaE=; b=GqNrmaghtffcTJx1Imzl8UjnIX9768YxoGqDNFzpwWqFBhfAE4h2/hDBLLhkbCg1771/Hg pyIma+/c2nqf3a/7Hlja4YwVFfkNRHZsVAFlF5cYh469MhAR/66cWuGA2GeDHCrpnsq6Hb DNVmfubbh1ImS/1CiO5sZFQ8y9ygWks= Received: by mail-lf1-f45.google.com with SMTP id y25so42325372lfa.9 for ; Mon, 16 Jan 2023 03:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=LeQntdTA5Ugurin8mDm/P6vcnLBcFASvg8588uk6TaE=; b=MsgjWYfpigMizqsn8k+uHz+dowcgwReaEaESYSvWJ7LKYJkwmCoypzJw2xZ/KPaaig 32LeqRCiB4qtsVKEI3x/fa5KpkEOVt03gt6jDfgSLI9yprttbSIxKqqPYyZ+bXxIr5e6 P2iWpb5KGmj0iKBkQ/kEK/0+88hCgq8SK/mRxDq6WAvmoSvSoG7GzTQnbXXErs2ok7ji mwn4vopcWwRgrbKbDFaaUR6VKxIEQxMn2NyIlk/Mu69dYfMd+v9kezKQlm0DMT5hWDrc GKYE8HjK3DgMpeiFYzR8Jtpg6emDrhgEoP/oc8Rg3Qg5XclzzSyIAfssSWP6sorBoKTq sfpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LeQntdTA5Ugurin8mDm/P6vcnLBcFASvg8588uk6TaE=; b=ou3eE9seBio5b2eLz/nUyyO9ZfObMbVWYfvF2wWi8KZZolCxdEKyN110Z8UuIJaLtw sL9tS99V1Vkcwn7F9cTGPc48JssihjorG4m/TdcAZEl0ChBwpSXHSzoQQ5mkd+/MOa6i AMoUny+ITQrIoO9UhBTLtFVFEZP2fb0DsuA5sw1GMBVuc+LScuzC/l9lyRI+Rys1X96l BDReFSAS8Fy8rdlmVMG8lpbuTfMub4tkyRtaa+aqxg8WAX3lxopMfAkNw4G152OWjsFu V6VBprE/SKwSJ47rppw7Pw/E7Bl1u4zXsL8YlWnRhMmbGzhx0tCSl4jBleCx4QCHvnQ+ Btbg== X-Gm-Message-State: AFqh2kofL68FREtcM3hyjMB2xoVa3MKR4OZ4xehembMx799qvsYi1cx6 fMz7OLs6CQ0zabCyGmwZ3/U= X-Google-Smtp-Source: AMrXdXvwEWPg+wQ4w94mYobpLgfgculyyzXmkJrIONdQeP4x2/Y8STqbSRiZwvXyDsqCQnN2pSGO1w== X-Received: by 2002:a05:6512:2085:b0:4d4:ea0f:a784 with SMTP id t5-20020a056512208500b004d4ea0fa784mr1883553lfr.19.1673869614244; Mon, 16 Jan 2023 03:46:54 -0800 (PST) Received: from pc636 (host-90-235-24-7.mobileonline.telia.com. [90.235.24.7]) by smtp.gmail.com with ESMTPSA id q21-20020a0565123a9500b004d272bf56b5sm1213598lfu.223.2023.01.16.03.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 03:46:53 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 16 Jan 2023 12:46:51 +0100 To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, lstoakes@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 7/7] sh: mm: set VM_IOREMAP flag to the vmalloc area Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-8-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-8-bhe@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: BE1F84000D X-Rspamd-Server: rspam01 X-Stat-Signature: t349eujbf1qfzrfaxgnb3otketn93o6s X-HE-Tag: 1673869615-566038 X-HE-Meta: U2FsdGVkX1/ElOYzZftW+BfLvYbqZDmp8RIedVv/3Y+ht2q36fMr67kc6Gl/omlUDRWa7k/GxN8+HaaGJZ4+d1khGY9ZRnHmt8nW7q2nwzuO7ZjZRLAKOub0uAQD1IECHg0Qyx1hFKkJKn99xyQFkX+xK3PL9PH25E4dlHyGT4NVDPwAd1WT4t3FZHfkz+ZfUhJj3yB6hynzYb7+k+SfmX2SRIUy/z/krIddvCSYX5cUWSuCBVn9GL1WBPAJY+HAJ7zSGD1UE8GTkutXlERQ5p8EGaT+rsh+eENdjv7LASh9IVxoPMQxbIfzNvbluCItDeZg/r+sYDKvDukI4gmRNUocb28rQZb++IznZoJmRKe6UdpVc1qEkeKlCf+7eCYvb1eI6imXytGjQM92G94wZd4h3OdKZUdwQJ8jwHNV4G28NUF5XjE++JV8pmCZcOgZEY4vO7j9O00O6p2MqFxU+2YmVUKexdtE3BgUgv6xxBUrLQx/KHNAyFYlJoxVn7EbajrzT3ANzV6TAXyxngdvwWmA/oJ1vqqfn/Ij8K3cn1fL/BnYOI+e+ixwDf1SmKj0rOriuhqNkAnUZvy0cQfkYJTrVfSY3fAINVY9w7Rbgwn32+cwOHh2TG3E+4Cl9iQN5E6avi6APUXo0NUF6eKNUHCGsduDDYv+ZRcz6ql79D5qgV0KEo7T70S6yS8bqIWZbFTwWRx1w3biLFauRq5Sv20DyBVF52pA0+CGVc/mAgdWH8I6aFcdnZJVg3Dby054hFrv0VAmCwzv9FGgPodivAJpTTJc/CsTHVS/AdYQ5VLIK2Y74tSbQupnwWFAc7fDPavhGMJ8k0PeMrfN+t/4eoNQNkG9HP+3n+LweITBXNWTZHdSDI5eDLrMDLoBXRTa6LIPTglltiIkB12g5W1fM67EP6ziyn6HYNHdU17bpFmdnScqd311bQooP0gHvGiL1yf524nvhygX4f9WShx 0h5lLNgr Q0WAZ324a3ro0Fquyprqcpsixp8IYrpm5YRkxa7oGoGMN2iEBQfb9JDxmVoN9f7YbKByzk21qDZCcnoo68fhpMSt9q5PWAj2f4tPZma269HcFbkDFYAbksQdaHZqQgd8xTtO4fkn8fvqJQfg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:21AM +0800, Baoquan He wrote: > Currently, for vmalloc areas with flag VM_IOREMAP set, except of the > specific alignment clamping in __get_vm_area_node(), they will be > 1) Shown as ioremap in /proc/vmallocinfo; > 2) Ignored by /proc/kcore reading via vread() > > So for the ioremap in __sq_remap() of sh, we should set VM_IOREMAP > in flag to make it handled correctly as above. > > Signed-off-by: Baoquan He > --- > arch/sh/kernel/cpu/sh4/sq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c > index a76b94e41e91..27f2e3da5aa2 100644 > --- a/arch/sh/kernel/cpu/sh4/sq.c > +++ b/arch/sh/kernel/cpu/sh4/sq.c > @@ -103,7 +103,7 @@ static int __sq_remap(struct sq_mapping *map, pgprot_t prot) > #if defined(CONFIG_MMU) > struct vm_struct *vma; > > - vma = __get_vm_area_caller(map->size, VM_ALLOC, map->sq_addr, > + vma = __get_vm_area_caller(map->size, VM_IOREMAP, map->sq_addr, > SQ_ADDRMAX, __builtin_return_address(0)); > if (!vma) > return -ENOMEM; > -- > 2.34.1 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki