From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C28AC46467 for ; Mon, 16 Jan 2023 11:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BE0E6B0072; Mon, 16 Jan 2023 06:43:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26EFA6B0073; Mon, 16 Jan 2023 06:43:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 135E16B0074; Mon, 16 Jan 2023 06:43:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 05ED86B0072 for ; Mon, 16 Jan 2023 06:43:35 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BED2A802F4 for ; Mon, 16 Jan 2023 11:43:34 +0000 (UTC) X-FDA: 80360477148.07.6B1FC1C Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf18.hostedemail.com (Postfix) with ESMTP id 007EE1C000F for ; Mon, 16 Jan 2023 11:43:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MuEmOHgk; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673869413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DDY2ydxs0Md/L6JTm4RZDTBwRYkpSjvKBRY/2I51biw=; b=Wm+WDSK+srBVRRkrNXu0E4KFZ1nV6Qjm6DBrdkAi08I3fct8zIoUx8sBTHdGU6m7x6MACy OEkHRsCjCcTzmyIltJWHKPiyVD/+X9Un7nuT98KspVwqWcBHqTMRvCXvZzoPx6LhasBCgh ZZXnf/i8DVONnyPMAl46Ve2jevnmg9U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MuEmOHgk; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673869413; a=rsa-sha256; cv=none; b=zWVXwLBSzF6fgJ+2ylC6+VaG0MhvXNACYCVtHxybGit0fkaefCbEXtyGpGYWgOrmKh0psX KoR4fiGh23ttuIu7A8ZXXqjsjn3q2sgJ49iy0UcOQ8h7XsPCfDRjqPcwVK3V5WQcIyje55 gXyWy7fqI5lmnhBJ2LX8mqUTpHGHzyY= Received: by mail-lf1-f53.google.com with SMTP id f34so42310066lfv.10 for ; Mon, 16 Jan 2023 03:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=DDY2ydxs0Md/L6JTm4RZDTBwRYkpSjvKBRY/2I51biw=; b=MuEmOHgkGzLLTvws9Ihl7oSSt7/unm2LvNMye1oPgRHA9WTV+nmYv1zRxhFy2Inj9m CraJ3ViaAD8MHQcap+2CPtIYkB0TcMKg/UIy74J461txx86a+mF91H0aClhukZzqUImc WtFGgFR55RW0WH/7OXqSdHM9ybt/gaRx9Rq25uN1WPPXKDplLZW5vSkZOYJsvMKjvWUQ Ni1bB8KCAYdV+fvULM6diqWCnwIbDVIjR7OfPNUUJWvOStl3GeUXQT1QKsqiNRuBpgay bVXtSU9nL0B1UQCLJ0YKDUKS/KjqFl3MQ0wU1286f1nITThwv1xhBnkUYp8PHRIMWj5Y wX/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DDY2ydxs0Md/L6JTm4RZDTBwRYkpSjvKBRY/2I51biw=; b=LgqV8MS9FwpyiwCu1v7FjsibptIaNd1P5Q2tH8zjNEJexSRCqZUaMd3+D2LVFbgOVa b5IM4+sj1KF7eHxQC08HCZ8NI20xryVS8E7NjWw98BnGGDs1ZJ1Wm/dobnLpbQDdcl4p iv/e35wuLUd2e+WgrmBkfnkaW7KNJmDX/mF7Vju6WBQ5bbxhtltTi5Ez+bZ6/4RyE2Y6 dz1uWgX3wLWIokgAOyItY5dp8ND0jmn+rakqfCFA6uctWdd1w6/h5EEEc8482X8Lujqg K3ot6U2Q8yJ8fR5dwfTMfSZk+g51frq/cNh6Ov8fhb716Wdzx3nfFnvHx3bqS4gvm27O gXmQ== X-Gm-Message-State: AFqh2kpN2sYlF9zB91z8lTeqzPGXDlWe2EyL3tdYGRtcr+HJ2wuN2/is VUeHidthxfz71Kr2vvp6DqiDgdsGoqQ= X-Google-Smtp-Source: AMrXdXuMz0sQSCLXjhBIYQOM3hUdQls1ndH+6zB95ktI9QD+ueAd+usUmv6UfkcJc2/bAcy6BdyfoQ== X-Received: by 2002:ac2:5933:0:b0:4ce:e773:db6c with SMTP id v19-20020ac25933000000b004cee773db6cmr4184383lfi.57.1673869411313; Mon, 16 Jan 2023 03:43:31 -0800 (PST) Received: from pc636 (host-90-235-24-7.mobileonline.telia.com. [90.235.24.7]) by smtp.gmail.com with ESMTPSA id j5-20020a05651231c500b004b5480edf67sm4998955lfe.36.2023.01.16.03.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 03:43:30 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 16 Jan 2023 12:43:28 +0100 To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, lstoakes@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 4/7] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-5-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 71oo4rot6n6ukphsw1z5durce7fxo6yt X-Rspamd-Queue-Id: 007EE1C000F X-HE-Tag: 1673869412-59309 X-HE-Meta: U2FsdGVkX18L1d9tdoUhs5yDzABm3JfewNJuAyaG6k0wFQRP8CBPqDAaEy6HyqT33Yn6ZbusxQCnomfrPrRM2d0WohsOBboXJNiOnBbO40GAc6/H/QZqM5XxtSygKqFtbyzJo5ZWAVkUGeIptUUqrUu029qtzr00Dg+kpjFC7Q24R2xeflN+BHs4ZrdC6V4ktf7/ZMhqOlNMMfOvK95nTrMItP6z3cAdwHffj6NaMTMiEz1qle465H0n/xQVTJFlYiuTt8w0gfohsc6/3aP5P+Shp4+t0Wcetw1PWbdcgZw1bNjBa3uG6C6mFAuxQVWiIzDAkgUFgvYAAxLKcWQ36hflas8kFXPvNbnEXBPZgRe59bBcGgmkMdHYjhBPvxPWJk0nzV2maVIOumcV2GYDp0HA2Ma1L4rrmljlZGVAbd9vTqjJevgeGRGvxVBthvzZm9SpaA+gAWcJ1BunK36Kn8YAZ1Hq3ciZZMZeFPHrljZ+Bjh1Dz4oCEbtD4XV0wHqiE+Ihjc0oV7eGu0IzeiQYtxFpZyvwOTK8tZ2dngaamm64g2/AeK7jkVr0m1yd0wfjLLIyAfZzxuAEj4NMqPlje65Wz7Pnd0Qun9nPr+JXzjoWqyh9GnxZMt4EcYTOxqIYogChri4p3OThf5DK0kzNYJqTq5lV2HbEKWmwSdJHuNv+oih7dGxSyu0GSiJfMrIi47FaMWygAVml+4z3DsNz3Uvo6nvFVyUSgs6gHC1s+NgkrcTuNEXh/9KzByNQCH8xcBCn6szvqlAXHNaf0oP7VKTutha+LzyJDEXlaF8pirHeVs1xmOCxBWKG69G4BdwexhX5CWuAG4+g0lmuptrvY+diZuV0UuSWeJGguZ+NHgsuFfGsLIHc3UtIJQBNMUkckfkqmyM0fZRdqiBV1WPxHtoY/boorCJr54oyx/XoSnQLGIqUXMjVsR29FqKsM2naGEPshcjos01Gddmi7J 0o8VdVSX i/ByF3kZ06Rggk/wlu2s/cPbCFiRTQUyClIEzpcf0ZKBVRzpnfI3P+EoEczA2MvtLHbKk8uWnXDGa7LHM4cZTEoFJ9Ak5inc3joBUHe4HH4yc5MDqx9a3h3X4+b7EYR8JHy48 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:18AM +0800, Baoquan He wrote: > Now, by marking VMAP_RAM in vmap_area->flags for vm_map_ram, we can > clearly differentiate it with other vmalloc areas. So identify > vm_map_area area by checking VMAP_RAM of vmap_area->flags when shown > in /proc/vmcoreinfo. > > Meanwhile, the code comment above vm_map_ram area checking in s_show() > is not needed any more, remove it here. > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 13875bc41e27..4a10b3b692fa 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4225,11 +4225,7 @@ static int s_show(struct seq_file *m, void *p) > > va = list_entry(p, struct vmap_area, list); > > - /* > - * s_show can encounter race with remove_vm_area, !vm on behalf > - * of vmap area is being tear down or vm_map_ram allocation. > - */ > - if (!va->vm) { > + if (!va->vm && (va->flags & VMAP_RAM)) { > seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n", > (void *)va->va_start, (void *)va->va_end, > va->va_end - va->va_start); > -- > 2.34.1 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki