From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1279CC46467 for ; Mon, 16 Jan 2023 11:39:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DC346B0071; Mon, 16 Jan 2023 06:39:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 864186B0072; Mon, 16 Jan 2023 06:39:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 704846B0073; Mon, 16 Jan 2023 06:39:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5831E6B0071 for ; Mon, 16 Jan 2023 06:39:54 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3AB451C6258 for ; Mon, 16 Jan 2023 11:39:54 +0000 (UTC) X-FDA: 80360467908.25.9AAB4FF Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf03.hostedemail.com (Postfix) with ESMTP id 7395520017 for ; Mon, 16 Jan 2023 11:39:51 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZIvcWSLE; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673869191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JggCD+IgH4kg5EYbvhAMqXcJgvTK6zOEGFmEBxsdv90=; b=BsiEYBPcevNEwtFCr8HFR/CLHPxlwLbhoLuh/T60ocRWUYHkhxH7aF3f259zONHPraofi8 rwvN6WqJqCWg08IOsj+cJmKQ1sBVd0Cku2omGcGCFFxZZlwERtuloyk8lRR6M1D1W2Jx4B 4MiMMi7iS5UApTuffefctDDH1Ssgbog= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZIvcWSLE; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673869191; a=rsa-sha256; cv=none; b=Z2yU1iFHE9FMTuTj3L93g07tQ1RrJ/230uqpViyUtt4NZg/R202zr142fC2Ekl6GpJikLe UKy7e0zdBGk5UFx6dLiyzJcPY7O9151+q5aPqQGgXmq+FWrKAcwBRnQC6SlOxgYMZAiO0Y mz6y3/rw9VmYquE9Rwd0CGSdMbTS5fg= Received: by mail-lf1-f50.google.com with SMTP id br9so7031698lfb.4 for ; Mon, 16 Jan 2023 03:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=JggCD+IgH4kg5EYbvhAMqXcJgvTK6zOEGFmEBxsdv90=; b=ZIvcWSLEiMNyb/a5eDKtn67l7WZ9GeHXI7gTjLSrUUKCnQbu92kERrSQm3wK4TU9DJ tOnUxd1xgppr9Z5oVVBvNmN+CTDyNQnsrBOKFjnqgVYLrJpo3FyL6eijBlB1m8qXngBi 6RoXWMf01yre7LrVn4pywJ1Ll7OYlrvc9duYFcEbLTXB4xGLzziVszJ27EZ9cgThp/ar 2voEMh3/hN/mBmWllxqIyhMHNLHTAl2lGEjtxip2Em4/dOZ8mS3c0hhBtO8OeD3+KKn7 0pc2jrUAOQwkI38VcbzGhqdjQ39rPlc8JLY/tEVbBQNHMjrsFqDsCyD2rNoSNs/pm3QH Ckeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JggCD+IgH4kg5EYbvhAMqXcJgvTK6zOEGFmEBxsdv90=; b=irGwqUnIfXYjnpeSPbWTaLb2jEp9sIBuso4BEEGjb3tlHESNGFsgOzM3RCo2Qxp0hI 9XwyzmpfnA9xN0cNDEji51/cv7iNgKeK0C4RQqLB2Ui85N4lX6dlwXefZPIPIKP40uet a8FFKCudbirMBsbEGw2V5LV/8MCj8ZqtwjxOxqGVMEjPiEmv40nd9GId5VJTvxGOcdok VlnDNcwdnlgtHLDmMyfSgHKFr+Pbv0cQ4h+nuUoRWzQhq2gmFZiTFjUofexej4KWN2O+ 05lVChObxPMW/CrVqpi8kjuRDpowdrBbhp1WE5X6GQBAxiCUkcGJLfD5TBfwaodiDI0L IJ+g== X-Gm-Message-State: AFqh2kqU4RhncMF4gBiSrSTtXEwiBl1mC0D2VcPjQSJHZ3M/Klo6FNpW TLcA8AVict5aNrtmbrXDoMQ= X-Google-Smtp-Source: AMrXdXsCX0lgfeYQwVQNTlVoKTkqRg5XCY27bkNgu8CbGYSSpGFuiO6uVQDjcjttbO5KlhA1yVbd5A== X-Received: by 2002:a05:6512:2a89:b0:4b9:f5e5:8fbd with SMTP id dt9-20020a0565122a8900b004b9f5e58fbdmr24277599lfb.52.1673869189537; Mon, 16 Jan 2023 03:39:49 -0800 (PST) Received: from pc636 (host-90-235-24-7.mobileonline.telia.com. [90.235.24.7]) by smtp.gmail.com with ESMTPSA id s9-20020ac24649000000b004cb02ed464esm4960444lfo.196.2023.01.16.03.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 03:39:49 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 16 Jan 2023 12:39:46 +0100 To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, lstoakes@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 1/7] mm/vmalloc.c: add used_map into vmap_block to track space of vmap_block Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-2-bhe@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7395520017 X-Rspam-User: X-Stat-Signature: 9xizomozkr88p16194ym7e1r5di9cbb4 X-HE-Tag: 1673869191-411088 X-HE-Meta: U2FsdGVkX1++sd9F71P0UTqlykKVOdaf+HCk9x7/tEV8YbtgsL1fs7wOT39BRUj8soY9t0cVVWz1Finf9ZAgRMhZe8qg2UxX7jSyAFnI+jzhpuAucEYjoaofcwQYy0HuwIIdqnGQaP5v624QOXoNyYsalI8lKm8Sly4WP+qYACPBe4/1011hjyOYPdNkKZmKAyeedzIMwJeBpCIUzGCwhltOUCQJU8HQ0wrElRLx6m2CDv05eoyffA50I/x0wVNwoPyUBkE3kpZT/+y3l0ap71ov/CNJeCmKTprjeC8fDIhILRfPpHiItcAHaLml40qPuos0i5M9muK5y0bg5QZBcLcnQ0XxVeYE0NJcQA4CQiqToD57BnKMc+4YXTVqeXLywihsZoS/Y/2j/HfQznfXnqqKa6/D+yLbYbWQdItSUawHjHXOypLudoEaGstSv/9WGwlpvFAYq+fb/b/mpi3s+62wjngsO+WYccuQpstgHZQAlTCXjHqLKxTlb3N+4mD8Wzg/BAsccOMCe5YH9h3byzeGjXfx0o8BT4WprBkJenhwUg9aI0M/87wRofjxKTsr2K39ahLpngt4YROlWjAFHVZU0YvQVNq1lncRXEQnn7hoTI5gtgZjkdyf0ExR3BzOw7lKfA3zkuDgpYcZjGhY+UWTSCT6/K/k4x6YXziwcpiefv9quEKgiP4j1w5GybQoSd0qoxexVBGNxjn3HOn5guNqEP6ykrs6Vy/nlBRmscSxs/C5chzJhYq8YYeDy+HOpG3b8lXB0t7SH9aE3dvlkl5Ft03lZY/SI+ia7ujl4nCPIcplNqNU6NEH/Ab9R3l9Nu/CmxhaIVO0+hr4PlLYJqSuQhyXSGSpw1QcmI4BcxoCjDsVgb7ZTNrCo5b2MX6UbBY3g9r2tl48jxJ0gTH94YzSN3KpH6ns0AK7pyPZsYdQgxsOt394aMu/q00thewx1tq5nHBMUt8a/PwCtKR cj2GyPP5 6FMdhUW8Al4Rvu7imitkZrUdLkBJEJZxgOoxWUS53H1v7nbZdBM7xhag1cSLI0+wPJ7u6MBH+m/a2tRKJYrtGaEQxIo4h/lUfQv27h58tgI860eO6+RuDMuFcAbu6c+Z3JfT8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:15AM +0800, Baoquan He wrote: > In one vmap_block area, there could be three types of regions: region > being used which is allocated through vb_alloc(), dirty region which > is freed via vb_free() and free region. Among them, only used region > has available data. While there's no way to track those used regions > currently. > > Here, add bitmap field used_map into vmap_block, and set/clear it during > allocation or freeing regions of vmap_block area. > > This is a preparatoin for later use. > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 428e0bee5c9c..d6ff058ef4d0 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1922,6 +1922,7 @@ struct vmap_block { > spinlock_t lock; > struct vmap_area *va; > unsigned long free, dirty; > + DECLARE_BITMAP(used_map, VMAP_BBMAP_BITS); > unsigned long dirty_min, dirty_max; /*< dirty range */ > struct list_head free_list; > struct rcu_head rcu_head; > @@ -1998,10 +1999,12 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > vb->va = va; > /* At least something should be left free */ > BUG_ON(VMAP_BBMAP_BITS <= (1UL << order)); > + bitmap_zero(vb->used_map, VMAP_BBMAP_BITS); > vb->free = VMAP_BBMAP_BITS - (1UL << order); > vb->dirty = 0; > vb->dirty_min = VMAP_BBMAP_BITS; > vb->dirty_max = 0; > + bitmap_set(vb->used_map, 0, (1UL << order)); > INIT_LIST_HEAD(&vb->free_list); > > vb_idx = addr_to_vb_idx(va->va_start); > @@ -2111,6 +2114,7 @@ static void *vb_alloc(unsigned long size, gfp_t gfp_mask) > pages_off = VMAP_BBMAP_BITS - vb->free; > vaddr = vmap_block_vaddr(vb->va->va_start, pages_off); > vb->free -= 1UL << order; > + bitmap_set(vb->used_map, pages_off, (1UL << order)); > if (vb->free == 0) { > spin_lock(&vbq->lock); > list_del_rcu(&vb->free_list); > @@ -2144,6 +2148,9 @@ static void vb_free(unsigned long addr, unsigned long size) > order = get_order(size); > offset = (addr & (VMAP_BLOCK_SIZE - 1)) >> PAGE_SHIFT; > vb = xa_load(&vmap_blocks, addr_to_vb_idx(addr)); > + spin_lock(&vb->lock); > + bitmap_clear(vb->used_map, offset, (1UL << order)); > + spin_unlock(&vb->lock); > > vunmap_range_noflush(addr, addr + size); > > -- > 2.34.1 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki