From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B042DC63797 for ; Sun, 15 Jan 2023 14:55:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1CDB6B0071; Sun, 15 Jan 2023 09:55:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCD8F6B0072; Sun, 15 Jan 2023 09:55:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B94DC6B0073; Sun, 15 Jan 2023 09:55:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A6DF16B0071 for ; Sun, 15 Jan 2023 09:55:40 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E3A2E16022B for ; Sun, 15 Jan 2023 14:55:39 +0000 (UTC) X-FDA: 80357332398.30.67A8B09 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf30.hostedemail.com (Postfix) with ESMTP id 303B380011 for ; Sun, 15 Jan 2023 14:55:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BwmFLvWu; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673794538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rxQBoQ4zwsDYiqotDumPSxrrObK/piv54Nf9p66paMI=; b=Ri/fY3UMmri8aW78SvvYlli6u8/4DuOiGT76i+Yxfo520/QDY2UJnpd7UYKMW3lb/68C/T DJparX9ltyFffq7hb4M9/+ClA5y6eNdJO7IkVLutV3hCl1ENBg8CQCCp7gRjcgE29KJLEL 733KBqu4rwGaNhU1FOUYAu+heVFw0LI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BwmFLvWu; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.45 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673794538; a=rsa-sha256; cv=none; b=iPphyXZB9APezaCn2F4EWlJ+HKmEuJD9q73eTt7uch1uEo0Jwfu5gbuD7V3QKPBXetDxo6 35WKSkNZDO6g7nn2NnBFTqrczGTffMeE/MJH7beGqSVLsOUXk2eZoPs+5cD940DGpYOcz/ pUjH2ABVaaCRePRgMJrEEuUj+ANA8aM= Received: by mail-pj1-f45.google.com with SMTP id z4-20020a17090a170400b00226d331390cso28808782pjd.5 for ; Sun, 15 Jan 2023 06:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rxQBoQ4zwsDYiqotDumPSxrrObK/piv54Nf9p66paMI=; b=BwmFLvWusNYl48KgQ2+NqlCI2Z6alcbJhxv0QLXzIvyowbdh7aofFk3vioIi3zSzP/ jtnF3LI17FlyrI3OPeUAxxRslbiI7L8VnMB1rGnhcYPGeP+mqev2YK2IQdqacrj8KKPx 7Cehm7uqaPhNClaEirTg21MJgz8gdZ4H6UZis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rxQBoQ4zwsDYiqotDumPSxrrObK/piv54Nf9p66paMI=; b=r8lcwiGIXSI3tlLfPOXRT9CyZJhcdG/pfBFyR37B2JrCo/a6cARZlcgfxpHf6caOup 9VGPymHBdShYa9kawGGrMxNlihk4LgAgpz7Zs694VsbZxy62RIOc9Yagopl75MQJLTwV sHu6xSVvUrKVHkS6NG5v5VJ8I1Vi9AtuuJpd70ynSRfO9M/86vYcS2UNdVZ0Z8NHKD86 A0xaiteHHYVhvT6LSZRXrmXQW99gMw0elDnvckdyag/Y3X6FUA6MiM2IQUNWl2ZfF2Xq T/4kFZ59lRgfudvR79jpHf+Q8uTTbil3tlh0dlirLNcTqDf3OP65XEM9NTHJW8QUukgm k9og== X-Gm-Message-State: AFqh2krE3zNkfyBy0eIgVw/uDqnmkoy/gVuj+5T1L+1HdyVlna2nX5gY vaeA8l7YlTTucI6rkiVFzsEx8w== X-Google-Smtp-Source: AMrXdXunSU7OWCSqkir5WAjEpH9oWdYZa3bVxfv2t+WybCWGEH8h3zGa3Xzk7COxFQja7AbYith8sQ== X-Received: by 2002:a17:902:e80a:b0:193:38ce:7bb8 with SMTP id u10-20020a170902e80a00b0019338ce7bb8mr25038960plg.37.1673794536919; Sun, 15 Jan 2023 06:55:36 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id d12-20020a170902654c00b00189422a6b8bsm17500374pln.91.2023.01.15.06.55.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jan 2023 06:55:36 -0800 (PST) Date: Sun, 15 Jan 2023 23:55:32 +0900 From: Sergey Senozhatsky To: Matthew Wilcox Cc: Sergey Senozhatsky , Andrew Morton , Mike Kravetz , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 303B380011 X-Stat-Signature: zh51tkzc7ugn39p1z1r53tykow17tqxf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673794537-31032 X-HE-Meta: U2FsdGVkX19nR8l0a5tR00MyVLg+MOsDUJMZw/zZVIJPuqGeHMfZNI09w7hSBYbtMYavGBwJFa1WbMlAAVy6WCFnbCQsbKKLtuKKRQ07f40Lv/9tz39X1Q8Wvn/3TuQhee9SiWHwhcBYgJgZKly+v2x6KwXMKQ0Zi2LYGj6xVMKNFnHpeSBCMEmio5MHHP+OD87TPVkSAzkTzPk2mbYQK03MNGRod69HWGgs9hmUO/hAZCPJtNj4VizBkOkHDQnsElKmZcxbj6pC6TGSvoBQu4xPS5Nk+dPh4oXl2FEcyhm01HqDb6T1m9G+imHEUCYnePiHz2PxG6sDcXriD6ymq6+6+Lf9r+LtTAP7Gb7B11DxgWDSM5kzNcGGp4K4okISaOeApPQAkacjnTGKZ3LQEnOgHBvX1tcc4AqaHrQD3clA3UVarfi2+q2Vn8mbF3dRbU/6JQyeEMHGENbz6b3L7w99aogv7xb9sqKGJfr3myDhlnQ+wNHNxnalxz8RBV8wWSTKROsMSKf99VYQyqLUWnumUFLhpja20Noy6fd+5xsoT9e+YC94qbtCNoEFrIiE9EJ4ZR2z1Zbkv3fLqrueT0TGvH1xsdjXKmH6jG9DBQoY2QZWZTnxp5uTu5in03ePrr6djOZXqhKlgHwi1Ht1lo6Ul5b9RM+y9i96HywxYnwXLRDm4635OfWOo0WHO5FVoWv61I5023td6EIS9Hubh0Vcdm5FMq8E2PMwS+chpKd8pEgTdEYn24pZH+DvRB00NaCAEaAn1A9AK+UkP3epP+0GJ4ycv6q1C0SxN75KgqRg+F+mG3Cu1674t8IosBOyBd+2F1WFr2MvLBGqBvoc0fpeTFWBR1HRXGltSu8kOJtu+Cf/Y1S8uuNomoB4ZwghEfIt5dQQCbUaZcJQ9R0OXJVLENkHOmTKBbas/MVfxI0ij4gZB0IN0mIFH9oDxhUzVtSoSB+Mkwlzj7SyT5p T7ukczRd a7RCG2HbeWQ+/qFIKuqR7lkxbOzgvW95lcdQqNR5C6xBDg4N0PydYkE1QLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/01/15 13:04), Matthew Wilcox wrote: > On Sun, Jan 15, 2023 at 04:18:55PM +0900, Sergey Senozhatsky wrote: > > So this warning is move_to_new_folio() being called on un-isolated > > src folio. I had DEBUG_VM disabled so VM_BUG_ON_FOLIO(!folio_test_isolated(src)) > > did nothing, however after mops->migrate_page() it would trigger WARN_ON() > > because it evaluates folio_test_isolated(src) one more time: > > > > [ 59.500580] page:0000000097d97a42 refcount:2 mapcount:1665 mapping:0000000000000000 index:0xffffea00185ce940 pfn:0x113dc4 > > [ 59.503239] flags: 0x8000000000000001(locked|zone=2) > > [ 59.505060] raw: 8000000000000001 ffffea00044f70c8 ffffc90000ba7c20 ffffffff81c22582 > > [ 59.507288] raw: ffffea00185ce940 ffff88809183fdb0 0000000200000680 0000000000000000 > > That is quite the messed-up page. mapcount is positive, but higher than > refcount. And not just a little bit; 1665 vs 2. But mapping is NULL, > so it's not anon or file memory. Makes me think it belongs to a driver > that's using ->mapcount for its own purposes. It's not PageSlab. > > Given that you're working on zsmalloc, I took a look and: > > static inline void set_first_obj_offset(struct page *page, unsigned int offset) > { > page->page_type = offset; > } > > (page_type aliases with mapcount). So I'm pretty sure this is a > zsmalloc page. But mapping should point to zsmalloc_mops. Not > really sure what's going on here. Can you bisect? Thanks. Let me try bisecting. From what I can tell it seems that tags/next-20221226 is the last good and tags/next-20230105 is the first bad kernel. I'll try to narrow it down from here.