From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE628C63797 for ; Sun, 15 Jan 2023 04:21:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E86088E0002; Sat, 14 Jan 2023 23:21:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E36868E0001; Sat, 14 Jan 2023 23:21:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFE098E0002; Sat, 14 Jan 2023 23:21:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C05C28E0001 for ; Sat, 14 Jan 2023 23:21:41 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7FA90160984 for ; Sun, 15 Jan 2023 04:21:41 +0000 (UTC) X-FDA: 80355734802.06.01BB825 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf17.hostedemail.com (Postfix) with ESMTP id C536B40004 for ; Sun, 15 Jan 2023 04:21:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="b0b/7owM"; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673756499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ALsjGopWf+hZuhs7nMXhO/pSXNTGv/26Xn0WdBaHFYg=; b=QrnUX7kdQx0CkANWCynYF6v5P57guCcGKzs4tKsLWfJ+gBkfogpqYnozm5TyoCQApjpVZK ArBbBUd69Jg3AQqZRde1yx3Cdw7U8TtfKjvYwHDBu6W+WH4zMYqIeA8UqCdvoHbSe95+DO InresOPmBl5196WmR3fHNmChl+lpss8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="b0b/7owM"; spf=pass (imf17.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673756499; a=rsa-sha256; cv=none; b=btpPwvn0Afc7L1fKwQcQIAmrR5wTKzD0uGDVMDxEsdfjAAhfoPPvd2vyfQktlAjE6Oj8o0 ppRqp7Z+9gopFipM+M76iiqAJDPerf5R/BC8wVksuKqVd6ugFUMNiBxavvbFddDQ8dTdBU T51nRPg5Yx9+XflZwlZfYnfwBE4vCWQ= Received: by mail-pg1-f182.google.com with SMTP id s67so17502862pgs.3 for ; Sat, 14 Jan 2023 20:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ALsjGopWf+hZuhs7nMXhO/pSXNTGv/26Xn0WdBaHFYg=; b=b0b/7owMlcYKKx6n44kgErJ0X4MpjPnAodIgILqAjx2U7yjvSdxiXkLLbGACuOgZc4 yrCdHqkodXVWTtbOoqjItH+Jr5TRL1BkFhbY6sZrJsCah3dE4BjAgVj7nWl/2Zk0QdDX TvlVurRKhQhnZb/t78+SPyHJcARCWA0BwVd20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ALsjGopWf+hZuhs7nMXhO/pSXNTGv/26Xn0WdBaHFYg=; b=oTCTT5xIhrRSulb5kztt9x5h5yznxh+FxKhS/UFWzoganhHxu3f2mtO/0p3Gz0HG00 McDaMiaIXjZ8lpbypi+SCQF3NPR3BVAUA2VCv1IpfLEiFpxuEBhUfWCv8ekdFdp9z99m Wbvwzt12Mx1i1F5u9IS7TlOBjz0MicYlcwr+Vk+LWWVK6lNFkrZTobBuwRSIjev0XuGZ Wp4qoQC68X1YAFnggBEPR343kDbw0Qq96J+xuZDbGyywlg0jtqL0OtmWUAVNcULm4tjR VWImmmF2DkN+2z6jgC3b29dCgluXCaPOhWRBnwxRHdn2yD41L4KZaHlzTvJprz0yrD0b fwuQ== X-Gm-Message-State: AFqh2ko2/Qp6Skp8bIdyPVcrsyPmKWrkUU70/zFo9fR3G72P61qfK7z1 3dvRSVqmBoHZ3Oekm66fD+mq8Q== X-Google-Smtp-Source: AMrXdXuMdyba1c18pSrzjUQQ67d8ohp6Yo5Xgp4BKX9lppikXZ/3+a5X6b5bAAytRkPdXQaa7xt2iA== X-Received: by 2002:a62:1684:0:b0:587:8d47:acdd with SMTP id 126-20020a621684000000b005878d47acddmr21290384pfw.34.1673756498581; Sat, 14 Jan 2023 20:21:38 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id 4-20020a620404000000b00576ee69c130sm15797537pfe.4.2023.01.14.20.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 20:21:37 -0800 (PST) Date: Sun, 15 Jan 2023 13:21:33 +0900 From: Sergey Senozhatsky To: Mike Kravetz Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: pf6469jby1znk3cadokdyahmjpbezbnu X-Rspamd-Queue-Id: C536B40004 X-HE-Tag: 1673756499-937223 X-HE-Meta: U2FsdGVkX18LqyvnRXgZfYj6TUdRrtX9GQzgnkftTaV0NNzzo5SjhrWzb6tWXZIkzLUrtk2ry8mTMlUDEb6kbgfLZp4YoOuRHf/Cn1H2wjgYCWeR+jVDmZhmyS8r2tzjrXAEo/QPTgd7UEG9/fgAtiMBOadbH6Ai19m5uGUxKF5BRx6dNTPthCeJttEMowuoO+UurbT+ij7+H533sJPnS90CKY5J8xdcR2jJhNTXglIDRh8uDxkv+4ZJnoBdjOJhYKuPddRv4lIGaOG4t3PU245HRbhYv1DUOPbRVrF7QJw1hsBmyy8Is3UJjEXG6nnT+kZ8/8kL85w9X/RNuUCF7QLOfxzWlByeC96i2RmafLdw6ZB6/qmeGiR86eI5F2SIrbYJcI00npeVhPJXKpaIJEiabAzoTBUHBjKFAN6RgthAIh7FGYEpqrpKlkJ2UWshSlg609S7yScarE7Tvr2js9VpPbFIIJA4xn1ZC01brMxcYazZYegFpLvVb56RZRXC/p9Y1bGJZXGl+hmxeFBz82Q5FTXcVoB0xd5iWfqF5xZrG1XR3E6HptkRIr9xzQOuNzkMIn0PHwWlaOO/Juf8i753cBvmedu1w9PVRhlPLW9iNNl+bUszrB+bwJIgpBC4uRIgQdn7zu4Tv62Puae8Mb00t/ApjS7toViaNvvi4xtJb/qN1d0kz9vXNUnQYGH1rVmgIPGrWaPOb3AVu2zELwRe5tdqxiSVY+U5VawZ9xGkhhc2hSvmYcVPTmHjyDtpSlPVT0SDDZQ3sbaHW9MH2h69Q+NLDZKL11zf//BJO7Zdy+XrnPlcoCNvjvRlU2fBF7/nmUWVoergN/1Xj2KEvwTBSoGLRHFXDGWrfv3NXps+X3g8QDT9Lo0KM5za48Ubwn6d6YNxdsJJUbFmlVb3qYci5AKBPjkcdtGRofGKyriZcVjdUO6iiOspYuErptZKz4QttnaKYFVJLu1/27r y7f2IsGL 3H6WOswqu08j+kOrOkQOxfmwmLYuvySpu72bNWJQMWm3sYyibfmkLGczYsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.010756, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/01/14 13:34), Mike Kravetz wrote: > I did the following: > > - Start with clean v6.2-rc3 > Perform echo, did not see issue > > - Applied your 5 patches (includes the zsmalloc: turn chain size config option > into UL constant patch). Took default value for ZSMALLOC_CHAIN_SIZE of 8. > Performed echo, recreated issue. > > - Changed ZSMALLOC_CHAIN_SIZE to 1. > Perform echo, did not see issue The patch set basically just adjusts $NUM in calculate_zspage_chain_size(): for (i = 1; i <= $NUM; i++) It changes default 4 to 8. Can't really see how this can cause problems.