From: Mike Kravetz <mike.kravetz@oracle.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable
Date: Sat, 14 Jan 2023 13:34:25 -0800 [thread overview]
Message-ID: <Y8Mf4f2TTH8yY8Ic@monkey> (raw)
In-Reply-To: <Y8JU8iGlu5uLGdDt@google.com>
On 01/14/23 16:08, Sergey Senozhatsky wrote:
> On (23/01/13 11:57), Mike Kravetz wrote:
> > Hi Sergey,
> >
> > The following BUG shows up after this series in linux-next. I can easily
> > recreate by doing the following:
> >
> > # echo large_value > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
> > where 'large_value' is a so big that there could never possibly be that
> > many 2MB huge pages in the system.
>
> I get migration warnins with the zsmalloc series reverted.
> I guess the problem is somewhere else. Can you double check
> on you side?
I did the following:
- Start with clean v6.2-rc3
Perform echo, did not see issue
- Applied your 5 patches (includes the zsmalloc: turn chain size config option
into UL constant patch). Took default value for ZSMALLOC_CHAIN_SIZE of 8.
Performed echo, recreated issue.
- Changed ZSMALLOC_CHAIN_SIZE to 1.
Perform echo, did not see issue
I have not looked into the details of your patches or elsewhere. Just thought
it might be related to your series because of the above. And, since your
series was fresh in your mind this may trigger some thought/explanation.
It is certainly possible that root cause could be elsewhere and your series is
just exposing that. I can take a closer look on Monday.
Thanks,
--
Mike Kravetz
next prev parent reply other threads:[~2023-01-14 21:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 3:38 Sergey Senozhatsky
2023-01-09 3:38 ` [PATCHv2 1/4] zsmalloc: rework zspage chain size selection Sergey Senozhatsky
2023-01-13 17:32 ` Minchan Kim
2023-01-09 3:38 ` [PATCHv2 2/4] zsmalloc: skip chain size calculation for pow_of_2 classes Sergey Senozhatsky
2023-01-13 17:32 ` Minchan Kim
2023-01-09 3:38 ` [PATCHv2 3/4] zsmalloc: make zspage chain size configurable Sergey Senozhatsky
2023-01-12 7:11 ` Sergey Senozhatsky
2023-01-12 7:14 ` [PATCH] zsmalloc: turn chain size config option into UL constant Sergey Senozhatsky
2023-01-13 19:02 ` [PATCHv2 3/4] zsmalloc: make zspage chain size configurable Minchan Kim
2023-01-09 3:38 ` [PATCHv2 4/4] zsmalloc: set default zspage chain size to 8 Sergey Senozhatsky
2023-01-13 19:02 ` Minchan Kim
2023-01-14 7:28 ` Sergey Senozhatsky
2023-01-13 19:57 ` [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Mike Kravetz
2023-01-14 5:27 ` Sergey Senozhatsky
2023-01-14 6:34 ` Sergey Senozhatsky
2023-01-14 7:08 ` Sergey Senozhatsky
2023-01-14 21:34 ` Mike Kravetz [this message]
2023-01-15 4:21 ` Sergey Senozhatsky
2023-01-15 5:32 ` Sergey Senozhatsky
2023-01-15 7:18 ` Sergey Senozhatsky
2023-01-15 8:19 ` Sergey Senozhatsky
2023-01-16 1:27 ` Huang, Ying
2023-01-16 3:46 ` Sergey Senozhatsky
2023-01-15 13:04 ` Matthew Wilcox
2023-01-15 14:55 ` Sergey Senozhatsky
2023-01-16 3:15 ` Sergey Senozhatsky
2023-01-16 18:34 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Mf4f2TTH8yY8Ic@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox