From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8147FC6379F for ; Sat, 14 Jan 2023 17:58:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92AA58E0002; Sat, 14 Jan 2023 12:58:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DADD8E0001; Sat, 14 Jan 2023 12:58:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C9548E0002; Sat, 14 Jan 2023 12:58:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6A1618E0001 for ; Sat, 14 Jan 2023 12:58:58 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 38BFD1603D4 for ; Sat, 14 Jan 2023 17:58:58 +0000 (UTC) X-FDA: 80354165556.27.FBEEF14 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 039D61C0002 for ; Sat, 14 Jan 2023 17:58:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uvUkpi65; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673719136; a=rsa-sha256; cv=none; b=vPHOZzNVUTJGzNKZhV9a5szg4fVHPC//I2Fv5EXE/omY50i/T4jjEFWJqk7KkLAvXPLh+v 9xPh5DszZuHgURix6wbA2sMt7zywKpvkX4uZoRU7tSZ8XVKZTe5UXjvAuMHJDUIIqiq2lW xyBlwIwgxjZJ7OgS7ee0FZ7CwvlhPdA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uvUkpi65; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673719136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LOcK5I7s4zlfeQqM7F+nIX/LNQKIkcTPp0wfB3PD3ug=; b=PtHEuhHmgEt+0Lmc9lG2hDgUFNkuPKK7vdk0bkYkxX1QhdyoQtFgg870S6Vma45mrc/z+H MMxQhXZrLvB11ZJBFlr6CFiRLrf6+WdtI3bcSjtL2KTX9oODFKXSHHoUl07P3yctvzMgS9 pkIgRjGu4cNZToUZxYHUatUt1glXCQ0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LOcK5I7s4zlfeQqM7F+nIX/LNQKIkcTPp0wfB3PD3ug=; b=uvUkpi65TEsnVBIjavFKyoWDCW tXGRd/bqF9xPQsmLTeBYIOCXOopCb070FFWQYM2h3s/e3cIvb7JtfrGoNJ5jvozzfFPMX8YSm6i8S 26UWzNU+KSf3/gB9KrmzK9u7ukzTpZC73GUVP2ebazcXKIQZd0g9RM40a/iKyH5RtLuzMCK29efLu LhYlZAMpUsn/wXTFdo3YbWJun0bAEneVNxzC2+f0ZS7TWY1XfR98vrslozmePxfNaOfRYUj7g30ET DShmBMRnEi2Rv9iHrMZ4PeDhlCgJTzwM2plVfm62R5eaKhevSPmySNd4LVmi74uqDYDPXdIDTblap VCskmg5w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGknw-007CGP-SW; Sat, 14 Jan 2023 17:58:56 +0000 Date: Sat, 14 Jan 2023 17:58:56 +0000 From: Matthew Wilcox To: Shay Agroskin Cc: Jesper Dangaard Brouer , Ilias Apalodimas , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Jesper Dangaard Brouer , Jesse Brandeburg Subject: Re: [PATCH v3 08/26] page_pool: Convert pp_alloc_cache to contain netmem Message-ID: References: <20230111042214.907030-1-willy@infradead.org> <20230111042214.907030-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 039D61C0002 X-Rspamd-Server: rspam01 X-Stat-Signature: zn5tzht715n6nmu9t78ohg941m8c1d4b X-HE-Tag: 1673719135-11957 X-HE-Meta: U2FsdGVkX18VrlFt2Lwsj3pKBfz+mbyEpYB+wYsWVHtb7blZc/tiq8lPua2eeCnogfeOm/iQcc7VfdT3yiHVqCS0soy3uRqZIMvyy8cNmNt8h7dNzzBVpHdN72ZxXJriXrWsMQ8ebdh9oXq15VqesinrNtwf3XwAKcFEk+08aGGZpT/abF8PlfF8jxgFu76s19sfmwnb07iTWbsdFouYM36mL2GfHlWNRQLB7/1QnCD+F0lBK8Jte4OFtSG0YBZ7wZcGHc9VMOXlM+QECHlNMIzbvuS+XZP5fGfGuqAuds8sr8XUqEM3iZB3eu3Qqvuzbr0UiOMp/EmQBMdfVpAc3EFZzsNbTa8LakSQPGaK7rK1UN91c+lwZpZr7+vxeZomovRNnipt62FDRC0GZkBOywCCaHng+Btmwkcm3novWKGmKVZsPTAXo4lJf87AbpHesSM8qfQQFuueO6vDN3O10wM/3dU6AIBRs4nCL+PFT8+ot9gUWGmPx/7/jvX9vhlREkqfJanAnihbJJShsgDmtARDXRhlcAI6Zvi8qjuAEAExrCc0k95MapFEzxueCJ6jkGERCygHU50q16LvSQSkVPQjQNUMulV88QIf38uBumYIcYJh4tfZBLoSBOiGo8MIhwBp/4hCgu3bscafb+KcwjSo+YJCwW8GN9cHym244FrrTUGRbR83Hzu8Nakmy1crzsZYR/JwOXrltkfl6LHpoNTt6nhvqWi0d3/jNgZsWLxdCsmbCun8e+p2xQr9GbAIG8m70BM73Ys8hm3zDrs5AzS1HeM4VQpzLUYMWL2ufoGoR6w+S410uPpV7n6GFeC+M5MoW1TM6oil0FZfsMlSCNwqIeofd748gwlZQx2N9/1MvA6+vl6ZTq0e87FlzRIkXiqDi+Cq003BfdvCvxjCeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 14, 2023 at 02:28:50PM +0200, Shay Agroskin wrote: > > memset(&pool->alloc.cache, 0, sizeof(void *) * bulk); > > nr_pages = alloc_pages_bulk_array_node(gfp, pool->p.nid, bulk, > > - pool->alloc.cache); > > + (struct page **)pool->alloc.cache); > > Can you fix the alignment here (so that the '(struct page **)' would align > the the 'gfp' argument one line above) ? No, that makes the line too long.