From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1199FC3DA78 for ; Sat, 14 Jan 2023 07:08:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F7418E0002; Sat, 14 Jan 2023 02:08:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A77D8E0001; Sat, 14 Jan 2023 02:08:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36ED08E0002; Sat, 14 Jan 2023 02:08:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 277368E0001 for ; Sat, 14 Jan 2023 02:08:43 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E71861C5E77 for ; Sat, 14 Jan 2023 07:08:42 +0000 (UTC) X-FDA: 80352526884.16.DB5915D Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 3F8EB14000C for ; Sat, 14 Jan 2023 07:08:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KSaD1HzP; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673680121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BUDKlvhazTfHjv9R6PFrCIvnfDe1GFs4w7cjP0alVEo=; b=TWgvejmgqxV4ns2fT6w3xdr626a0+AwlXFDQBmvpb5pOOS7k1jTfxvu4Ha9Mu6mfe/2Lwp EHws5URCg+TDm9Y9KtR2b21ef8gL1dgXO6/nDrFX6McL82tDytc5yQxB7P9kPsVMbqLcg5 3/hVPYiA0qaR+W/A7rCilYNrJOo1QRA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=KSaD1HzP; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673680121; a=rsa-sha256; cv=none; b=wqHIdptU12hOSSG1/pOaTBVTjgfKgmFyx7a9Gt6nCx4JOIlWH+DWEGkwRfqIY7Tsk6CyK4 7B0Bakobzb+pklnidlroulG+6zyQ4ZQnPtvZaiTCX25rIEj7gh4KcdBtEPTlrYP4REWHUr MxN63G5pDRwnZXaPaM8++7mKj/I4K4E= Received: by mail-pl1-f181.google.com with SMTP id g23so9968923plq.12 for ; Fri, 13 Jan 2023 23:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BUDKlvhazTfHjv9R6PFrCIvnfDe1GFs4w7cjP0alVEo=; b=KSaD1HzPqupZpDRkpUJW4SjosWwyEqoooZDsMowgl2G/KJqLfp7miKwkKVpW4qGnyd VY06iljPFMD0l7BlJBkpcuziusS+VYvjMM0tGUOqd9JQKMZCWWyAPsUgxzWXeMuz/MnY Adi0j1KpYqEMMdMeOA5Xy9wnoy6+52UzNbe7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BUDKlvhazTfHjv9R6PFrCIvnfDe1GFs4w7cjP0alVEo=; b=BfzUtQtVUhARN27FcomHQM+d/lafTAumnD9D6JGa/68uI13VKQIiBUFZj2cZ7ymLYg 3mzkXm2186IsRiscV0f0P3T7JRtmngD7pWTuLpTGfNvmcYxAgaQkbB8hms6E/+x5t/Ex 2uCK7VKCQptBeP+oe5LcJG6bNB2OtXgZcieJLdH0pi8BmbIbzto+0K2qbESnfbnaPN6B xoCP+qlJrDnarn9fAVyg7G+cE6uyEm/qcd4br4iZBPV6Pagw3LqgjAxBSB/BmdULFrvi LppIwJiwxVmI9CuZr3u/HaTigicGuQMbRmdG7t3J1ngoh8J4eBM0tJHQCYleaTOMn5Ik tlaA== X-Gm-Message-State: AFqh2kqa2YZQnNf4HVucWmnLMC3HD86C9p3JgV3dfQ9S6oSmJLs5NvcB xITaGRex+aL7hqVrR9qNMLTqsQ== X-Google-Smtp-Source: AMrXdXuaDDOuOsKcinz4ww2Z0nlFuaJGkyB2Fa2OsJbLyCnS//nee9j4mDUtiXjlH2+gcCVmMjwUTQ== X-Received: by 2002:a17:90a:bb8b:b0:227:1c1e:7529 with SMTP id v11-20020a17090abb8b00b002271c1e7529mr19891407pjr.15.1673680120121; Fri, 13 Jan 2023 23:08:40 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id a12-20020a17090a70cc00b00229199f5792sm2635795pjm.15.2023.01.13.23.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 23:08:38 -0800 (PST) Date: Sat, 14 Jan 2023 16:08:34 +0900 From: Sergey Senozhatsky To: Mike Kravetz Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3F8EB14000C X-Stat-Signature: tg6scisams4hycp75i7yszt6m8xr8d5b X-HE-Tag: 1673680121-215846 X-HE-Meta: U2FsdGVkX19iuNHf8Vt7uvi2pn6XKZTPKxtF40R96CJzyVu6qJwkiazHM15P3bP5kR3otEt1aLRLuRv5nj/JrNth5qLbZq3rP7fr5v1YeaeYO9+faDCFd6/88OdMBL+68phAfrJVdzM459csbcIJBn2bkfZziDYuXhYhSUeg6H3iRClxRzqyzy/yarxvIvIY53TifeE0QzZkB3mOuRJCNZkl8uwMhkoKTiWFrztJ7rdzxNIUzJYDuwLYgmamdr0OarCGHbq9IBXZlno5yfKccwO8VqlqM+eRi5N+kYBSq3EwshuWVD6SQ45/j2OunHmrCuEUhzTgitfB62O+mIOejZfspxgMHDFkSMtsKh6t60mu7OhIeYXTFkF9dQzov1mDw3a1LE+5tmCzgZvzwD9hi361MqXvxRrR3xvONeiAknnDmPoji2dsJk6NIRwvZYu/oUT2EbK/TXr3uV15lgYLbI9Dk4cqm2UDL0ItkKN0L6LOcg0lq0RV/SCz17Mh0lmcxQWKjAawg09EkBhFbIrePT54+MwHyPLAzFs5HiFKCYziPK9B+sQXrHB+Qyr8PMo63Lyd/B+tUslmkNbfX/mDEprwAlrVCWGSSvTOaJnQduQ+cJfEwI0Gy3zHaiQ8JdQF1C5OoiapwN79YSxuzj4fpSmsj0595zbBGJjSTgAZa/spC1QMXVUpX3l3LqwCSLP53DO12UDQ/Pg34ABlbp4OokMIIWfDjJopqsCeGl3XvzMoC7GCgxRqoJ7GQ0I7P1UIPNcVVYHTiIO/z3JxNPWHXt196C6f+MgfA50emlbY/QewEujREJeu9RQAiKoZ/y3yzFipPIyruG6rJPAkdBAfwtuxAnxd/FJJmz6JSABl7Ssio0Dco9oIRvO+ynutJprGPXV8Y/h5/6JStYLXOalAndeZpUQ9WGnVyEq31aF61PPeXbWCe50fvuF2Q/NfPq1+aatpy7o7OLCseT/kr3Q eBLEuQ0m /2G1edqNO3lKq2NVmTGUuFHY8ZyQf08MHd92d3cCvd0PBSHupLjbOFZm5DA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/01/13 11:57), Mike Kravetz wrote: > Hi Sergey, > > The following BUG shows up after this series in linux-next. I can easily > recreate by doing the following: > > # echo large_value > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > where 'large_value' is a so big that there could never possibly be that > many 2MB huge pages in the system. I get migration warnins with the zsmalloc series reverted. I guess the problem is somewhere else. Can you double check on you side? [ 87.208255] ------------[ cut here ]------------ [ 87.209431] WARNING: CPU: 18 PID: 300 at mm/migrate.c:995 move_to_new_folio+0x1ef/0x260 [ 87.211993] Modules linked in: deflate zlib_deflate zstd zstd_compress zram [ 87.214287] CPU: 18 PID: 300 Comm: kcompactd0 Tainted: G N 6.2.0-rc3-next-20230113+ #385 [ 87.217529] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-4 04/01/2014 [ 87.220131] RIP: 0010:move_to_new_folio+0x1ef/0x260 [ 87.221892] Code: 84 c0 74 78 48 8b 43 18 44 89 ea 48 89 de 4c 89 e7 ff 50 06 85 c0 0f 85 a9 fe ff ff 48 8b 03 a9 00 00 04 00 0f 85 7a fe ff ff <0f> 0b e9 73 fe ff ff 48 8b 03 f6 c4 20 74 2a be c0 0c 00 00 48 89 [ 87.226514] RSP: 0018:ffffc90000b9fb08 EFLAGS: 00010246 [ 87.227879] RAX: 4000000000000021 RBX: ffffea0000890500 RCX: 0000000000000000 [ 87.230948] RDX: 0000000000000000 RSI: ffffffff81e6f950 RDI: ffffea0000890500 [ 87.233026] RBP: ffffea0000890500 R08: 0000001e82ec3c3e R09: 0000000000000001 [ 87.235517] R10: 00000000ffffffff R11: 00000000ffffffff R12: ffffea00015a26c0 [ 87.237807] R13: 0000000000000001 R14: ffffea00015a2680 R15: ffffea00008904c0 [ 87.239438] FS: 0000000000000000(0000) GS:ffff888624200000(0000) knlGS:0000000000000000 [ 87.241303] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 87.242627] CR2: 00007fe537ebbdb8 CR3: 0000000110a0a004 CR4: 0000000000770ee0 [ 87.244283] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 87.245913] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 87.247559] PKRU: 55555554 [ 87.248269] Call Trace: [ 87.248862] [ 87.249370] ? lock_is_held_type+0xd9/0x130 [ 87.250377] migrate_pages_batch+0x553/0xc80 [ 87.251513] ? move_freelist_tail+0xc0/0xc0 [ 87.252545] ? isolate_freepages+0x290/0x290 [ 87.253654] ? trace_mm_migrate_pages+0xf0/0xf0 [ 87.254901] migrate_pages+0x1ae/0x330 [ 87.255877] ? isolate_freepages+0x290/0x290 [ 87.257015] ? move_freelist_tail+0xc0/0xc0 [ 87.258213] compact_zone+0x528/0x6a0 [ 87.260911] proactive_compact_node+0x87/0xd0 [ 87.262090] kcompactd+0x1ca/0x360 [ 87.263018] ? swake_up_all+0xe0/0xe0 [ 87.264101] ? kcompactd_do_work+0x240/0x240 [ 87.265243] kthread+0xec/0x110 [ 87.266031] ? kthread_complete_and_exit+0x20/0x20 [ 87.267268] ret_from_fork+0x1f/0x30 [ 87.268243] [ 87.268984] irq event stamp: 311113 [ 87.269930] hardirqs last enabled at (311125): [] __up_console_sem+0x52/0x60 [ 87.272235] hardirqs last disabled at (311134): [] __up_console_sem+0x37/0x60 [ 87.275707] softirqs last enabled at (311088): [] __do_softirq+0x21c/0x31f [ 87.278450] softirqs last disabled at (311083): [] __irq_exit_rcu+0xad/0x120 [ 87.280555] ---[ end trace 0000000000000000 ]---