From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390BEC3DA78 for ; Sat, 14 Jan 2023 05:27:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654CB8E0002; Sat, 14 Jan 2023 00:27:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 605688E0001; Sat, 14 Jan 2023 00:27:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CCC38E0002; Sat, 14 Jan 2023 00:27:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3AB928E0001 for ; Sat, 14 Jan 2023 00:27:20 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EBA0BA04A8 for ; Sat, 14 Jan 2023 05:27:19 +0000 (UTC) X-FDA: 80352271398.13.E91FA41 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf04.hostedemail.com (Postfix) with ESMTP id 47AD64000A for ; Sat, 14 Jan 2023 05:27:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AOvLMulY; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673674038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hi6SpGutrYkialV9PtuSHrkLtH3EwVjUiZj+JV18HOU=; b=jtcErz9nVJ18H5SMvewXDVPQAY2swBPtSfZLjuQM8mm0587TGKaAxFTPSjvlpmcOgfO8tJ fYYQCTC2syjsvHafAXjKpHvVvr/53W3ZD59b5Kqn5p/ernVzaIqZWFZ5VVK4iZ5TxRzs2C ODZGLYahd49Fz6GFw9C3+yJCBgeznDc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AOvLMulY; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673674038; a=rsa-sha256; cv=none; b=J07ejUp+rsfEBA4rLdeeiHDWP/mLMj9vDdO6hDfVkE8TFrz28ssrzgHWCC7FowT715UOwX A84lIBptaA0/nsi0qR+2vjXq3YrgT2U0c0xei/UyhhjgpLWqKoxjJBlp6FOCiDFZ5EJ/p8 JJg4Ou7SCFXUMk034aAKaUF+0dx9BDo= Received: by mail-pj1-f53.google.com with SMTP id v23so24357688pju.3 for ; Fri, 13 Jan 2023 21:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hi6SpGutrYkialV9PtuSHrkLtH3EwVjUiZj+JV18HOU=; b=AOvLMulYqiLdTSzTT+e9jUZEthaYWtfhs46a1EKVU3Uwb+06h44K25V+0mKVO4YmLl FQKlYMuEAAWCCX4CiPEKKIds9fom3gxOui+g2KjkLgh6vctl+W4rwYUWnJh1usm9WW5k ZhyT1p0EnD5LOTuKbmhmo3qrZvSGfAYnpAxl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hi6SpGutrYkialV9PtuSHrkLtH3EwVjUiZj+JV18HOU=; b=7v2vPWlaF/4keHYGm6BWF1kRW4Vh7uD3JkozQWDwAvxAfxFlszi8TKfIS2r1zLVBxZ U7RYYArAqc/og3XhO2Kh8Zbmc08oNe9xJepRyfnWqscLVfxCJRHWgGDM5JUdXsn7txei j4yqFP8IwULzy0fCWrBUPqi52ajkklQtWmExafFOW/4eVJ9+6R0E4Mo7BfBCul7FKLcd 5x6glJWMvVJmfoUJvIU0Q7M6ac849fwrCaf2bk9c401jzb/nMIDuAmyXu98eq3zPkzJr DmKe8VPRKUK3upyBNdRw4Y+IUdX9D/143HYcoY5s+XFiYmUVSuutyNOnvuKfEN60yh2a cFIg== X-Gm-Message-State: AFqh2kpJsd6pvhRvZlJuEdL+QNkAroumvQXyrHOBvjvoj4ahoPa5H/lb UOYhxyPBibExEzYkx7jjw3YXog== X-Google-Smtp-Source: AMrXdXtN10GPHVzK1LFg3aIeZT7yW6CksfZNv/xVmMqQdGuu0DR9yrvzw5WgzYj2vtLRtsISoIc6nQ== X-Received: by 2002:a17:902:b613:b0:18f:98bb:c08e with SMTP id b19-20020a170902b61300b0018f98bbc08emr80267513pls.36.1673674036887; Fri, 13 Jan 2023 21:27:16 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id j3-20020a170902da8300b0018725c2fc46sm14910927plx.303.2023.01.13.21.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 21:27:16 -0800 (PST) Date: Sat, 14 Jan 2023 14:27:12 +0900 From: Sergey Senozhatsky To: Mike Kravetz Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: tqprrz8nc7jf9eu4ip3fgqs8p84g5wgq X-Rspam-User: X-Rspamd-Queue-Id: 47AD64000A X-Rspamd-Server: rspam06 X-HE-Tag: 1673674038-85027 X-HE-Meta: U2FsdGVkX1+x+E6cx8FZwnm7DNPZG3W1QHxZ/fEpYpUCYicaPX4/5iPBVhmnr91CZgxI8+IlNbVubKHgHhm097TKNISj2mS4SaSZq4COtR00N9ekzdAgyfM2EaSKh3Kfg2DQMdNG7CY1iKQzWG4cPgR2FchW2A+od8JsO+Yz1q6MHaWORQb/Mf2jFS5bJicgN0UVHLRGllCKszWye7zT8Mn7hiKJuvN0gSAZUcM1mQFZSdaOQ2GcSwdTlrICBdQW8Vq0BCMmZzHZQghDvGLNzf5aQmnVCZ4cPJ4SHEqQfuMT/pUBGMu2xyLAoan/TIlNh/1c+OdTWz5M+UR+Nn+PUL9OFfexv/vNULrjqZ8FpsOzgRjGfFULG1WATYDEWMsFweGFIaQu6aiIzPEYAUal5Vdr9iopF0xLdabPpAxxD5Qr0GvxiU6kjMhwFj1i8NOPlmJDP7OSoaGPoZJvHu+hmdY3+1NzpCrF8746JnRoLYyMIadMX5YE4/v4tfIELI4q7Equ1DczBxb7ZsEc66mxWii+vkk2fWWRabDb4pNiGyu5afKjof1FFxvVrhByrnmPfFDNJyIv0/YRsgWYU/CaE2gVqKkhRCADNbSN2H9F7feqobjduEQAa9wut6ksfPyrtUbGd5twwpT0aLEZXlvifmNa02B1b4RG72g+d7kkWFZITtpp4n7wzQ5XCidgWV5nuWseaM4gepTpfch8iVPbv6URHiyGaAu2/GaWl9GWAFpqI2lo2Fxs3vMo9mjAlIeaCeYXwiVoYWktH7tyAwCkaCY2rIh3EXY4qsiY2igPdblM9oUVy2ARZGpVijqHkdw9h5JVF1dZNjRszVAH4flXGaE91Yz+lFdmolpjuyQ1eC6DXoFgN2lL8CUXV0R4gzqBCp9KT8yBuUEPA0npp1PlQ9tUfQWNsBNTjbhtIajJjieHUF3dy5kffBWq+3cz/eygjJcqhsG6yKobraMkdah TZus4VwB 2OW/Y/q+PTKmL0yBOmWeSPQ+Q9D9XHvLtgkMmuVuq4VdCzKNgTnAbqbuGqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/01/13 11:57), Mike Kravetz wrote: > > This turns hard coded limit on maximum number of physical > > pages per-zspage into a config option. It also increases the default > > limit from 4 to 8. > > > > Sergey Senozhatsky (4): > > zsmalloc: rework zspage chain size selection > > zsmalloc: skip chain size calculation for pow_of_2 classes > > zsmalloc: make zspage chain size configurable > > zsmalloc: set default zspage chain size to 8 > > > > Documentation/mm/zsmalloc.rst | 168 ++++++++++++++++++++++++++++++++++ > > mm/Kconfig | 19 ++++ > > mm/zsmalloc.c | 72 +++++---------- > > 3 files changed, 212 insertions(+), 47 deletions(-) > > Hi Sergey, Hi Mike, > The following BUG shows up after this series in linux-next. I can easily > recreate by doing the following: > > # echo large_value > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > where 'large_value' is a so big that there could never possibly be that > many 2MB huge pages in the system. Hmm... Are we sure this is related? I really cannot see how chain-size can have an effect on zspage ->isolate counter. What chain-size value do you use? You don't see problems with chain size of 4?