From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F6BCC3DA78 for ; Sat, 14 Jan 2023 00:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA6B48E0002; Fri, 13 Jan 2023 19:01:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A56878E0001; Fri, 13 Jan 2023 19:01:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F7A58E0002; Fri, 13 Jan 2023 19:01:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7FEA78E0001 for ; Fri, 13 Jan 2023 19:01:08 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 46125140733 for ; Sat, 14 Jan 2023 00:01:08 +0000 (UTC) X-FDA: 80351449416.11.6DF1383 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 9916D100006 for ; Sat, 14 Jan 2023 00:01:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AKE7gl1e; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of seanjc@google.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=seanjc@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673654466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pnZMr3msysr3F7hQXLH7AQBYvEUMLHsk9nNkCMpDY14=; b=nv//mMuzOh/yLnxiUVc+smT7lqh/5yRMXjCiBSWQ/ZC5355HBmHUUSf2BNoYS+HxsT2fWC LCb8SMY7zo+qJCIFR1zuaJHWMTtbDkQcWFcssZGerXyi1nL3swQ4f3xRbK00RoLSAXMlqS pl9gSRpDvSICbt7exAuX0B0XeT/rZZM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AKE7gl1e; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of seanjc@google.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=seanjc@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673654466; a=rsa-sha256; cv=none; b=21uMdeMm2MXoQ6WX34urIGyfnTNyfSoweyepKW1Za8nfEUlo5cvaSdGeRgEsrUeOIIT28L wMTH6B3XUC3OZws1+TR19TWzjqnPdSZWrOBdE1KZ1aftjdU+Gop+de9y++gMWCE9a1dBfj frV3z5aiPsQ+I6zOihFb8wpahY5XDls= Received: by mail-pj1-f53.google.com with SMTP id b9-20020a17090a7ac900b00226ef160dcaso24192834pjl.2 for ; Fri, 13 Jan 2023 16:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pnZMr3msysr3F7hQXLH7AQBYvEUMLHsk9nNkCMpDY14=; b=AKE7gl1eiHLqGoN0SnyVqNEPplEIwVO+riNAN02PwmozMjE2L10QCVf4rXYqWYXwrc nM+dfsbEmjg4aU4wDbXk81gsNGcxDwcFMrhjKV0dxv5tgPv5HRD69rmvva17U2MwBylu ox8qjH1cD99q2HmCdnSQ0OAN2PKSiP6XIZtUS7wpznd/WxqipSgn4SXTj5GoK28DsB/h /h+/U8gm5nSazzO1cze9VAQXTqkUirpJW7NcMgscsM2IWWic/84oK1838Dl2K3mrzzcM +5+ItvAPTnRvsTbhTQfUPMUE3qPaOrcvkhrQopsnh/lwNWCnC0CJndMiYCyxUMoXegK5 gjIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pnZMr3msysr3F7hQXLH7AQBYvEUMLHsk9nNkCMpDY14=; b=3JnJlSY24uNE3Bbza/4r4esnXag535/kK5DaITHdeU52xtGY/TLTDXAEv9IR5CkdHe nvWzOSQ85ZaQO/KYSqRudhR1eZju/cz6Hnem8S4ETIE0/PJGllSmOwMglFnxy4oUrl9M EpZSXhr/d+Wgj4fLcw8Uw/GDQLFCoDXTLjMh7WvnKJ3EjO7EUgzO4Z7G2ZkK5gOC+gxv fnVD5gfh8jgh1ByrQWIxzMbDuM/KA+CQlqWOgE6agxzw8wayDr2ad3wHkqcuENl6XiQY OzYdK3nALyWJWgfivWDtaolX9imc1KNB/Wz4zixBLFT5qDsodDSPJNYlGsvxsnEkObeV 33GQ== X-Gm-Message-State: AFqh2krlE9+KpdSxBATeUxkBtCBYVLNaBKOBjImWQL8kYrJwk5eXSPR2 gb7xw0mxbefQchbgc1bHRLcmGw== X-Google-Smtp-Source: AMrXdXvNkNwg47euRwsow9ZzGgWEDAGEi69lwgz85sCYleqYo1kdNQOKNRaLha4U2UlUoVuWv9B/fQ== X-Received: by 2002:a17:902:c409:b0:194:6d3c:38a5 with SMTP id k9-20020a170902c40900b001946d3c38a5mr516748plk.1.1673654465280; Fri, 13 Jan 2023 16:01:05 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id k7-20020a170902760700b00192bf7eaf28sm14649057pll.286.2023.01.13.16.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 16:01:04 -0800 (PST) Date: Sat, 14 Jan 2023 00:01:01 +0000 From: Sean Christopherson To: Chao Peng Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE Message-ID: References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-10-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202061347.1070246-10-chao.p.peng@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9916D100006 X-Stat-Signature: b8h6jbe9gpgeppsqu3dge6dg83uscnws X-HE-Tag: 1673654466-375577 X-HE-Meta: U2FsdGVkX19Pg1tmzAij1ii/VPa2w+SThxzmpQ9yulG8d0To8uC4pwII2fhRRC3WysnZ0gfaLq4O8trLJHlIXCJlQyF+sPEBkxopSR6f9Fzx/T0ByKheJT3DrQ4JslJaUsjZUAFVQthMvN4PTpuasu89YquTfl///RpYUzXjwR1MeKd7UCB53qQlKZZQd2ZAQQJ6ENboEq7lH4aHmM7HSPXzBigQ/5sKNRohohEYDQSQxs6frmmpYLuNYsqv0woq4zym2qR2Xyv8c1uuN8Utqzit35YV2bNHLPBFzTdc+cJVXYJ9VuaGlaEd7xdgYwbErseiw9z0hVWwGbAsh06RiN2M/UB/buIZo9ZPdZNQzUYuUuz3k1pFkJzkY5bQrMR8D4IHkYEiyxgRv5l982NEikajUf5vtIBwI+Qmte/TiEpFSRAH97VkDK6+LChOyidAe+DzLQBRnJguIlqpw2Yo1RFHoUqczO3YBAAT843ZtStcsoBz+v3H5Fjlxtbz81zXjTw+oGTDC6T9h6+9lDRRzq8G42kJQVL6DAiHFcziMLlWzWmTvL3ayxhZPuiB4vOwxbpwlt0BPcux33CYXvOPeRzU/Ayw7rPfoWILwbQ9TQViFrZx3Jxhh2i3y28MDpxnykiBqhV4qbS1u3yYYGk0bKx/LMXGBBIhleslwNRO5jTJ7E4uouIA0yKUJ8UCDssXZH+sL1D/37B72Od67LxHroOZ4gno6pNfofRTgIK86BYuAFqiUG/b0ndR79SqubaqVzakIzAs0DqSrbH0v6Q9m1/jRKqZKC8akmfcUZ/iVo67Q/IbCBojXkRGHu2ETSz/SGhsQhxU5WKBXkZJP7pkLU20qh0hY1jH9n9HbHYbRMFPJxvV0UH06vkmFy2jAAz43fa68EpEFN+Vjvn7E2FjsBSib0FC4l5Qo45NY4cyJk4QHCvWTHuNyc8/px6RDcM3rV+eK0a/lFUukt078CM T7fyAKXx I24/be7+zJXvrsHpx4A8R5hDxtnzr071CfXg5SxjiUH+XKat1oDhYFsORbcPJCq1aI7p9taECwe2WacxYbMVD9TExfW7BRLmrI8+MPpKF420S2W/wLCKzPwPHJB77mCFl5e92ehlUvh+G0Uk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022, Chao Peng wrote: > @@ -10357,6 +10364,12 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) > > if (kvm_check_request(KVM_REQ_UPDATE_CPU_DIRTY_LOGGING, vcpu)) > static_call(kvm_x86_update_cpu_dirty_logging)(vcpu); > + > + if (kvm_check_request(KVM_REQ_MEMORY_MCE, vcpu)) { > + vcpu->run->exit_reason = KVM_EXIT_SHUTDOWN; Synthesizing triple fault shutdown is not the right approach. Even with TDX's MCE "architecture" (heavy sarcasm), it's possible that host userspace and the guest have a paravirt interface for handling memory errors without killing the host. > + r = 0; > + goto out; > + } > } > @@ -1982,6 +2112,10 @@ int __kvm_set_memory_region(struct kvm *kvm, > !access_ok((void __user *)(unsigned long)mem->userspace_addr, > mem->memory_size)) > return -EINVAL; > + if (mem->flags & KVM_MEM_PRIVATE && > + (mem->restricted_offset & (PAGE_SIZE - 1) || Align indentation. > + mem->restricted_offset > U64_MAX - mem->memory_size)) Strongly prefer to use similar logic to existing code that detects wraps: mem->restricted_offset + mem->memory_size < mem->restricted_offset This is also where I'd like to add the "gfn is aligned to offset" check, though my brain is too fried to figure that out right now. > + return -EINVAL; > if (as_id >= KVM_ADDRESS_SPACE_NUM || id >= KVM_MEM_SLOTS_NUM) > return -EINVAL; > if (mem->guest_phys_addr + mem->memory_size < mem->guest_phys_addr) > @@ -2020,6 +2154,9 @@ int __kvm_set_memory_region(struct kvm *kvm, > if ((kvm->nr_memslot_pages + npages) < kvm->nr_memslot_pages) > return -EINVAL; > } else { /* Modify an existing slot. */ > + /* Private memslots are immutable, they can only be deleted. */ I'm 99% certain I suggested this, but if we're going to make these memslots immutable, then we should straight up disallow dirty logging, otherwise we'll end up with a bizarre uAPI. > + if (mem->flags & KVM_MEM_PRIVATE) > + return -EINVAL; > if ((mem->userspace_addr != old->userspace_addr) || > (npages != old->npages) || > ((mem->flags ^ old->flags) & KVM_MEM_READONLY)) > @@ -2048,10 +2185,28 @@ int __kvm_set_memory_region(struct kvm *kvm, > new->npages = npages; > new->flags = mem->flags; > new->userspace_addr = mem->userspace_addr; > + if (mem->flags & KVM_MEM_PRIVATE) { > + new->restricted_file = fget(mem->restricted_fd); > + if (!new->restricted_file || > + !file_is_restrictedmem(new->restricted_file)) { > + r = -EINVAL; > + goto out; > + } > + new->restricted_offset = mem->restricted_offset; > + } > + > + new->kvm = kvm; Set this above, just so that the code flows better.