From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C953C6379F for ; Fri, 13 Jan 2023 23:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3C9C8E0003; Fri, 13 Jan 2023 18:16:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AECA58E0001; Fri, 13 Jan 2023 18:16:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98CEC8E0003; Fri, 13 Jan 2023 18:16:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 88FE98E0001 for ; Fri, 13 Jan 2023 18:16:35 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5084C1209F8 for ; Fri, 13 Jan 2023 23:16:35 +0000 (UTC) X-FDA: 80351337150.01.29C0480 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf27.hostedemail.com (Postfix) with ESMTP id A322D40010 for ; Fri, 13 Jan 2023 23:16:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="E/wbWTkG"; spf=pass (imf27.hostedemail.com: domain of seanjc@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673651793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aWow72s2ZHPfyutUF3LRtthWGyQvB6TRG4mGrzQPS+Y=; b=s5fG+QG7IhfP7epGIe49OzWDhQPcaddUFw3baVTgyXVJMd0I0tFE39refhLUuUuOg6n5rO CIH8wByH8Z2N0dRTWTXWs2LOhO0O5vLpDbQMVlEt6ij7LQ0tmLkprM/+TJKR+NMfuvGDrw Tjg0uCosLV2MQ3nvNf2RGakp1VFP438= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="E/wbWTkG"; spf=pass (imf27.hostedemail.com: domain of seanjc@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673651793; a=rsa-sha256; cv=none; b=1vJKH8dHHstqVO6fIEvGTxP5I5Plo7iGKdKlLJpqikeHumP264BBAeOgDxkshBynq6aS7a Nktw9+mmarN6fSMKO9zUEa3e1Y5VT0utKXM7LhNc3+PdhVPpi2WSRMHGCVG4/NsXViuGQ4 IYQujEVoe1nSn87BHISTy24PlYHDDI4= Received: by mail-pl1-f178.google.com with SMTP id b17so17411076pld.7 for ; Fri, 13 Jan 2023 15:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aWow72s2ZHPfyutUF3LRtthWGyQvB6TRG4mGrzQPS+Y=; b=E/wbWTkGCcwoXs6O8irB3PXyBwoRW4uEkWDuoU13XByhJzTvIiq4OfNzvKMYIxRBd8 N5dRvUnnXxuGkG1NqPLQ9NcLguZ/hQembSMTLovSWxd/eNEA47F4pw2VMvBTgCh83EhX bKzfh13CLYQPbU31yNkCeE7nVtvWxeSrEzOQXXJn3Ra1e263z8sIZrm9ZwC48e/SEbDs 3aEzaEkItlDgZ56c4opqTh+L6mEGkhcrmVBFbTe1hFC/UfsbAkExmK+Dw6Q5zVDBQe5Z vQO9KR1KEhsZRidc5t6FXrTt3AyPbDNocZckiEhBhgfdJEwaG1EcApBlL60GoZCzvH2P EHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aWow72s2ZHPfyutUF3LRtthWGyQvB6TRG4mGrzQPS+Y=; b=fCTs8kNiA7BpxVwPykGw/M8daRsMGtIyfN9ED6GLGCU7FxOLpDPcOIJMoIuWcx6Uqp a9xyt3HyVdJAZTBuOAWeOpir+UycsCB1g2TlrmG1cNnJqt/Goju5ygyYAEpv/XMjrRWu ORY+FJoof/YgltrXo6kD3piW8St0QO2GKhlOUfj92t9pFu8jJYN9Pntf/rnikWBGJTTy ttLzL2MNPCJGdo0iAG2JeWAaK+JMUywLh4oEuLivpy9rVqAwv5nz9Fvd7EEHsVZuLv03 2jrYOTKqGGMqbDrjUakZU0xtd3ILP3/zZf7xjzVp6r0XCmU5mYOrEtRXMdFRJPChHWBN co0w== X-Gm-Message-State: AFqh2kqGvE2sp0ZwMWL0vSzBV7ZFlfEXx3Sd88pr7XA8G6Lp8kRSOXdU J24cPjGxu6FN/2nLj99Nhmgl0w== X-Google-Smtp-Source: AMrXdXsw5eR35BhM0SQtUTPreOToQACUohVatv5rPzW7S1K5nzUfkKmIR6WQPAlOT0G0H1aK7d4JHA== X-Received: by 2002:a17:902:c409:b0:194:6d3c:38a5 with SMTP id k9-20020a170902c40900b001946d3c38a5mr502925plk.1.1673651792454; Fri, 13 Jan 2023 15:16:32 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id q3-20020a17090311c300b0018c990ce7fesm14720017plh.239.2023.01.13.15.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 15:16:31 -0800 (PST) Date: Fri, 13 Jan 2023 23:16:27 +0000 From: Sean Christopherson To: Chao Peng Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 7/9] KVM: Update lpage info when private/shared memory are mixed Message-ID: References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-8-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202061347.1070246-8-chao.p.peng@linux.intel.com> X-Stat-Signature: zgk71dxsdxkuah7t3bik4nubdidy491c X-Rspam-User: X-Rspamd-Queue-Id: A322D40010 X-Rspamd-Server: rspam06 X-HE-Tag: 1673651793-474725 X-HE-Meta: U2FsdGVkX19+CIxnowpBtnXw/gNyvDTLBuxnWDUc/l5SE4Do4IaFh6N96Fnq9AeMO8RCtBWf8c9lJyrvr6fwn+QZIT2PR+Nf4MuCk2wb+1fK+fyYy37/3lynnURvm54mEMiB1grW4eFcVEXy9Q/KCPld0bOLEKZ+9gkyVVBF+Qm8GCa+dLRolRBMBECFTPzF5jvFR0grNXAQQNZG97GfMkg+Tx2SaUmmv4G59VHsdu0cIM8BeGhWzYmCA1oDFfjaM+8KyMxD4WKR/lViuQ3wgR4/aq++dLbKSMRPaOqO6sIY/SZGzmkeHKuHBDigrT7BzhhC+f90BrfOyOTXHdDZId0otzcXyBjBN97nkpZ3rXAg5UNa/g9G/uJx1FF9fvIpwbc/S+1R9LjgTZui2p0Hd/vG99gvpb49D1j+FzZdClQhli57tSyqH8E7j9JShk5KK6aoR2R9NWjeuuHoKgM0fr9go4LjuUqZobCVBBi7UptATAqcHkfh8oq4Cz/Hjt6VEkT0FZOkyngQWO5bkbqWy2lparA5T4YyKSYKbeRZ98YC9t3n1hGAOKyQHb+zDz9u4l6avduyj+b5tOF0ptmu3g/lAQY4mqEHG6aOFvOL2QroY2kmTi6v+D8Tk0nFrufLi3nm6qBOCu8OLou2zzetNhXNljVeZ0o+Km5OClgXdNsgdq6Qrg1Ebvjfx1Z3S3VeyMcKs4c1AUFlMWtSWtJd8oEWR34aVksom7J69bSWIv8J1ho1nbnOvOfTUarp7J4F8jcQw5Ul5HGt2JxpEuG8EDn0CZ22AFVekI8JEaDKURbV5z+Lh7PJkJZy7UEapW2CCBXX40kjCvtN2iBZUD1IoD5utak8YCIv+z8rT5OFJuK8jHdrTtRXJD7pLefT16mFol1D4XbQnv9IJCWCwXjUgZ/cX3SRCiTR+3LpFfPyKlnJS/3te2wrt1yriCz5npwfe2iq4LlUqorJRBmPfyt YzA+jQdi ajiULOaHmDXGMtsVuQJy6mEOavv48XPR/HqYei+yJhP0KNmtE3l7JwK35BiAnOhvBNW9oSBkWh4hXORvcXwnd8nDOkTSP+gDVhakV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022, Chao Peng wrote: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 9a07380f8d3c..5aefcff614d2 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -12362,6 +12362,8 @@ static int kvm_alloc_memslot_metadata(struct kvm *kvm, > if ((slot->base_gfn + npages) & (KVM_PAGES_PER_HPAGE(level) - 1)) > linfo[lpages - 1].disallow_lpage = 1; > ugfn = slot->userspace_addr >> PAGE_SHIFT; > + if (kvm_slot_can_be_private(slot)) > + ugfn |= slot->restricted_offset >> PAGE_SHIFT; > /* > * If the gfn and userspace address are not aligned wrt each > * other, disable large page support for this slot. Forgot to talk about the bug. This code needs to handle the scenario where a memslot is created with existing, non-uniform attributes. It might be a bit ugly (I didn't even try to write the code), but it's definitely possible, and since memslot updates are already slow I think it's best to handle things here. In the meantime, I added this so we don't forget to fix it before merging. #ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES pr_crit_once("FIXME: Walk the memory attributes of the slot and set the mixed status appropriately"); #endif