From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1F7C54EBD for ; Fri, 13 Jan 2023 18:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A2128E0002; Fri, 13 Jan 2023 13:45:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 352748E0001; Fri, 13 Jan 2023 13:45:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21A4B8E0002; Fri, 13 Jan 2023 13:45:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 14DEB8E0001 for ; Fri, 13 Jan 2023 13:45:47 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D21991604D4 for ; Fri, 13 Jan 2023 18:45:46 +0000 (UTC) X-FDA: 80350654692.03.452479E Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf09.hostedemail.com (Postfix) with ESMTP id 5CE33140003 for ; Fri, 13 Jan 2023 18:45:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=KkTKgtpX; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673635545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sc+QG3doHwqi0KguHc47jtnXuzD4N0xuhyE01g5Z5bg=; b=Waj/KRGH5SWvKin47e31RkjVkPnSjax+SV2oj1FV9mFivWQB3gmoxTWHauVvlwZJ181BBX Smm93y3/O5YCKPXwsTSAQ5xb2fw+/i76dXXiKLOM8VYusTY6badgNoyVTphbAMo5/dAsU5 T9+hmMtWv4f/Ghk13K2L48a9qMdBYGo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=KkTKgtpX; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673635545; a=rsa-sha256; cv=none; b=I9+HbsIm2bZ+f+5kZwei4HZjS+nsuJX/oZvKf7xI7LYTS2QWUu9/Gi7A0GSf973bvLtbGq Q29x8XJfXO1JlBWSNKgodPs+sRlPvlVW88RYfW+2KIXU/M/tnXHFsve/JevrNtR1lGOBoP SvZ4yjSxcMTmZJbheZuGwUcNHZS9f+I= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7E2DC1EC04C1; Fri, 13 Jan 2023 19:45:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673635542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sc+QG3doHwqi0KguHc47jtnXuzD4N0xuhyE01g5Z5bg=; b=KkTKgtpXF0EoNPZdUlHiGJscFtirH/VYZkaDo+EFyCM016NeLitJyZPiqAZB+9dCR7thC+ 0cKvCiL13pgYtqZlUpt2N0IQmyUnd+Mfg7Wq7bnAHSo6NKJxjfwN1S/dxzuDKC/6rkacC9 zo62ADSjb3WSAJtj+GuSNEB9wSoaC7E= Date: Fri, 13 Jan 2023 19:45:42 +0100 From: Borislav Petkov To: Sean Christopherson Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com Subject: Re: [PATCH RFC v7 04/64] KVM: x86: Add 'fault_is_private' x86 op Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-5-michael.roth@amd.com> <20230105024256.ptujtjgzcdmpakoa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5CE33140003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4mah6xus3ccu7menn79gk4y9bh9jr9gp X-HE-Tag: 1673635544-522492 X-HE-Meta: U2FsdGVkX18UsTOigFpuk/IxrPi4P1ZzIjUMgtBHdl3FJTWw2gZlAEbVS9Q+ClDhfGXL7FIsf/RttPF0AcB/WNHBWL445DIJI4/VUwa+X5nHwGj/nyGvwkKLdequ1PghD6uKy+C8JfRYrVA1s+h+dzRTQsmhX8cMfYWM9rA/EG3XkqJ9OTxUhEV5UOJBzcMa5UBiEo1zXpim98svYB/UhQSL51zDaaZfntehaADL7M5r0sS7FyjXAwW9M4cTVsE6OAhlOsI7j2fjYBbf9EZhqMY7KQeicos//rIZnjWtKF5gBgINOq6FvrMzBqB0XOnrH+wWMiB+ab9cGrnzNPAItPRGf2hwUJAtodFofeJ6ZNMPoSskrImObpRclQ9ThOTyU9zvc48WDEQvYYPqeeyQmz5+ObiMtMCV4LwprTDg/y8DG1TqZ89Aivv3rImJa0GaJ0baBrqwmyil6c5nQLgizT6lQQNCb/xNBLqwV4noqjD7mvQjePI38jNzcjmWw06CE2k9DK73ZqGJHDfOIe/Q8rijPGWInKYrL1QzOmEsLhEH0lmWRclGE5ZAkau5SqV8c+d+t4Cqg8Ht9gxj8dIm3aPZXzjTzW88zNslVpAgdvHCIp+1KNE6UN1qf4c6/5LtACx5/NzWts1j9AHuDfO4q8ytgfs80SobWfq4tvrMPtX8Pg0FT3QYS9Jg+wz9gFLy2OY5/zhj+d3vwCG/3q98oh4gxSDbGE6uNGLrijWMVWpQRnEizbYWenMIOdneQgPLjF+s70xKfmXSsnZhw8eruNGLWA5DRoZY2aCkZMcCP8jmBdbN0XERpEixkq0lpZBwuR92j3bDlClS2q9GrdUUXTGVq/7a1QjTQaj1fwFONsyiUwBbY+R9BtXjkqqVRWB0EZJfHDEDxM764jLS9uHG0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 03:48:59PM +0000, Sean Christopherson wrote: > Ya. Don't spend too much time trying to make this look super pretty though, there > are subtle bugs inherited from the base UPM series that need to be sorted out and > will impact this code. Yeah, I'm simply trying to find my way around the code and no better way than reviewing it. But thanks for the heads up. > I'll circle back to this too when I give this series (and TDX) a proper look, > there's got too be a better way to handle this. Good. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette