From: Matthew Wilcox <willy@infradead.org>
To: Yin Fengwei <fengwei.yin@intel.com>
Cc: linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com,
ying.huang@intel.com
Subject: Re: [RFC PATCH] mm: populate multiple PTEs if file page is large folio
Date: Fri, 13 Jan 2023 18:13:17 +0000 [thread overview]
Message-ID: <Y8GfPeQkRRT8kNFU@casper.infradead.org> (raw)
In-Reply-To: <20230113163538.23412-1-fengwei.yin@intel.com>
On Sat, Jan 14, 2023 at 12:35:38AM +0800, Yin Fengwei wrote:
> The page fault number can be reduced by batched PTEs population.
> The batch size of PTEs population is not allowed to cross:
> - page table boundaries
> - vma range
> - large folio size
> - fault_around_bytes
I find this patch very interesting. But is it really worth it? Most
file-backed page faults are resolved through the ->map_pages() path
which is almost always filemap_map_pages(), which does something
fairly similar to this already. Do you have any performance numbers?
next prev parent reply other threads:[~2023-01-13 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 16:35 Yin Fengwei
2023-01-13 18:13 ` Matthew Wilcox [this message]
2023-01-14 0:58 ` Yin, Fengwei
2023-01-17 9:19 ` Yin, Fengwei
2023-01-17 10:37 ` David Hildenbrand
2023-01-17 14:46 ` Matthew Wilcox
2023-01-18 1:41 ` Yin, Fengwei
2023-01-18 14:05 ` Yin, Fengwei
2023-01-18 0:58 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8GfPeQkRRT8kNFU@casper.infradead.org \
--to=willy@infradead.org \
--cc=dave.hansen@intel.com \
--cc=fengwei.yin@intel.com \
--cc=linux-mm@kvack.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox