From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C85C54EBD for ; Fri, 13 Jan 2023 13:59:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A79A8E0002; Fri, 13 Jan 2023 08:59:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 030968E0001; Fri, 13 Jan 2023 08:59:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E12D18E0002; Fri, 13 Jan 2023 08:59:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC8548E0001 for ; Fri, 13 Jan 2023 08:59:40 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9598140C3C for ; Fri, 13 Jan 2023 13:59:40 +0000 (UTC) X-FDA: 80349933720.19.9AAAFA5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 4170940015 for ; Fri, 13 Jan 2023 13:59:38 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZTAU6Pkn; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673618379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6kboQ5MB7uZ6CHhRg2eIn8RfDMDJ2TsZf8BKVulus5A=; b=bIm0UUDPRfuGZOQDOywpk0SFH9O4PvGeyIJr8rEKAGMT5ko4QYqLXJA2PmVL53AX9trWY5 3EGNp9ICPgXUoFlIPxU2Xk8ToXzHSfFD94LL8wBy1wszVvG9cDKzU66v+9jMEQmBtu4zgN du5Fr6gSkALJMJKcJanNf7UNnQHzEW4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZTAU6Pkn; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673618379; a=rsa-sha256; cv=none; b=bXBZMfP4+pjZNTHd/zXwIfe9LhkWcIvYYHq8ALQKMZHuprjEvB3b/dB8EhK/nV+P0o5/mR u6Vu+s8Z6/cDJnRSmC3ykfNZsTwrn8T0TAD8Ru+wtqV6RFqOkW9L513zxdzjqpioTJBRph YV9qTWzhGw0zN0M8dea2h3BqRfrby70= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6kboQ5MB7uZ6CHhRg2eIn8RfDMDJ2TsZf8BKVulus5A=; b=ZTAU6Pkntpy8KSSflFMFJA3/gN HcJPCQ631UoV2WzEQqkqBBRdS27YRmIkPpCdYTrvOnvUolnOaXifUsp+2b65sxHOta8lGzjoSrgwc VoSKLSh3nfRimYnSzPZMhWamT1YRmRsOHkw0bZUjWOfDVFlNWWwxGnl+cZN82szTQepK5g1XbHefy mG9Ety+ssNpJsCiAOr9DXLXTwbjjzOKeKgWyPWaeanvE0O03P9LaO2HE/NsKmu40ggOiM3aFQzL9y Xpvc8GJqBrxfKlsYsKrpyUZemhy2q4fde6o8PQt6HQbEIjg3vIwA6dcFY8bGeaBQk5vjXxAb/J8tk QX7/er3w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGKaj-0069DE-CO; Fri, 13 Jan 2023 13:59:33 +0000 Date: Fri, 13 Jan 2023 13:59:33 +0000 From: Matthew Wilcox To: Bagas Sanjaya Cc: yang.yang29@zte.com.cn, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iamjoonsoo.kim@lge.com, ran.xiaokai@zte.com.cn Subject: Re: [PATCH linux-next v2] swap_state: update shadow_nodes for anonymous page Message-ID: References: <202301131550455361823@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4170940015 X-Stat-Signature: i3tkqrwez1e7875toip96wfzkshcstgi X-Rspam-User: X-HE-Tag: 1673618378-723882 X-HE-Meta: U2FsdGVkX1/ck2/75jUvkaR18Dgs3c7iRz+oWwKXtBf0C/mgWDfIIYVcFs22YIHrPkHXJGprIfTiq+1KU2YZBz62dsIHuB6BMYOKXqa53E4Qg+qcRuZlvV2EjI7l8r1l6Ft4ByTkk6dAdkOZNSZbtrhHRCBoZbovV9+UqwDFuBylOM+Hpa0tvXFhUlenZzxeub073YJGBAQjp3LtvpQBITBHBnQiJ9ym01bcNAYnUD95Rx3ZuT0OP6PoW+s3X3UZh+KdFhwMo8Dxz41Y8xGXyS/Kxk2aJJDlfLzYiFcDN5tCmZqQCPRNgh9B59Y8Xkh+5cWatXhR2kciuXNZK9nw6qIbi/auTUHiZxCxt8dQmEAhR40iqUBrScsdr6CSM/mxOBO4fNScxVlYKA47dbua5xjbFSQ7SBwj3cZcWDJkPBjZSyYC/BgHqfAI2BoCjq3jHSTMPVqyiDKbpP4/QOWJoJroO2sU7t53hg0rC2UtF9gOthm7LYk2SQP10rvb0dXVwjXzQ0IK0cQlKlInPrMR2IGBOk1AL5kPfBBiRHc9dcXiNew3ePnNjlTLURPGTaA8rl9YIpcf+e/k0RsEirE7FQ3iQPqqXnJkILjhpZ35TIugoTZlOZg6FDSFBN1sl/B4h1NLc6WGEzqthhNQ7C/qlpfA9k5WEDSkKDzvJH3ZcSDBvUlbQbT6JgD5boQ48df1n8Nwr4oZoWZcAquanHaYHI51ReVXm3DRYf7henDeje9WQqgXqyp4kdpN/gpVIuWQDc7U7adgvHYw76e0gMlz2jWq4gCJ0AbvcpBp1jaPKq+GyX1fwkVpCDI0yEC6ICziaJrarsU3oOIPks8+sQhWA5NG1HXgNgpnr/4+fgnaOIfa+tIr1MKskYoVLFJ4zbGUbVL3d563EG4jRest0TJgHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 03:47:31PM +0700, Bagas Sanjaya wrote: > On Fri, Jan 13, 2023 at 03:50:45PM +0800, yang.yang29@zte.com.cn wrote: > > This patch updates shadow_nodes of anonymous page when swap > > cache is add or delete. > > By what? This is not a helpful question. > > @@ -252,6 +256,8 @@ void clear_shadow_from_swap_cache(int type, unsigned long begin, > > struct address_space *address_space = swap_address_space(entry); > > XA_STATE(xas, &address_space->i_pages, curr); > > > > + xas_set_update(&xas, workingset_update_node); > > + > > xa_lock_irq(&address_space->i_pages); > > xas_for_each(&xas, old, end) { > > if (!xa_is_value(old)) > > Adding xas_set_update() call? It makes perfect sense to me. > In any case, please explain what you are doing above in imperative mood > (no "This patch does foo" but "Do foo" instead). Not helpful either.