From: Matthew Wilcox <willy@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: yang.yang29@zte.com.cn, akpm@linux-foundation.org,
hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
iamjoonsoo.kim@lge.com, ran.xiaokai@zte.com.cn
Subject: Re: [PATCH linux-next v2] swap_state: update shadow_nodes for anonymous page
Date: Fri, 13 Jan 2023 13:59:33 +0000 [thread overview]
Message-ID: <Y8FjxV4gWiBw8o5l@casper.infradead.org> (raw)
In-Reply-To: <Y8Eao1l0qRVLKK7e@debian.me>
On Fri, Jan 13, 2023 at 03:47:31PM +0700, Bagas Sanjaya wrote:
> On Fri, Jan 13, 2023 at 03:50:45PM +0800, yang.yang29@zte.com.cn wrote:
> > This patch updates shadow_nodes of anonymous page when swap
> > cache is add or delete.
>
> By what?
This is not a helpful question.
> > @@ -252,6 +256,8 @@ void clear_shadow_from_swap_cache(int type, unsigned long begin,
> > struct address_space *address_space = swap_address_space(entry);
> > XA_STATE(xas, &address_space->i_pages, curr);
> >
> > + xas_set_update(&xas, workingset_update_node);
> > +
> > xa_lock_irq(&address_space->i_pages);
> > xas_for_each(&xas, old, end) {
> > if (!xa_is_value(old))
>
> Adding xas_set_update() call?
It makes perfect sense to me.
> In any case, please explain what you are doing above in imperative mood
> (no "This patch does foo" but "Do foo" instead).
Not helpful either.
prev parent reply other threads:[~2023-01-13 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 7:50 yang.yang29
2023-01-13 8:47 ` Bagas Sanjaya
2023-01-13 13:59 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8FjxV4gWiBw8o5l@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox