From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAED3C67871 for ; Fri, 13 Jan 2023 15:49:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C96A8E0005; Fri, 13 Jan 2023 10:49:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07A0D8E0001; Fri, 13 Jan 2023 10:49:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E83FE8E0005; Fri, 13 Jan 2023 10:49:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5A538E0001 for ; Fri, 13 Jan 2023 10:49:55 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A8FDD4031D for ; Fri, 13 Jan 2023 15:49:55 +0000 (UTC) X-FDA: 80350211550.06.51CAC5D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 051ED120009 for ; Fri, 13 Jan 2023 15:49:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X9t2JmdQ; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673624994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DfT9q9lHXCcgDHj3l3lHi+8c/GVJ6aWRtQZ+lLWf7NY=; b=GVYf7sZ4p8EZu3iUUZC0Y6KB6KCq4k6b6nC0f/+rX1zAMHjkc2QSyjIgP6bIlLdS3MAFsx 0lB3fZo6qVvNk377SitjlmxthAWUl5WIcyuWLT7VN4GSdt4MBwtpNqTVB/AYiPa1Ivhx8Z Tgw1xd8MaNIzPl7c1Rq9xFxzPdXrzD8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X9t2JmdQ; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673624994; a=rsa-sha256; cv=none; b=dF3qQtxzm1k+RnqECLtIPlS+kxMFbaPIcQlTCC4B/l5IHhGRmVpi+DGYsGDZX0+QCK1cHH ibKLIIGX4jQ4odoH+RofmsPexXSsVjVqaXX0qEWNlAIhllVcbJrFAttnwEzP4DB+4iDH4l wowJ/wdtdtpo59nutc99BQSGjp/PmYw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DfT9q9lHXCcgDHj3l3lHi+8c/GVJ6aWRtQZ+lLWf7NY=; b=X9t2JmdQaeUH4e+OTEXdJApJ2c H8l5getZ8VtJbbGhMqAZHqAUgILjmF2UCOp40bGNbTiMVSmPn6pNzXaY+sHTHHQRMeiOXEiHHfrX8 SL1zzfDhfX8AWeh5yJnhIbLPqmjTi7e/Pd+VnmrGK8iV3usDOqP0OtrZLqk3scBdv1vxrbv1vizif kK9cu8Ty8sywVbbaTx1xZjWfrrbdsLGWmj2rFGxW1Xa4tSq3W0gEZsrzm4n379gkUKanC2A+NLCZl OEHVCMVVTtQQCOtoKDPyRCEe/lwZbOupiMMO3iHDsDjnK5YR56tkTJtAwEh34m1ux6/sJROJLvStu n2GneenA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGMJg-006DgR-BH; Fri, 13 Jan 2023 15:50:04 +0000 Date: Fri, 13 Jan 2023 15:50:04 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle_swaprate() Message-ID: References: <20230112083006.163393-1-wangkefeng.wang@huawei.com> <20230112083006.163393-8-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112083006.163393-8-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: b9n11jybnikpzte676bnr183kuu8bs9p X-Rspamd-Queue-Id: 051ED120009 X-HE-Tag: 1673624993-373770 X-HE-Meta: U2FsdGVkX1/iCVBFklxejFeqy6lfsAc33ja0narPzC5EVOFzRQOzaM/DYZkF350PEtsfZDyTgsTTYVvvAvx5jUzUgqSAG4emr4b8Y4lloA61Z80Dth+/Pgihr/n4hmDndxZsrK91pOb9n/5o4l6KiP8hzyO7v3ILGebYsByKLkqncngn0p3JbM8pJbXeMhLcrdhY/LjB9AJPnHtIw9YMQ+SiXcYGYLdokGQ+CxpmrZ7r8HVEZ2u546pDD6W2JkmYXZGObTN6r1kSGtD03ER3SlAkqYMvBXmLCjb8wxiFmbPt1gIXUcQtdYSBI3e+l0krT8ooiDZydYre2rF6pVEx1ALefS6NTZWCYU3tWAiisDYws2wtW2W2cZmml2jFkp3CPiibdijCPrYwlu3KzqRQ41OW31F1hgwml9NIIFCCLRu4Lc4WdR/ErCWShwTRgHDi5GiFJE7csvhDzy4Q2A8qx8EfVX5xd6TgFPyJF9jcUeVAfS/LGMOP5DkdUfqRfqX+wNxwZo1M/eh9KGx+z/nJfe3RAV2VjTOaTdJ28jxpNCMSevyr2Qfp4uCduNfST3K0N2LfOVetPEkw2VLrLy3VmpEcvmWrngQJCVCTHokHcQm+YucvjkolNul1XQUSxaUAgf/7Jo4jt8Bynnyw/aOu4vdbAboBaaGcjsifuHKWAD13xfErK82vxx8sfIrJ8jUwxQ8xMQtcO16C+yGYPkY57qW9hUws/GEOQTqkMME031rdA5LiCMkihEAcwTcCPoMugl/Wu2Y9qvwlUDDqWJZnYIDB1l4kz+0rYC1v/Jwe/LIlPkDzHXnW+/SkBy2rWKeZ50dv8OWEWTETsK2lEHwFTSIno9eXM0E3LuvOPRZh1KMAztzqj4gO1YYRAYxIC58TA6POwDgEDYcVH7ihMN65KQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote: > All the callers of cgroup_throttle_swaprate() are converted to > folio_throttle_swaprate(), so make __cgroup_throttle_swaprate() > to take a folio, and drop unused cgroup_throttle_swaprate(). Shouldn't __cgroup_throttle_swaprate() then be called __folio_throttle_swaprate()? > +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask); Also you can drop the 'extern'. > +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask) And it's not a gfp mask. It's gfp_flags (we have this mistake all through the mm). Or you can just call it 'gfp'.