From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA496C54EBE for ; Fri, 13 Jan 2023 15:36:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16F7A8E0003; Fri, 13 Jan 2023 10:36:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1201A8E0001; Fri, 13 Jan 2023 10:36:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F032A8E0003; Fri, 13 Jan 2023 10:36:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE47B8E0001 for ; Fri, 13 Jan 2023 10:36:58 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A81C8AB247 for ; Fri, 13 Jan 2023 15:36:58 +0000 (UTC) X-FDA: 80350178916.26.51EFB0C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 3C17B80016 for ; Fri, 13 Jan 2023 15:36:56 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ePzihjjY; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673624217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ggOkbzb2S7+qH5Fcr8YUMXOVLwxMkbp5ZnrWSch+hlc=; b=u+11FRv13EldHASpgtbHkotDdsLEOvfckzGJ9ae9+eQQHK8dwkwiaIxaepj8AyJYTSWsLa oChG9cFDyVTyIxj6N9wAdm5m1QCGaToncAebUmBuylWKcArsjgyIYnK6Npuxj24QWjtH+/ 8/w3LHjs879jX7kEtpPeBvNsKXaFHdM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ePzihjjY; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673624217; a=rsa-sha256; cv=none; b=K/jr4esGTI8VA4s6WE1HMmbViYNPGVNsm5vPP79gagWcEFycoCqlDIF/7/3JGUAYhk1SYT cnAGSf4CtAR1EjL/zw7tstvHZRdVSMLf2JoY46ftRP0bUdzqBOqBwPowGsI5tSqiOvtY8h hQ5iRTowGYwXynnWT6YHiw6bp3+hDjI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ggOkbzb2S7+qH5Fcr8YUMXOVLwxMkbp5ZnrWSch+hlc=; b=ePzihjjYQFkujbVarL4raFGxs2 2UFLjM04Ah+XzR8ZuLRPlWN2Fs4IjxXJJ0yW2Zq0dwQ+kPF+wZU9x0oRYYpJ38TesS81D4VTimdwf CyqMwNHs+NI4SpnV53MQ9WOTwa8NHYCGaucO51bmvIFDNVE+XDP5ykWsRD1e+Izkpr/sIeGGwmP/5 edSt4V7qEkn6kRGljjV8yFI4xxuROSQqqznydbnbISO7Mw+XgovQZkPgcAwH9g42vWrdzIezH9Cl8 6hfi+E/NGo9na1oftamdOjHL0OJPc5EoxYEkO4AXvT+2PVPJfcl12m7AsCgSISAhNYv/rKfHNcFOP 5FSBS9yg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGM79-006D9n-IQ; Fri, 13 Jan 2023 15:37:07 +0000 Date: Fri, 13 Jan 2023 15:37:07 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 3/7] mm: memory: convert do_cow_fault to use folios Message-ID: References: <20230112083006.163393-1-wangkefeng.wang@huawei.com> <20230112083006.163393-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112083006.163393-4-wangkefeng.wang@huawei.com> X-Stat-Signature: fcznm8n5gdkb6j6p5m6gg1yerr5ctafr X-Rspam-User: X-Rspamd-Queue-Id: 3C17B80016 X-Rspamd-Server: rspam06 X-HE-Tag: 1673624216-986531 X-HE-Meta: U2FsdGVkX1+ih222CflFt6IRDLJu8ZnQSyqqKjXk1E+8VqjO9Xgep0dDJYdg/R3xF1JS332Tfpm1g/gVTxETIeqaH//LeHsw5DMEF6FLcw3JSTVgJAgzLRgwwNymc7ibUJkzM7myojpymzcf5HuWIKvLRDhGiFQbqp4F5+d4pJHKzFxZiL1oGNl3m/hdhnhFQtpp4/hnfII7T2zkbIEfqS3mHbtnP914fxgmM6+2txvFGwRMjslkrXv/alFBjxbyfI8lRDXqPZNHHReRC0x52pDZWBi4oybaLNG0pioylO4dn7hdVrLKIZGgJ0rhmjhwHTeD3Yuufn67vKnlvz0tGR/SJZaVm6HwJdmtjTcxQrOQJTO8zLux4Y1O/kqfn5bFr6Lg8lVL3FggiOZ7sv2Kgk6Zv4gA8ItC2TQEQvKLTmPZvST7P1zUfVQehSHelUXVFiBcY6fg+n/yvT1H09faBXaca4S0dfd4djcEi6PqewX9shSJBsrscd1NiSWy1m0wylEF3sYME/Ywfexkr3+24uCw5WGjilV60yUXDVvF77v54Hqpo8XX0NFQXS9n1Fbjha9+q0HR+haNXK8lPMn9+2ASFeplOVqx5MXuht5fSAdIpKruzMEoJvz47wQBnJfdkcfo/Gfvuum1x+rtWNRwcq3Yi757xRYvO+Xgb4MX6tfre9rC7i/QMbMaDpA2ieMDAjaVBIC83ZNk7YSk2hHxKGb1scCI1bSEw2ctyjsxD3kgBOzCQLQFDMQp7X94rrJSx3lVxZDp3KzdsZICdZm6Lif/0PjJmhp8Mmlv8tDPa0Iaa+fvpZfp6EnKocP+QlOm69oFF9VUUFOY12Jw2M0WS7sO7CJNyxvc7u39G6PzxEXV8hXArwZ8WkZr5/UzqNyhqyMAnMLzZkGHYAkYR0mcSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 04:30:02PM +0800, Kefeng Wang wrote: > - vmf->cow_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address); > - if (!vmf->cow_page) > + cow_folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, vmf->address, > + false); > + if (!cow_folio) I have a patch I've been sitting on that converts vmf->cow_page to be a folio. I think this series is well and truly wrecked at this point, so let me go back and dig it out; see if it still makes sense. I'm a bit unsure about it because maybe we want to allocate high(ish)-order folios on COW fault, and if we do, then maybe we want to align them in some way with the virtual addresses, or the other folios in the VMA. And then we might want to indicate the precise page for this page fault rather than have this page fault be the start of a multi-order folio.