From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8717EC54EBD for ; Fri, 13 Jan 2023 15:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBCB38E0003; Fri, 13 Jan 2023 10:33:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6D1F8E0001; Fri, 13 Jan 2023 10:33:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5C128E0003; Fri, 13 Jan 2023 10:33:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A90EE8E0001 for ; Fri, 13 Jan 2023 10:33:14 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 79C2FC087C for ; Fri, 13 Jan 2023 15:33:14 +0000 (UTC) X-FDA: 80350169508.26.05949EA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 1C5E340014 for ; Fri, 13 Jan 2023 15:33:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IKHZjnz4; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673623993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zRXwQ9oqAVYSWzO7WrEZgPVvSq/p+4hxA2jZXOARcaA=; b=PmJn7JSETS5lZTqkYUbf4W7wASbgav8qqwtV72soCrRwJvGuRMOcKc/N/kMJJYCHrcFQvT LtEtDrY4tyRX8yYWQI7z/YeqtrJ7fZrSKh1dAghhsdGrPEkT+Rd3byiu+PoDuI8wJlj6+f dlSqhPrE/hixkyM3bQHcVFVB0t9xjkc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IKHZjnz4; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673623993; a=rsa-sha256; cv=none; b=PbYYralXv/9cGtQjKg/ERM2MGID24xmCDwZ5c9GurSisn9RVcqvq1C2abeqf76Q3f0K5VE AmL+K5ULvM3UzvtUSUUAh1DiZlrA9OnmqPPmTSEagIJBLFsaV4Ke6zq43jdJDpVLxb4Wx+ V6GYoZod/i+Yd69B5SU1aaWZBB+3t4g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zRXwQ9oqAVYSWzO7WrEZgPVvSq/p+4hxA2jZXOARcaA=; b=IKHZjnz4pPCOfgTft+0liESi2f kKsDMVi9+ddi0BQxyoKLBdrKMKLTpQ3UFyYHdysj91Vidl0LsX6Vtc9cvXCV7v4NvXCp8KDGmzdOp xeokBIMpny4z6sCyjZlabpSSos0apHc5VCgr7VUsya6qepDL8kN1H26sQnSjDZ6eCrm1XC9AW96t+ n/eqEysqbghxeJhivzSZuCaVoVatsTv7HCVrx4iSeBnBtJhaaCUuB6kQbB9jGl6vE3inaQziDKi5U NSQKzgKntPuWHy7ScL/fEaQskGlqAksBg0FBVqfarlEyXsStguWuw8fwqGsi183l+3QS1IPuBjNSG YZmtB/bw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGM3O-006Cyp-EH; Fri, 13 Jan 2023 15:33:14 +0000 Date: Fri, 13 Jan 2023 15:33:14 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/7] mm: memory: convert do_anonymous_page() to use a folio Message-ID: References: <20230112083006.163393-1-wangkefeng.wang@huawei.com> <20230112083006.163393-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112083006.163393-3-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1C5E340014 X-Stat-Signature: tiesm9an8ew3ciib7q173g4zadko64b6 X-Rspam-User: X-HE-Tag: 1673623991-732870 X-HE-Meta: U2FsdGVkX18A3OwH9Rx9apoXM7UKiPexajjaqG390uECq3VwRtSyYzsopvy8TICZ/Z5Ie3bVgx5h/da2JGV4/eo1XZMZj3e3IN8f1DmmM4I3VeneyGdVv4C5kylTgOPKzcxnwtuRmA1Bam8vdXiUq2911Sf4Ng6JUKhwf2SSrDaCzH1C46IYyhhhqmupZCLGvHvzaPlOQX7yDpf7ftHPFJlljmienr+jIskpgotS468KLUidEkFySU1dD4kjzVHtgMIGWJqShEazIefkbNCkIKfOzNUaP2qb36wJw1r6/uq0EDzKL1NorIbpuO4e70vlsOUGO8IaJXRFsyEHc+QSHn0vTjqswYOx3CP45ySZ8luPMLQAlGIx8fBKcPcFevxJZ/aTayCz4ZZiD8tZn1kMgNuh0eEyCEAJjImaYbUEXvzuNPdWoDiau1v+BvfOFoRg7Im2dHgWo12f9oofVnvb3fAyzXDLqstwAUnpunwSDYUyfQLP1D4OIlQyS4Ho66wqKPI2nNsWi8oS0CjbmakDbRXcfT/Gj1cAIONFonl5Wu72GlhYynNJsti73lxdARFWc2XSOatr0Kv5nZxzX/hFqYk75vxHwWpHG3vuH+G7TPAXUQLj7x9MeCYq/fzIulbi+aWQ3OJLliCCKuhM5gzJgiG+zq5QbHqWxympfw691XxbKaX3pgFGhZ/KAPJjwcHT5Z+NML6PbJb8Om6Wi6VAtO6zdpsnGtJieeRmTUxShdORNMp1Oy4CcUo4FctFRNKop2Q3Dl9bAA8LxT9uAyo+Ao9PfO87S7peZM958D0YFOuZNrcHrFyYRjWy0bIz4kxa87h4I6dnSo7f9TVtxUh5MYMfWE0iT/be90mkqRa1lXuBojjojijKmmffYgOrqkpdr8wKMT79qQCeXBfEvznDBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 04:30:01PM +0800, Kefeng Wang wrote: > Convert do_anonymous_page() to use a folio and replace related functions > to folio functions. I think this patch has a prerequisite of sorting out alloc_zeroed_user_highpage_movable(). That way we can get rid of the 'page' variable inside this function altogether. > inc_mm_counter(vma->vm_mm, MM_ANONPAGES); > page_add_new_anon_rmap(page, vma, vmf->address); folio_add_new_anon-rmap(). > - lru_cache_add_inactive_or_unevictable(page, vma); > + folio_add_lru_vma(folio, vma);