From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A9AC54EBE for ; Fri, 13 Jan 2023 05:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B7B8E0002; Fri, 13 Jan 2023 00:26:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B9C48E0001; Fri, 13 Jan 2023 00:26:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A85A8E0002; Fri, 13 Jan 2023 00:26:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 479498E0001 for ; Fri, 13 Jan 2023 00:26:53 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 18CF44070D for ; Fri, 13 Jan 2023 05:26:53 +0000 (UTC) X-FDA: 80348641506.28.65B892E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id D4C5C100009 for ; Fri, 13 Jan 2023 05:26:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KNt+kaL9; spf=none (imf05.hostedemail.com: domain of BATV+429392e802db0772f8f4+7082+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+429392e802db0772f8f4+7082+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673587611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u6svsDv3oPWCvjudHdQlqCOrFDk6O3xm8BGo5fakt5c=; b=S+7OOhoKN9SXOFgENNbVHdX3psWBmzzfCtWC6KY4u7vGNmSH/4ASl3SisdE6lx1Xt3XrDd 6MXS+0NcKc2v9hf0vMFwfQ1UEaE+pGU7ecFskMwuQnfTMO4Ll5l8lSYYqW/1sAcFYoRsKc GHj8xitx+Kgj+h3Kp4WZzK8ukrfezcg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KNt+kaL9; spf=none (imf05.hostedemail.com: domain of BATV+429392e802db0772f8f4+7082+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+429392e802db0772f8f4+7082+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673587611; a=rsa-sha256; cv=none; b=ri2d0DwZI8xAsACYKXiLmy8yJjuiyefEYe5yBNxICD6u9H6uK6j/VZ7wFDivFPglYMdKMQ S56zyzQAeej29VRrttNrBb7jEQKoxkCOrSMrEsjWbQkGrXs+WJRa0dt5KSPvLAgSA2Zw+Y KoUtIcQzHuZRAC/Cj5ECwgWWT051fuk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u6svsDv3oPWCvjudHdQlqCOrFDk6O3xm8BGo5fakt5c=; b=KNt+kaL9IbofAf4FmOV2p0jmO2 KviAq8o+wi4QQVov9jCIrj6U+6brA6mRic08K1Y2tpB9yJMyQq2EPYZ0zPfXf+IDz/D/PLdOHZmIS 7Z85UbD94tOm552z4CxOYzo0SHvDSp/L//wlZcos9lbz8Xj+24Iu6id18I6GU5RAC1VxdWFr5tnZh y+rcTSWRJH9zjdjpVluK0YoFs05Zwqrd5UrzKMnFBIvSt6rXf3Mop7n8a2bZO4DXXB5kFqXOLvmsC ViTQBlANr/J/qn9T5+2zQP4TRnpxHXQrXz6mFYTAP9aQpxiWR13bpMdKv8Em4eKb6f/AmUEvoZ4/u t8NCnQKQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGCaK-000UfJ-It; Fri, 13 Jan 2023 05:26:36 +0000 Date: Thu, 12 Jan 2023 21:26:36 -0800 From: Christoph Hellwig To: Al Viro Cc: David Howells , Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator Message-ID: References: <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk> <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: k8tqgb9emz5e5u6j4bqf7i6cuphywiiu X-Rspam-User: X-Rspamd-Queue-Id: D4C5C100009 X-Rspamd-Server: rspam06 X-HE-Tag: 1673587609-571341 X-HE-Meta: U2FsdGVkX18R6GeZA2U4tSV9FF1CvvKswUIlEdZk7K0DT/kvYIuCTUDdbinWFWyrPSnCE/c3NGERNWZ6SWVJYAzZByhtLNafQQiUZGCBMI3BIaUZZblB6Q/DMNP3JOSieHoMCY5Vso2CP41NKZUM9b6ntS9q7dg5Y5lvUrm2z+Cogg8/csq7iPAsdPYZipjA/aOQUgazfjpJ6SYEqEMZlKDJxImlerxifNkXYzIZU5f6M1AoVhbcFyOLRCrAsLAfmDmsyHhpD7YvjRajW02Jxq5XdqvZjUku6mXOVNBtZ+r2be46EBG06kBvSIsfThbXOFoJkZHctFqskpdinLT63ouq4RSKWNi/szX3LnQ8zylnVq7Ravu4qQQze6GAjevZsfK3t7A5NaB93xrhC+dKF4ef7UbUorH4wMw2KDeTM15VV14qgOlglVzSCdQQGm+NI/WabjAmEvsoQdDfbCOW8Xf6ThEdMKaL+Z0Kf2NfewGGTVXxv2lqVz0j0tfRtJc0sVzAj2/UMrXO8pOmKvCsa6GnSUWmXLVxWe3xGirDQsfkuZa+yUmWLVybNo7vpsdHD7PEfXviXe9qtFdWkdv0PaSSQULfIi+jw9FiIWJnBDrLB7GIuQ/C2YYI5sX9STudNZT7JSZ0YlxnoiT9kyxQWNrZaIVa8MUlK/1ydkJfOFTVdNq5IR1rqTo9OBrcgctEMcUjNeHlS10Y/WasLOGybHsyPiCLiGqTU+8ed3XV3vwn9gGvjtkiARcKBd8EX105XH3P5L6/1W40X2/vX7tZ+icc/jakEcKRSCCIIFOI1N/rQh4krKpjDr7WagWZzT5uL7tXm62BJrYROOANGCRKi/hP1ticIRBXH51vefdLVQELKuAwgZzSttp9OSbF/pVLTuw4B1jZXOLSWU4uAbS5GIkcpfhK1xcmC8vPepLc8KZiAvAGy0AWzADW+J5YXJbtNK/EqqEzlswL5mGowiP FbpNMEWZ Lkflk8SEOLx7tGfffIGDooAvoZEqdcGfx8o2RqjrK9Fuq1fr3LyFFH2SuAxj5jKRnD+ew56pp13wZemoRMdsT7XA1ATjMzamMElnfItp/EV/rHU8xbEHsj5/O/IfxjF0PCSXqASNbs6j+vBjGU/WXy1oOHl9efsr3JzYj4WM+xu/btx98UQyf2BGTPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 09:15:50PM +0000, Al Viro wrote: > This cleanup_mode thing is wrong. It's literally a trivial > function of ->user_backed and ->data_source - we don't > even need to look at the ->type. > > Separate it into an inline helper and be done with that; > don't carry it all over the place. > > It's really "if not user-backed => 0, otherwise it's FOLL_PIN or FOLL_GET, > depending upon the direction". That would defintively clean up the bio code as well..