From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387B3C54EBE for ; Thu, 12 Jan 2023 20:29:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 962168E0003; Thu, 12 Jan 2023 15:29:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9104E8E0001; Thu, 12 Jan 2023 15:29:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE308E0003; Thu, 12 Jan 2023 15:29:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 702868E0001 for ; Thu, 12 Jan 2023 15:29:49 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3718840E4C for ; Thu, 12 Jan 2023 20:29:49 +0000 (UTC) X-FDA: 80347288098.12.6FED209 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 2B2F8C0012 for ; Thu, 12 Jan 2023 20:29:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZQcgPjxH; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673555387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ut0oHZmUlSfWhXqfYECviDD2lPh/AxfnTisdiH5avRU=; b=P83wgX+hyyu4Oxr//vi4ECLCBD3HYTg1wQdxJMs+9wU6M8aV6fBw5mZFyUzpEbAcQnR8Gn ozOkxBMBCZNNsM/GwfPg2JKJjGFdcZqpLlIqoDfdXTvMN2KZ5AON9ogxdXsYOiJACGnctV QJ1hgMbCv6f7WbQ0zj++BZDmRLJSrRg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZQcgPjxH; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673555387; a=rsa-sha256; cv=none; b=4BKGSzhf93ucN4XciheUbCEqzGtNOq2wNRPSN/shLXKF3WO08nnBD/6FhKXvA3n1ephvT5 FigExOwVTnnhK/Ro9Au7N/DnF+M3lBvWJn2O8DP0papwdFUaDmxRvC0quRgTA3MiVsWbEk DCNscxve+RAFcZK+xh3kgD+0TRlI2aw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ut0oHZmUlSfWhXqfYECviDD2lPh/AxfnTisdiH5avRU=; b=ZQcgPjxHaCEk/Lal32rwDDMJ/Y 08HVaIlsTyAt1AuAJY3Z19GSABtssiTOb9qBOFa2BPwFdDqQEuhZEtkR5oxAwMLzcYYwGgxCpIBPR Rh8kI9Bi7iBw++y8ObLRizfZgNv/JOSvyvfC0xd3qptwfYJ97qTeerTT7dss+kwHyr6A4eP8FhAII IZva3xCtS3gppU6kQxwqfYU2PC2hRvs9yIvt3IhY49oDM/A9DocOuL4RWBR6G88onJNWZcJIamRL1 6GUTy2x4Vr7/6d3AZv+WVpmBh8Lwtbej9ynQ6mzY7NoeMDw8NkKlk4gSPQDrA9IJcGXDRXcJvEJ22 H5ANJGjw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG4Ct-005RyA-Ub; Thu, 12 Jan 2023 20:29:51 +0000 Date: Thu, 12 Jan 2023 20:29:51 +0000 From: Matthew Wilcox To: Shay Agroskin Cc: Jesper Dangaard Brouer , Ilias Apalodimas , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Jesper Dangaard Brouer , Jesse Brandeburg Subject: Re: [PATCH v3 05/26] page_pool: Start using netmem in allocation path. Message-ID: References: <20230111042214.907030-1-willy@infradead.org> <20230111042214.907030-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2B2F8C0012 X-Stat-Signature: j558cfzkpscfcnpseuh55qimcm3gsyes X-HE-Tag: 1673555385-538598 X-HE-Meta: U2FsdGVkX19qhjxIKOnkfuLLFUG7J4qVntenXMDMuho656AsQOAUaddFsrDR+PNyw4iCN8LONjEQkPGBwRkV+XwktvYkPsqzmN4X64fICuQceciEIOJdIbu9XSpRNGuzfnVbNQ0qZ9NOtRDdls8EEqxfpmnVUrsK2/junfUa4mxlBH5vPRWbWJ3gJK6AUtwrZzrcSuuGfPRoSe4tozWBWiJKCfWfObVlFVupG6r1PbCUEuIKKwec8MxJABv1kcOdp5CT6dvgTFz2cfp7+KccFhGPw9WFPpI9zSzD4o/5NQewWwbXSHu8g3/ZABzWhSlZxdgFrovuLceiXHwpIwuRj88CgZF8ickavV45laeELcHJ2cwzsh/GokNUSXuaIZGynGI8lZJ5A8By0/6rKWfgIjwDIBCOUmNXT5dltAGRAafyoDGVfKnyRk8DcV1i3cKO+gN1UgItGkcvAYPnNrGguMSqVXMvQ+6RUZJQjiv3BWCGkVvF7Dv6ZuTGIlmvQZohyg2HxkGFyOBXOFjukDBQAOg7PcHUAyUU9tDSAeJGuvcNxM8z+5Jw60TGDuC83H9EthT+H1+f2N3I0Ln0GjeJkCzuz1+Rmrb0L6+UobpmSSK2FPT+Fk8QCbfdOsvX96HQgOa7oEcjrds3eLYLLxwIAqix8VmHwR4nGN40aClXZDzqwXvzv7+eocVdinS3ZmJsO91f6mWjfAXcOIEp5bi4bR7hvdsPdpjzA/TXD/KKC/gGK0mLtOs3G1HMz78wVzJckGZqXsp42jsZ/WF1ypI0AiPdPIi4qNmg6KFFaqfJLy9CzEGdbLhGgp3WQU4h5P8CDrVi+yO0NeEtSxSNt4TWsvBPrpbS5ffZncdKZumil+uwrKMF+zyiMXf7AYdO/NqyRMo3xBT1DHs5q+OxNLxJOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 05:36:58PM +0200, Shay Agroskin wrote: > > "Matthew Wilcox (Oracle)" writes: > > > Convert __page_pool_alloc_page_order() and > > __page_pool_alloc_pages_slow() > > ... > > TRACE_EVENT(page_pool_update_nid, > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > > index 437241aba5a7..4e985502c569 100644 > > --- a/net/core/page_pool.c > > +++ b/net/core/page_pool.c > > ... > > @@ -421,7 +422,8 @@ static struct page > > *__page_pool_alloc_pages_slow(struct page_pool *pool, > > page = NULL; > > } > > - /* When page just alloc'ed is should/must have refcnt 1. */ > > + /* When page just allocated it should have refcnt 1 (but may have > > + * speculative references) */ > > Sorry for the pity comment, but the comment style here is inconsistent > https://www.kernel.org/doc/html/v4.11/process/coding-style.html#commenting > > You should have the last '*/' to be on its own line > (again sorry for not giving more useful feedback... then again, it's a > rather simply fix (: ) But networking doesn't follow that part of coding style.