From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3190BC54EBE for ; Thu, 12 Jan 2023 21:16:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93D388E0002; Thu, 12 Jan 2023 16:16:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89E788E0001; Thu, 12 Jan 2023 16:16:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F0D48E0002; Thu, 12 Jan 2023 16:16:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C26F8E0001 for ; Thu, 12 Jan 2023 16:16:07 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EC2B3140314 for ; Thu, 12 Jan 2023 21:16:06 +0000 (UTC) X-FDA: 80347404732.19.44423C1 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 8596E180016 for ; Thu, 12 Jan 2023 21:16:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=NO+Ca+4p; spf=none (imf24.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673558165; a=rsa-sha256; cv=none; b=OkPNMp4gyNkZ7V6sKR9+I3jrs3ho0ibBZrCWdXTJ1vQw9+fpHj5fuzcGZT8eYdhD6GeM6g A2bMhqdG6acT1nhPHnUdYN+FHe0oCWNExqap4hktgdqIJxGV9YX4afxj5kRWoq4piIw4+q nQjQrSTE8wTXRd2n3FV9shrogSOZzTg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=NO+Ca+4p; spf=none (imf24.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673558165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mgdwqYrKEs0wRNGjZq0hKD7IgBnja7zUOIc1FWuUR30=; b=ej1ow7IyVLba3iZbT4xJ8dVoWW5kV05PcnGehQ7M1m4oPsFw1gxsmI+iE6qi0rn6NlpHze PwZdJue9q4sbzXHiaxETP4VgoSFS7ThdFXwMbbjYuPba58vsQjX/FlBcUmv+lDLULsjDua ESFAnRuEUrOXxTY7QH7bD3XcofUnM0A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mgdwqYrKEs0wRNGjZq0hKD7IgBnja7zUOIc1FWuUR30=; b=NO+Ca+4ptuLtw+D2tpMoaIL+cC fIf4BreZay/H0EwopveluCLrPzqsijXsTEyNM75IZ5H1vQSYeG5u5gmmyIQrlDZledZlgOwE0YPD1 ayKvWyF9lLZKA/9sFT7Njn8sEYRy8byi59tfzkG9qTrHRN9P8iHM/FYoGGUmsMvIY/hceyCAu40/z uxmYf33HVSF8nO9MeKY5PwmoUpYeJQhj3GhMLbUjzQn0nP+DXYWMuzJeyfK8ze37Lt3CaMp6Hfeej yOL7H32eTwV7QPl2NglZXEAZR9wPLDdLy1fvNCJCDMwJoMW+ab2uKpCCC/5ndcqQjiVwUd4lBWhfW BGiJBuEA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pG4vO-001Yop-2R; Thu, 12 Jan 2023 21:15:50 +0000 Date: Thu, 12 Jan 2023 21:15:50 +0000 From: Al Viro To: David Howells Cc: Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator Message-ID: References: <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk> <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk> X-Rspam-User: X-Rspamd-Queue-Id: 8596E180016 X-Rspamd-Server: rspam01 X-Stat-Signature: oqwsidbwn75kjxk1ggyr8zsibj9wr8we X-HE-Tag: 1673558164-398131 X-HE-Meta: U2FsdGVkX1/o/ED/2juf2Wvgr1Q+2YYJnMhkhO1M9ZR8SOW79gF677vB+eNTkvnUEsxhlUXsfaCAmZY1o58+6bLJhbBsOy1snx/tcjJ+49dOQYAvp1Yd+1++VRPwtWfGggw8gNy1koiBLXrW2ylfK5WiXKjPpIYizroW+rappog1kB7nSYKl5Roy8QKrJzJD86ZShe4R55ZDMHLFUooAbO86X1RnWrzbmIlf0rc43N1YbEuV4FTrPIrJXu06p89OdBiilVcSP5PtcuNxLr/xA3IvzkVNhRNGMXMnOWdTuKtJdisN/NUc40YgJKwJ6y/QrzgA7oLQgS9YdL2fT7BFpKcFMrdV8AugePlDJaPTvNa2VuvBIYOpAytmdG5V82dBjSnqjYlnw76mw6mfdoNFtfLGVJKuYM5pPISz4sJ9kG1hkJnDhERjiQY+eyHcr/18SL1XPP5u2f5A6ue7M6bdeKrJVRI8rEl3MXw1g3JdCyIMSLWkcc2nJIDfkoWjU78iup8V29l0xpHQPZn8vwiHSZwVcXf7mL+BamOLyjVoZhZG2lk4ANa23CvXhRTzCtHhCnVxX2VdhOe+cIdQa9Cryj0zKjf5XNxMQG9kdtCmjojbqAVOQ/VsSRPmhuSA3zWXeXIqL2fDP0Os569OXiFU5K7sp2pYsohR7FiwxQqQ1gggQnvr7XL63d27gT1nQlkoSE/IBXhpYkhlga/RLm52ZbDhe5/AtJUEtPqbdAW/GLl+qo/+SWckzXcepmgdjxawkS8TEXiSVy2qs7GS8MH9CJ3IVJu57usH9oyxEpjwfuwTMmtOeO0T2LVCp/3rgbk0UC9b5H2hkV5KXDwige0QVJqnBI80+ipdSfKKdbA+l/qnvqvne8ANuC1OhUlh0UtURR8Pp+3zPan1E99C6DBNzG5m1AfB2P0uoEsgXlzwKwu4JVSXI969TRt45BPQfFLXEpA9ZdoovcJEhgqyTY9 w+p+Vj5k gdQooiCuMYFUKlytcSI+1+1tbpKSsayZNw/bdPKzw6VxxcZtDaEaVOXl1W5hD/Ihn+kwPub4cynkNJHNQWARTNglhLbqiDq6SJh+AL/G9yS/gra8cS73EK7oe2S3PRh8VwTn53/usr9k2S68= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 11, 2023 at 02:28:05PM +0000, David Howells wrote: > +ssize_t iov_iter_extract_pages(struct iov_iter *i, > + struct page ***pages, > + size_t maxsize, > + unsigned int maxpages, > + unsigned int gup_flags, > + size_t *offset0, > + unsigned int *cleanup_mode) This cleanup_mode thing is wrong. It's literally a trivial function of ->user_backed and ->data_source - we don't even need to look at the ->type. Separate it into an inline helper and be done with that; don't carry it all over the place. It's really "if not user-backed => 0, otherwise it's FOLL_PIN or FOLL_GET, depending upon the direction".