From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F390DC54EBD for ; Thu, 12 Jan 2023 13:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D4888E0002; Thu, 12 Jan 2023 08:16:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65E188E0001; Thu, 12 Jan 2023 08:16:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5257B8E0002; Thu, 12 Jan 2023 08:16:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3E6CB8E0001 for ; Thu, 12 Jan 2023 08:16:50 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 184201C5C6C for ; Thu, 12 Jan 2023 13:16:50 +0000 (UTC) X-FDA: 80346196980.17.9BA258D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 90A0A40009 for ; Thu, 12 Jan 2023 13:16:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ivO/Hzfp"; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673529408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zKBXSuS/0mrd++K5B4B9sqLRDVg+207ZHUFlsubT1ho=; b=lgXn4m3E7fngxbsnkofLEI2M6adxTLvhYeR4p1uo0L53KZacCocD1I0q9STR/wnWUtfEk0 708YwnLoODEaiJc7hAIdMTO1AnwtIl+69t+qNQIz5EgQ/Fmy1dkMYbMzrbSYzSblaikg1K fQit4eJ+mcD4eUi82iY9AOj7J6FXqpE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ivO/Hzfp"; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673529408; a=rsa-sha256; cv=none; b=i+stXzaF58ZcZmw5HNPS7XgJ8SB/KzW176NcejKb2N0VNyHLwOFM+fp746eADl6NOF9ACZ vy21l/5VUTVnPc0JmstPk//jlat4sS6lA2akZb8bIIZH7cdpSYYr3/sQxhSxF7HHlNhbuf 39Ve2FA+tQxD5xR7U12ApKQ+72fgFME= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zKBXSuS/0mrd++K5B4B9sqLRDVg+207ZHUFlsubT1ho=; b=ivO/HzfpPy5e0bP1agVhYaz32I Xo8kYhvJU22VOXdt0sJvH4stUcY76P4aRmzZ46O0H/PlO4ciORut/jJjGjBMFnrquJR6vwPBX37ZT tSdUWP82qbCzNkqXYwoI/hVRnK3oRctfyMbiJqC4rqn3nYS7QCqk3Bcp3lIkc3/Zoqr+S70sSspg2 /+UIhaaoSs/4JK8UvqVyG0beHy1BCOvO1U2pP8P8l/X39zGH0xQLYZjufqOu199KI3G4y2y2TMtmR mAxSPX330i+jjT3QUrnxe9sMHMYOb0ipW68ctxxhkk3VHpQrrsJGBspXEedO+c3jMuh5Z3PeVkM53 +dmUVRJA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFxRv-0054ud-3H; Thu, 12 Jan 2023 13:16:55 +0000 Date: Thu, 12 Jan 2023 13:16:55 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, vishal.moola@gmail.com Subject: Re: [PATCH -next] mm: madvise: use vm_normal_folio() in madvise_free_pte_range() Message-ID: References: <20230112124028.16964-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112124028.16964-1-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: dbtcr36t4neitdfeqfagmixpwymgkrs6 X-Rspamd-Queue-Id: 90A0A40009 X-HE-Tag: 1673529408-878977 X-HE-Meta: U2FsdGVkX1/qE9jdGvKHbns8CUgluz7EzsAlEe1YlWVJJGm1mUBiBbq+C601MqiCPtESF6fpt/QzgQo1KHmTwL34fzP5mVo7CIfzy5NDbqhwxhim0thjiAIegUbqyXMcIb2JWTdZfNYTIZ4WRL5n0+uUJVHNtpVLxW8zGpYwXfZXc1FH6lvK/yiMJxGXtaXTrfBwlocNMS8X1olhR2DK43UVNG0S56LXjLO59lZpU8JA+iCbdbLZzGveFlJWFZj/wDMtkJfFI+x5r6EOLMY4z+HYk2YFG5V3D3X4/z91EkGGNta5u8KcWWvQsbiEL7GbO5xJ+jWF8/p1yXHx+AE7xtY9F9fYU2A7GqVkJwT1r357Tyg9+xZ5eDpQW5f6WL4pWCStkLx/nlhkB77zv4Df8t+U74YARcuQdP6aIXCxt21/T2Io7aoH1Jqc19V+lFQzNwUyglmY4+yy7nqleO0v+F/FfOWlDLencECN7m/OESgDx8vmZnhnAXwW42QmjT9tYG7fkqVBw441VVaP7hIp8e92rK9rx/yCEbC8vgK/rHmr/ZV3qJQn2r7CCJB/ihLEPJGS0jVUWmXWglAx+DF+N3UgocmoJsyb1IkYHk6oNylewZ+X7ROmwsqS+bJosWrmfh9dqoFQ+4QHDPA0/V98R6aHf/65j2MwFpoC0FR+ABVrsKAWaCN8g0IFlXIqzNx5Z1PxuEvi9iIubQjGE+xmFHICtSi6QZqSqeaHBegjXtRQxn8E4ee09Etgm7Nug+f9QaJ6yzWzPf8tT6VV/phtM1QKCDdDIln+5K9YKn3OOgvGluGPLz8OLHkFmpNnhCrSrDQbOE8RxK6Nh7BnQTtpF+UQocEGWcA1syU3x2rGXj8jjf9q2BszN4MHqm8oQ5A2MyMohZxXm2t53YbA+PbeDXquSqtmHc5SHuAQT9neDQ8n0/AO546b+kGzQNyyqHRStFxDdBz2EF4uVLQku6a z/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 12, 2023 at 08:40:28PM +0800, Kefeng Wang wrote: > There is already a vm_normal_folio(), use it to make > madvise_free_pte_range() only use a folio. In my defence, there wasn't a vm_normal_folio() at the time I modified this function to use folios ;-) Reviewed-by: Matthew Wilcox (Oracle)