From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4DEC25B50 for ; Tue, 24 Jan 2023 11:16:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90E4A6B0075; Tue, 24 Jan 2023 06:16:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BCA96B0074; Tue, 24 Jan 2023 06:16:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 784F66B0075; Tue, 24 Jan 2023 06:16:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67AA66B0072 for ; Tue, 24 Jan 2023 06:16:39 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 35085140A16 for ; Tue, 24 Jan 2023 11:16:39 +0000 (UTC) X-FDA: 80389439718.05.E49E589 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 015A0140002 for ; Tue, 24 Jan 2023 11:16:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N2qDdHWY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674558996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=momH0HPs9/dujR5jLKnxv1qgvtn1YcK8SolE1GhOB4U=; b=6ANGSrA4hjhEnhfdIkaEr06pyHkLMJKuRaH8EZXe4dpG+c1duGbFQOjUim3SEJdnYW8pJi x2cOU/3zh6Mk0z6etAAGDYGm54BHr23YgG304ASgzElSnVC5yDKbQ0daCLjVNYUh5HS7dr dKqLrkDEcomunAJ3isy9aQ2EI5Cr+sQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N2qDdHWY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674558996; a=rsa-sha256; cv=none; b=7zbmUPObBtjpvevkwih9iGoh9Oz7YefP356Mywm68WiHV/lKsxnX6SDuD3d6g7/UbsrS65 8e8+evVj+KaH6knC4nz2X/7iMq+Kfv9yuXOM0XvZSm3Ocw7Gb6jjC3U//opVUjaEB2KmVp e6OdqzvJomQD2TEay1Ge0EEhhGnFkFA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8A7460F7F; Tue, 24 Jan 2023 11:16:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF644C433D2; Tue, 24 Jan 2023 11:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674558994; bh=VFgWKUXRmBeqnN9+X5YE4oCai3W5xNvHzLxb1SYdmas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N2qDdHWYOcHoqzldk1nQ6njv+/5dbLTBti8PUnsfqt7NKFZFbfOJuQpaktg7jf7bS aBROW63NBfleI9miL4mP/ezn/PAd5yUQbpyWy5A7bBGjrNSTSho3+ZSJbZBATppiyg UsCu7Ao34SWwdBdmtjD77S/odfWOEh6WgcEIIs6kp+NjGS4fFZyicOFKevJDsyP+lg jbcyXumk/o9/g9Wp8FsfJWu43GtO4XjnK3z+UweDuLMjICfveJQj2R6kZef7LU2bCI 3vHxaYd0KBzfEzRCarhI8iaWOfRxrzDmnLACN27E1aWhzjcroZNQJfqE972iSaIGHp QIlOoVkD10uuQ== Date: Tue, 24 Jan 2023 13:16:20 +0200 From: Mike Rapoport To: Vlastimil Babka Cc: Jonathan Corbet , Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , "Matthew Wilcox (Oracle)" , Mel Gorman , Michal Hocko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko Subject: Re: [PATCH v4 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description Message-ID: References: <20230115184212.996298-1-rppt@kernel.org> <20230115184212.996298-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 015A0140002 X-Stat-Signature: bsy681uo4ipt8j9cwne6dq5bwfek95e3 X-HE-Tag: 1674558995-549765 X-HE-Meta: U2FsdGVkX1/ODQMUzdcd46HMmLbttSr37suNvmCYE2gzORi9D6s8xAMyJbsfmJKU55Zb4mW2BHscL0uK5tpoh2HHgmyhSswLC36/HnnpmreHqkcvisQcXIkzkniT3+Ejmgg5RMga3Yk6A/MIVLk/GTQIkvsxpd6bjkbg0eUKzMuPyPOuMvCnuyszgpArCJJiQ/JJ/3J2noUm/bG6p6omEqsBJ/n7RcNsy9GPeVLTE+SOoy7cjbNEwuMcmXd/Qv4NXSWqu8AwY1CEOlqiAVga0OsMx5ZVsXbotZTlq/Jj4eaVd/4jny0onB9QSHaS0sJW0rZIt5kv988HM+VMj2nP82Unm9feGLn3HIM3aPJQcXt70jXLaGI/stUY0f/pWHNSooH75ebqN5mZljyu0pEGX0gzGhDs2ptBJWopML4MSoUmhgko4GWq7G9tNbDAGaXQiR+SO3VFhdHEZl+Z0Tms1menAQIBQ4h0JD3sF05zwbk8zVqxS85C9oM21ugXfFJ9KBu4bNkJOK+TWUitWzzzKAGmEyZGXU057AGbuS4c6DbOIrBitBSwxa4I+SdMvNmirm4Oqnoy9HtWSkdKRPa+kBSzSk/aEd3Npz6a86zlYVSLjstGiGdY+lJN/bWlmmre3M11e7FlISAI+b7ShAfFZ2h4SfXoX1uTKdWuC3VHD5zfuzw4trBDbrZOp8rsX9oZhB4vl6Zc01PIayd3QUJ5sJD3c42afzbZ/R2sgHPgwKcddaE2gyAijNPjBEijRWGJpvDT1wDx/VF9wSbC6SH4/x/icYBSja+lZhexXRhE9MZccpSuLyPB/mG1b8Yh9l3E4zGI9TflrJulHInLVxX+A8V+HI4mStsDOVRvebzs1Z1kH3327pGlR0o097l94/EI1JnANSGbbkve799si9sYHciDmbw+3W04ygrieRdGhH8UwJWPSZD4h52dXH8G2tE0NHlBlaSOrh6iHC/9WLI XkFJxN/B j6b7LGJ4aMLCnFwgT7vLIYXP4r8m9GzPaf622YlZgU1LIo9aRLXhAEZgJEdMUY9DpGr1RwTZCv/rEUyddoPi9DfFjenaEtv2gZNI6U8W17nfJZFQSReuqv/b0GACRXRMncX2iyxC9sW+LGP3gZXXIYLFsdSX+1vaPEtqT2YDjOdT/eTfTM+4y6x5rgi3zskyOY/6XmvvwVF7++pIx38DjQ4aVIJyuF8Ootpcftaewxn3o7H38rvYP60VE+daP5g7BoAhsinpVg9eCA0osZdM17CMMKkPIBCTOGGHsmPKdHp9q6krK8FEuniBnVPfwk7XerjY9fFu5dvwF8WC4pZuW5H1hZ9+WmpE7tkFhdUW6AhPLKFQLkXGbEtexo1ICtzMEB7hGg1k2/sEodx84fSpHUCk2sNVrqnS2caLNoYPywwbvC1eCU8ZvA+Z2Y4SQEAEgGNlb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 12:00:07PM +0100, Vlastimil Babka wrote: > On 1/15/23 19:42, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > Add structure, introduction and Nodes section to Physical Memory > > chapter. > > > > As the new documentation references core-api/dma-api and mm/page_reclaim, > > add page labels to those documents. > > > > Reviewed-by: Bagas Sanjaya > > Reviewed-by: Lorenzo Stoakes > > Acked-by: Michal Hocko > > Signed-off-by: Mike Rapoport (IBM) > > Acked-by: Vlastimil Babka > > A small bug to fix below? > > > > > + > > +Along with the node structures, kernel maintains an array of ``nodemask_t`` > > +bitmasks called ``node_states``. Each bitmask in this array represents a set of > > +nodes with particular properties as defined by ``enum node_states``: > > + > > +``N_POSSIBLE`` > > + The node could become online at some point. > > +``N_ONLINE`` > > + The node is online. > > +``N_NORMAL_MEMORY`` > > + The node has regular memory. > > +``N_HIGH_MEMORY`` > > + The node has regular or high memory. When ``CONFIG_HIGHMEM`` is disabled > > + aliased to ``N_NORMAL_MEMORY``. > > Noted. > > > +``N_MEMORY`` > > + The node has memory(regular, high, movable) > > +``N_CPU`` > > + The node has one or more CPUs > > + > > +For each node that has a property described above, the bit corresponding to the > > +node ID in the ``node_states[]`` bitmask is set. > > + > > +For example, for node 2 with normal memory and CPUs, bit 2 will be set in :: > > + > > + node_states[N_POSSIBLE] > > + node_states[N_ONLINE] > > + node_states[N_NORMAL_MEMORY] > > + node_states[N_MEMORY] > > + node_states[N_CPU] > > Should it be set also in node_states[N_HIGH_MEMORY]? You mean because of the aliasing of N_NORMAL_MEMORY and N_HIGH_MEMORY?