From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D8DC25B4E for ; Tue, 24 Jan 2023 14:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9542E6B0072; Tue, 24 Jan 2023 09:53:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 904906B0075; Tue, 24 Jan 2023 09:53:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CD046B0081; Tue, 24 Jan 2023 09:53:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6DFD66B0072 for ; Tue, 24 Jan 2023 09:53:12 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4D21EA097C for ; Tue, 24 Jan 2023 14:53:12 +0000 (UTC) X-FDA: 80389985424.06.375D8EC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 64AC2A0015 for ; Tue, 24 Jan 2023 14:53:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XdNW0Fhs; spf=none (imf25.hostedemail.com: domain of BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674571990; a=rsa-sha256; cv=none; b=wLOvKg9O3gDasYQ5i2CTzwZ5TuO0HxA7/21LLdMGYivd7bA9ptE9jCjcX3KBoENa0Dfyvp suktwNmrj82JpJK6/1YrnjsQ8XSszgnGNIvGf6DkwVJV3UOCS+UheKoRcYzr9yPsjTLs69 brt4M2oN6i4hq5tGTnUPQ6l7Blj9BYk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XdNW0Fhs; spf=none (imf25.hostedemail.com: domain of BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674571990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlxO/ih5kKpQ090HZsMiu8xqao4TSbrCxWBxIkEv8rw=; b=GaJnCIJeVIO3cJc1Bg4mf4biQmMsZ5Dtoc9DYkaxWOMR+E4wcWA4EXw9YnQX7uy8IoNlQE 5iKWLOk4s9RH8bZpOfhX7Zu+smzKgSSp7BLv8EQLWZkJdZ55YNCujo5HgYY5WFGNLLWBzS 9euw0hZmdJZhOkKSLU0x2WpVzLFgxjE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HlxO/ih5kKpQ090HZsMiu8xqao4TSbrCxWBxIkEv8rw=; b=XdNW0Fhs0ElZ3hlOb19ZbXNqNq m1D95Gyk1XM3hLiOSk6l3Oxh6IKVac757NWWnzo46edcGjy3nbnydIesEjVhK6FihmUBb73PzDTvv Q9gKr+rLPkbB6vJXegnCUF9bYNocKqHa6/BvKC71DBAzhqeaZpZcc8Yvziy+XTGlCm9rLY29FWIZM Lg/WJquY9I2k4P7nJ1ggpjgr2Gd1Hnfu0CpqWXHKsv/KShHMLtkr7nug5HMNJzM52leN7ASOo5efP mv0LrmtHILL4AAzcgM0q7LUbqafujXs00MvH9NSQRT8Zi9iK0EQ8rz2Fd16/VQkP7tHb/C2wkFgNu 7Ill09lQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKKfL-004QIg-QR; Tue, 24 Jan 2023 14:52:51 +0000 Date: Tue, 24 Jan 2023 06:52:51 -0800 From: Christoph Hellwig To: David Howells Cc: David Hildenbrand , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 03/10] mm: Provide a helper to drop a pin/ref on a page Message-ID: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-4-dhowells@redhat.com> <874546.1674571293@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874546.1674571293@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 64AC2A0015 X-Rspamd-Server: rspam01 X-Stat-Signature: qqwne6so6q1rbsxmbhj51onnezfzrx8s X-HE-Tag: 1674571989-941164 X-HE-Meta: U2FsdGVkX1836Km26N1ExQ+jr1ZkCWRlMOjbl7JNe4zgTxYBhDKsMkbQWbtQlfzgOFlD+Af8h14OmlEntJtfocatQke6Ba/gdkpUf0lu2qmlWf53rwbCzOtIerwuxf+CrJ/4j3P5p10Ga3EvRStmhNhmWK2/VE7hPhpplh8UYWZ2qXoM3CfC9/U59PHAYWjnssnfYnitrGgLTIOG51Sc6unx+9e/rn/ucVCGUBIr9Dz7zNKXOl6x5zwOBl19BhhYnz6lJpLcwKUuLlNbhzVSjppATdGaajpxgbJtdVSVykx1I4Z49CuZu/EtSg7XBV9fLSSNsKZJnexgkdtF+7IH+hIHYPFdq02LcUlLAsTro5WY3Y3dSB+EEPbU4Af8gQ3P0pThq8P7U1nCoH6f42ul6p+NLhakUykWhr0Zp1TbHQQO/xak36JeurMCSHk17zhxzoSqDvJj7B8+5vJtCG7Z+zFDLut2T5XSOKP8uslnnH/JXwCdMyimuQjgy+lLtDXLUm4AWHbX94B3Tbv75wXLS1WPAF6AIXnpG6YnMPM0tLgiARUXCjXDoSA5pndSmAWmzhlmR2EuXLnYGe2CkkB9KP4dotJcsNu6B5updwREpMibJlbk6p9d+KHHcypoOUoaDxLgGZzAbnR4oVU2tEFtqzoqLXZrObvuBerXkH12jVSwTse/E9jn/EEcA9rD3zHcD/D+AAx2+40h7DpiZaxdGnEHodPHYMk37cAhpIwCtOWlyQxjtCxf3X8J1Fd++sISSizf9heXwu3ezBufH0K4dnvpD9bT9v6D9L29y59lt0u2doJ4XfBnqHAbXe1tb2KfVmZrvcqHo2pN38NpGS8DXBva9dSk+n+N7lqcITEPhNCkWHcOR7ZKr5n5HMlDAV3H9zS5bmgkI7NZ7AxYTrm6NgzhmLzP4DZAV+HFL9JOTiQ7zGC/yNofk4mCCPz1O2USc8wCPZ/+X+zoGIoqayw 64E1RtKn G2fjuXsJ8ZZ2QofZ7VVwsx8NceMUZrTtI0wsYUHHdd//OTjLWHWZt1MNrfGcosb9VexeBGfUBI5/e4WWCugDFcH6JpYI7s/dJEII+zhxsOFacCqUn8ku/goMUICgQeIKj+4C7qwmTkOnC4bxgf+Nv8lEverLy8zO9HUAY6EWOEuiaXu86ITtX2htlKutnDJfIg5n2FR9QjgRT6pRlzF53PfW/DQ5E8P32tLa0STSO0/jGcffg/We5bub6qvCeInWAp0D2XSXqZVR6oalcsVyECPvx0oWuUuGSwEbZpEQUvScdKBBErN1KExfWF+W1CYIg5euYyOokJz5aED+dua6AoKgcQ5z7qusQ127kXpPk8xoPHs9fAXYm349VWbxuHgPQwRU7MAwysJXZaNXapwOz8NpClVpRfu/HFoVR74l4nLZXrMqUZf0OUo87p8QNS96DR/B6IrCeeBSPkZ4m2AqW1vBmTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 02:41:33PM +0000, David Howells wrote: > Yes. Christoph insisted that the bio conversion patch be split up. That > means there's an interval where you can get FOLL_GET from that. The only place where we have both is in the block layer. It never gets set by bio_set_cleanup_mode. Instead we can just keep using put_page dirctly for the BIO_PAGE_REFFED case in the callers of bio_release_page and in bio_release_pages itself, and then do away with bio_to_gup_flags and bio_release_page entirely.