From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07963C54E94 for ; Tue, 24 Jan 2023 14:44:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 871696B007D; Tue, 24 Jan 2023 09:44:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 821396B007E; Tue, 24 Jan 2023 09:44:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C1886B0080; Tue, 24 Jan 2023 09:44:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 595DB6B007D for ; Tue, 24 Jan 2023 09:44:31 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2353F80B56 for ; Tue, 24 Jan 2023 14:44:31 +0000 (UTC) X-FDA: 80389963542.07.0D25308 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by imf06.hostedemail.com (Postfix) with ESMTP id 10D19180011 for ; Tue, 24 Jan 2023 14:44:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=JWSCAIs2; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf06.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.77 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674571468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IRHm2/zQ+7v5wmZb/FJyK3YCzESK/meL/Gv4ezwdRac=; b=dHPWgx3KfUHqCEMygdYv4rgecWY+g3wv/oKjMY/6oaFCIE3H4eccJ67tsGTAkwH2i0WLfg Z0F4PnxkTHeu2qT/pUJRYUL8Vgr+3xukkBp6iNFf1DnY+aDSpOBCexynIndsStr5BIh2ek ne/7bm7zwiAMMqEuhdJtQqlWlRYdTXs= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=JWSCAIs2; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf06.hostedemail.com: domain of jgg@nvidia.com designates 40.107.243.77 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674571468; a=rsa-sha256; cv=pass; b=MMXUysItiLs3etE9c7JuXq7bFjqU+Um+JbqZ5w74eHS8j4D/qsojRYC9Ha7D/1RTI0Ad8D zpLFi1AlApVYzCGq1EKT+0mtozIv8+bPlKrQ+zd0R+jqIAbAdiI2HMilCdNd38N5df8AtJ +f188b3w9o256wjhRgbXMVKbQNGfMw0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P8/bhQldsxQYt6pCXdDEGy8hvlGgC4tH8eaA1OuT2C8svSBwjS6n+AkPCzAIciXI5392wjfD0nJmvGVk3vz0pfJFgc9xPreT4qYc1ndHRyjGI7KpwVB3pM3JsxIfm8SRAkoerDTXaojjAfIix+FKl95S3epmobHIRLNmj6W+Fo/XfGnl04kAqeEou7kO0zhmdMxpalPOHaifQukn/TAFqWDZz50COgz8kHowTjEUuOD6RAbb76MhVViwLGtvhTckepV4Jr24RtnkkK+f7KVqKLCuzvq7ONsF9N8iZdDyxw4gXNPQtX694ZCA+t0dRJ1egGSPUPndRJgVb9ggPLTcXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IRHm2/zQ+7v5wmZb/FJyK3YCzESK/meL/Gv4ezwdRac=; b=jhmiMB5duHSx8WMh9J7rNQQPzt/Ai5ZQLORGgh0Q1OjTe55SzjLD1K9wiJnjBYZWauacIS1Z4H6IiZR2rj7eGvaBTnlf8Oe13xxOfTsfkpwN+sArtfydEvXLA7SODtsF5WymjZAJhqa3xjRjzKgqqY5ogy4+d7+GBbDoT2LHBz4y2FEaFS+42z1YOTxSzO8Fw5MgyJMuKSSbPcTlQSsKdx4E97TqCkPnbSVw9gw05ZC4LARonW+aI1m0A//g2X2SWtSZ8d8430TZzzmNVNPZucGl6ogAI17XZzf+AkfbSBzjoP13GKnltPR3kc7qxcs3epSokljAI/veDQoLOtodlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IRHm2/zQ+7v5wmZb/FJyK3YCzESK/meL/Gv4ezwdRac=; b=JWSCAIs2SFD9upzteUIafUKRRpzcn3pDuQSqrGdqbl21L01tY5qvxi1ghbkKU3pbGqwGqr6RSy0SYPk8jS2n4kqpbJqamP8XTjdLNU1h/N2rm8ny39wSkDvEui5zB4U3wOTQZiQyzKhEEntFh8GF1ZFphaGko3ujSdm/i6eVeo3yHSvUSQ6FX++hVYyWXX/Gt49w7m+O4pX5rgT0CLFltvL3iE+klIKU6Ddlh//k5MGzbKh6YRrVNiJ2Yk/vyKjCKJwsHtoST+qbToTM/F2pZs1phUbX1W3q6qmaQ0F6xWbHu+hpgUYlpz8g6mNYmvfbjUz5bnxFGmwOQUm2D++WkA== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by BY5PR12MB4195.namprd12.prod.outlook.com (2603:10b6:a03:200::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 14:44:25 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee%4]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 14:44:25 +0000 Date: Tue, 24 Jan 2023 10:44:24 -0400 From: Jason Gunthorpe To: Alistair Popple Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch, Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [RFC PATCH 09/19] io_uring: convert to use vm_account Message-ID: References: <9f63cf4ab74d6e56e434c1c3d7c98352bb282895.1674538665.git-series.apopple@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f63cf4ab74d6e56e434c1c3d7c98352bb282895.1674538665.git-series.apopple@nvidia.com> X-ClientProxiedBy: MN2PR10CA0003.namprd10.prod.outlook.com (2603:10b6:208:120::16) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|BY5PR12MB4195:EE_ X-MS-Office365-Filtering-Correlation-Id: 1472bd8a-deee-49cc-aae6-08dafe197d48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rkAM9kOpn4CTZICxZ+gC32ARE4eKwzGXjBa7IgcVXwiGi4bZ81drBDjRSe3ayfiWvf0h0lLqZolipQ1W6lUApTo2m+80yCIcgMBcTvm2qMkO5DPl8WZX6oIbvSoO7jDubVjNOXyOD5oDL2LhJl54BX7zn1e+yWFurmcNa4S0hZdLAa/WwXM4eUrPhPxfrnGE6ZLab0etU+BmxvwMOG3nxuLobZ2fevMb+KTJzJVma54sAuP4VLnmCzNd+7MshfpvTEL5ENOakNYbZlDjvdaNcQEjaZzVSl2nShghuh3Mb94IbBNybMkQ35ALGqy8+UPiGahAOKJyvlBg5yAg5LL9dExRVZEJ4apaX4VPuEzwJzy/V0GSNtj70nvokyk8ZhCv+l5JXZNld9MY9ENcVkDQzIwcXy9MWSnRA2xXEu/TmOgTS8mdQCRLJNOTK6+22F/dX12AbRREUz7jJXmyPrvWyhSWpbVoqErBElSosRcCeKWnDUFVYyEGTDKsz66ddAltltX58x22W1zZnn1Qx+gd4tRitza56vBLMpf4LCXiLBy6WkCyCX4lJbf7k31VQyDoRqmfupDqFTV4/qhWouDRBwlmCGHlwQIoBHf4oVMZDH28ZhCMuyzXgyWZmH2JBo41GZ8roaur2lIlLjqey1jaWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(36756003)(41300700001)(86362001)(7416002)(8936002)(5660300002)(4326008)(6862004)(4744005)(2906002)(38100700002)(83380400001)(6486002)(478600001)(66946007)(6512007)(26005)(6506007)(186003)(8676002)(316002)(37006003)(54906003)(2616005)(6636002)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+bb7f6BgOBy6VjWf+jh6VJ7WrjD2UrL2H8Kf5uJZ+sWf7e5EzN9yJU1XVWPT?= =?us-ascii?Q?pjGzsCmXmy0X4ffr/gqAmy3KaNYlHRFCsZR8tOltaDEtmCpSrGEjbdDNgPpY?= =?us-ascii?Q?enagC4eVTi/gMzmo26muGRnqCZ9xslY/eB6gaTG70YJGAZmTjXc/vciFSxHN?= =?us-ascii?Q?AVEfP1TWZjvrX544jmb0el30WZYZcvlfJVpc+TncKZfKPXx6qaNFLU1Wx2Gw?= =?us-ascii?Q?cbZDKHrlI1TLWVrg0ax0wYFdJjwOzrk+9wbsMglPrH98+DytlgCjOQYZzPc8?= =?us-ascii?Q?m2jyDKUpJylErMCNAwKXFFYI+Wh3Tdr8h2uDZjJWvB9JPpcnxvOJRxHaPA5k?= =?us-ascii?Q?LPIph1NhEi2mpdZgmqOdfnomXehNg+wEliyhn4OnZ7010jcpkIC09W/Bgkko?= =?us-ascii?Q?HflqQP2jPDKwYBuLek2zMK2mjEwyhJUu6XpoPA1Uqg7hoFyGj1OYZqcZrjGp?= =?us-ascii?Q?wuFoKqO4e2cnWqrTqYU5toV8d3euDYYUCq3f2cb8RK5KdQb+rXXHx2hV49jl?= =?us-ascii?Q?Nf4Ktj8q/cXl4bOBzXdMHr9Akur3hzbQWLRZvSSz3Mk26P73G74mHgmHQ3ZI?= =?us-ascii?Q?k+JZFjnE72PoL7k/P3rMUNrtw9V0nAbrkScSWRPAwegqeJGk8AFpDK2GJBm9?= =?us-ascii?Q?PHR5SusTwh2LbKmZOpv9l8Ty+yBKty5xKAvsuQYHYLZGcqW+oYyRmK4wbT4M?= =?us-ascii?Q?7QuIx59c+8DWgspT8FWg92+VjfGlMCrBJynzU55sEXMyqWgjcMqVKe94/cna?= =?us-ascii?Q?SYgSbhGQe3fHujYYxBsxhUBEwyT8wqOdOpbFo2XHYjrj/MOCPJK01lupw1pt?= =?us-ascii?Q?RqqrFvAG9sTH2xvWbgW1cNj8gFtbx4fmLGsnf/6QU57U6ksizdzxI1qyIlpV?= =?us-ascii?Q?PW6+7FwMMgJmA1qHTw4SKNt0XczDXldyEEweg7MRyFCsndiJ/GfTkP0GMCSm?= =?us-ascii?Q?H7FlbWJmAVp7g76N5j2StrhQxjvVpo1C2zsKNVF/jCdX86Y8x8NVYnDy8n+D?= =?us-ascii?Q?h394Sw+wlx3R0R4GcAHOI7tFUeimdPaNW4LCSCFd4ErF1pJpxRtCGrth7fbc?= =?us-ascii?Q?bH6JNI+8ciVe6w77oRwPAkIdxvhuFh2yKtVJQ/2BSNPwtxJ+JY1wYdMyBBly?= =?us-ascii?Q?YMg7neD5av133MAsUyVnQ5yMDzKyDH6qH2Ed3ObG/wjLkuS0HgTYPivm7MXm?= =?us-ascii?Q?I7eUA0ZZlLMoPwks2HVEJ69eMTGVDzuA7pz7vUwf+1+yY0dWM5yPwV11SOp4?= =?us-ascii?Q?Ssmcu15dX7GiNYd5cG89ULLVAkXZpkYB8MwMfjcNxeNILerJH8WVz5aQF83+?= =?us-ascii?Q?T6LXp8JjFwmAyBHpBXb67dcGh+ncM7r6bhACHi3D2qtK9wHXcO6IKFneapGO?= =?us-ascii?Q?Rns8gRKHsBOat8QfYLbfSwnFdUjZg7uASm9xGh8oSKBAbBEbN124jJIR0YfG?= =?us-ascii?Q?YwnP2iQ75MyBMJ8FDqo5V3z6BB3NrnDB0eF7qV59Pp0Qf9Bo8zz4Aoz6WsKP?= =?us-ascii?Q?bkCFgzFK/zgSO/cdRKMBIADUuF3aA4BJS5N7cl00ZBRzIWMmw0QjjPnLNS/G?= =?us-ascii?Q?JD5ClDzmXLxMIMer+OvGo2S60IvIHZA5S3/Kzda7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1472bd8a-deee-49cc-aae6-08dafe197d48 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 14:44:25.7305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hAO1JluyH5dqic/CttkROlav6uFFjbcF6ThHDJM/mc5FXp8arCaWxIwOlYey8ebR X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4195 X-Rspamd-Queue-Id: 10D19180011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9nj983bz48bigwh346yznyqbar8d3qtw X-HE-Tag: 1674571467-840511 X-HE-Meta: U2FsdGVkX197zpUHfZCZFFIbfErxKBkjsXHrRVsrtgANZipOcOxITYw5S3341qIWPQk9k/wrQRC/Ip1keqsumYL2MDEps8xrb6RCn9TGbhRzKf1hEGEVCXSmC6tBViveZbMYfczpxN1jQvqF4KabkOKRWMnbHpHJSWTlYcV8urdLtbrj3/jusbWnX4XYVvEUTeCQ7Vx7LarvZm4Zk30pBuwQycyt0jgYxXXjS6cCVtT5DRme5mIQJr+2WvlceudEJ7OyVNDXBDFKkvsXuqS7WD6jXS/ISQLn6pT7Qz8xswrb56yU25e+XVbupl8Zdr48Jh2laVgtVi7S36GikEF3amvl2UbBufh1I6PBfccxJlE1leWXnHbJcoyCWx7TgY1TqiAoWPyu+VN2o2DM+dFo0DKbgur07jTIWxKumP8QcYWaGKzobtijB62huLalBeaT8TZl/WAv0Rb6SBxVaIJk7PHTYbeXRoRszbY0KYsIsmesk9z3vPUt8k53cjAgRd9JRptdbO0/YA+mEmxEJS/+JMsqA+CjHXSNZ9aWBBCLG4JzVwJIJ9XYUFdTEJ87Cw4xlR6D+AqzIKGgZIvyCq13rwWKt5N/71eAcVKcKILmsDr/bjpvbsTdGP/54CMDel0DaRCP10+XLMaJua+KSWv2oLotf7IIQMtQ3jGwytv9fQBqhlwLAAzy4+aTkP+F94nt9NEjwPT042KtXYr07P3Bj7F9+Ku41NUKca4j7f6uFV/bUKvt6xaJogrT0x3SbjhnKaz5Y3VAUUs8FsjEmQgBwfSyCVd15Y8ReRx9kX17I1tiHxij3QJ2jxJCINdQQYv10riO4wxTXqu22CeScmX3Uh0sxsMMaEJKeq18jbz/LFKUuu4aQvoXnB9K34PKgqfZ8ZHFRfi8z9D7PmmSRnDdvuojV3GtunR1mHAyc9jCnpOTrp5wSNVWJ4wdoWPFRWMWHTGbYtSOd8vEuqAlaxZ fzhBahc3 lmoLwiAmH/Kv0Iufob+TsoThgOufrvcnJ4zvRrNDP/fyDwdf3oC2R5DZ7WZTcXEAarsf09605mptRuvi3p/whnwipt0jN4If+RhZ6aIYFZlvu01ybzHw4i1xOIAu59geCv+5Xp/8397ehKnGBu/9b/zkkDe301GU0qovgkbVOERdKFcKy/k27/Q25gZ/Zb/hB9Rfk0fq3n3PuM4VVJr5mXnHp23SoUoqB3JffDB3CIkH3uW+9LzqPTTHU/iRT5jparxDDsHQ/8ckZLRV6V6hhOGbd8mbBrKQinkkiB018Dr6x4DsuanXhS+9e1BXpFElkuBPJF/6S0Az4PIOidDouPUOM2fwyFUElIeqH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 04:42:38PM +1100, Alistair Popple wrote: > Convert io_uring to use vm_account instead of directly charging pages > against the user/mm. Rather than charge pages to both user->locked_vm > and mm->pinned_vm this will only charge pages to user->locked_vm. I think this is a mistake in the first patch, the pinned_vm should still increment (but not checked against the rlimit), though its main purpose in this mode is for debugging in proc. Jason